diff mbox series

[Openvpn-devel,v2] GitHub Actions: trigger openvpn-build GHA on success

Message ID 20220605004013.319-1-lstipakov@gmail.com
State Accepted, archived
Headers show
Series [Openvpn-devel,v2] GitHub Actions: trigger openvpn-build GHA on success | expand

Commit Message

Lev Stipakov June 4, 2022, 2:40 p.m. UTC 
From: Lev Stipakov <lev@openvpn.net>

After successfult builds on all platforms,
start openvpn-build GHA which produces
Windows MSI installers.

Signed-off-by: Lev Stipakov <lev@openvpn.net>
---
 v2:

  - bring pull_request trigger back
  - simplify trigger_openvpn_build run condition

 .github/workflows/build.yaml | 19 +++++++++++++++++--
 1 file changed, 17 insertions(+), 2 deletions(-)

Comments

Samuli Seppänen June 15, 2022, 9:24 p.m. UTC | #1 
Acked-by: Samuli Seppänen <samuli@openvpn.net>

Il 05/06/22 03:40, Lev Stipakov ha scritto:
> From: Lev Stipakov <lev@openvpn.net>
> 
> After successfult builds on all platforms,
> start openvpn-build GHA which produces
> Windows MSI installers.
> 
> Signed-off-by: Lev Stipakov <lev@openvpn.net>
> ---
>   v2:
> 
>    - bring pull_request trigger back
>    - simplify trigger_openvpn_build run condition
> 
>   .github/workflows/build.yaml | 19 +++++++++++++++++--
>   1 file changed, 17 insertions(+), 2 deletions(-)
> 
> diff --git a/.github/workflows/build.yaml b/.github/workflows/build.yaml
> index d34f4e9a..6c267a61 100644
> --- a/.github/workflows/build.yaml
> +++ b/.github/workflows/build.yaml
> @@ -1,6 +1,8 @@
>   # The name of our workflow
>   name: Build
> -on: [push, pull_request]
> +on:
> +  push:
> +  pull_request:
>   
>   jobs:
>     checkuncrustify:
> @@ -32,6 +34,7 @@ jobs:
>         - name: Set job status
>           run: test ! -s uncrustify-changes.patch
>           working-directory: openvpn
> +
>     mingw:
>       strategy:
>         fail-fast: false
> @@ -250,7 +253,6 @@ jobs:
>         - name: make check
>           run: make check
>   
> -
>     macos:
>       runs-on: macos-latest
>       strategy:
> @@ -344,3 +346,16 @@ jobs:
>               ${{ matrix.plat }}-Output/${{env.BUILD_CONFIGURATION}}/*.dll
>               ${{ matrix.plat }}-Output/${{env.BUILD_CONFIGURATION}}/*.pdb
>               doc/openvpn.8.html
> +
> +  trigger_openvpn_build:
> +    runs-on: windows-latest
> +    needs: [checkuncrustify, mingw, ubuntu, ubuntu-clang-asan, macos, msvc]
> +    if: ${{ github.event_name != 'pull_request' && github.repository == 'openvpn/openvpn' && github.ref == 'refs/heads/master' }}
> +
> +    steps:
> +    - name: Repository Dispatch
> +      uses: peter-evans/repository-dispatch@v2
> +      with:
> +        token: ${{ secrets.OPENVPN_BUILD_REPO_DISPATCH }}
> +        repository: openvpn/openvpn-build
> +        event-type: openvpn-commit
David Sommerseth June 17, 2022, 1:06 a.m. UTC | #2 
From: David Sommerseth <davids@openvpn.net>

Your patch has been applied

commit 6a26cb51297024b563603faf78a33298b5d59f30 master
Author: Lev Stipakov
Date:   Sun, 05 Jun 2022 00:40:13 +0000

     GitHub Actions: trigger openvpn-build GHA on success

     Signed-off-by: Lev Stipakov
     Patchwork-Id: 2508
     URL: https://patchwork.openvpn.net/patch/2508/
     Signed-off-by: David Sommerseth


--
kind regards,

David Sommerseth
David Sommerseth June 17, 2022, 1:27 a.m. UTC | #3 
On 17/06/2022 13:06, David Sommerseth wrote:
> From: David Sommerseth <davids@openvpn.net>
> 
> Your patch has been applied
> 
> commit 6a26cb51297024b563603faf78a33298b5d59f30 master
> Author: Lev Stipakov
> Date:   Sun, 05 Jun 2022 00:40:13 +0000
> 
>       GitHub Actions: trigger openvpn-build GHA on success
> 
>       Signed-off-by: Lev Stipakov
>       Patchwork-Id: 2508
>       URL: https://patchwork.openvpn.net/patch/2508/
>       Signed-off-by: David Sommerseth
> 

Unfortunately, my patchwork script failed when creating the reply 
message and I spotted it too late.  The Acked-by line was stripped out.

The proper reply message should have been:

commit 6a26cb51297024b563603faf78a33298b5d59f30 master
Author: Lev Stipakov
Date:   Sun, 05 Jun 2022 00:40:13 +0000

      GitHub Actions: trigger openvpn-build GHA on success

      Signed-off-by: Lev Stipakov
      Acked-by: Samuli Seppänen
      Patchwork-Id: 2508
      URL: https://patchwork.openvpn.net/patch/2508/
      Signed-off-by: David Sommerseth
diff mbox series

Patch

diff --git a/.github/workflows/build.yaml b/.github/workflows/build.yaml
index d34f4e9a..6c267a61 100644
--- a/.github/workflows/build.yaml
+++ b/.github/workflows/build.yaml
@@ -1,6 +1,8 @@ 
 # The name of our workflow
 name: Build
-on: [push, pull_request]
+on:
+  push:
+  pull_request:
 
 jobs:
   checkuncrustify:
@@ -32,6 +34,7 @@  jobs:
       - name: Set job status
         run: test ! -s uncrustify-changes.patch
         working-directory: openvpn
+
   mingw:
     strategy:
       fail-fast: false
@@ -250,7 +253,6 @@  jobs:
       - name: make check
         run: make check
 
-
   macos:
     runs-on: macos-latest
     strategy:
@@ -344,3 +346,16 @@  jobs:
             ${{ matrix.plat }}-Output/${{env.BUILD_CONFIGURATION}}/*.dll
             ${{ matrix.plat }}-Output/${{env.BUILD_CONFIGURATION}}/*.pdb
             doc/openvpn.8.html
+
+  trigger_openvpn_build:
+    runs-on: windows-latest
+    needs: [checkuncrustify, mingw, ubuntu, ubuntu-clang-asan, macos, msvc]
+    if: ${{ github.event_name != 'pull_request' && github.repository == 'openvpn/openvpn' && github.ref == 'refs/heads/master' }}
+
+    steps:
+    - name: Repository Dispatch
+      uses: peter-evans/repository-dispatch@v2
+      with:
+        token: ${{ secrets.OPENVPN_BUILD_REPO_DISPATCH }}
+        repository: openvpn/openvpn-build
+        event-type: openvpn-commit