[Openvpn-devel] GitHub Actions: Add new libcap-ng-dev dependency

Message ID 20220811113422.451-1-timo@rothenpieler.org
State Accepted
Headers show
Series [Openvpn-devel] GitHub Actions: Add new libcap-ng-dev dependency | expand

Commit Message

Timo Rothenpieler Aug. 11, 2022, 1:34 a.m. UTC
Linux builds need this now in order to retain capabilities when dropping root privileges.
---
 .github/workflows/build.yaml | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

Comments

Gert Doering Aug. 11, 2022, 2 a.m. UTC | #1
Acked-by: Gert Doering <gert@greenie.muc.de>

Haven't tested anything, but it looks like it will fix the build - and
GHA will tell me very soon :-)

Your patch has been applied to the master branch.

commit 4fb4d295d647292c6bc0c036a061f3f60aaa1278
Author: Timo Rothenpieler
Date:   Thu Aug 11 13:34:22 2022 +0200

     GitHub Actions: Add new libcap-ng-dev dependency

     Acked-by: Gert Doering <gert@greenie.muc.de>
     Message-Id: <20220811113422.451-1-timo@rothenpieler.org>
     URL: https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg24870.html
     Signed-off-by: Gert Doering <gert@greenie.muc.de>


--
kind regards,

Gert Doering

Patch

diff --git a/.github/workflows/build.yaml b/.github/workflows/build.yaml
index b905c0d2..c89d3c8c 100644
--- a/.github/workflows/build.yaml
+++ b/.github/workflows/build.yaml
@@ -224,7 +224,7 @@  jobs:
     runs-on: ${{matrix.os}}
     steps:
       - name: Install dependencies
-        run: sudo apt update && sudo apt install -y liblzo2-dev libpam0g-dev liblz4-dev linux-libc-dev man2html libcmocka-dev python3-docutils libtool automake autoconf ${SSLPKG} ${NLPKG}
+        run: sudo apt update && sudo apt install -y liblzo2-dev libpam0g-dev liblz4-dev libcap-ng-dev linux-libc-dev man2html libcmocka-dev python3-docutils libtool automake autoconf ${SSLPKG} ${NLPKG}
       - name: Checkout OpenVPN
         uses: actions/checkout@v2
       - name: autoconf
@@ -248,7 +248,7 @@  jobs:
     runs-on: ${{matrix.os}}
     steps:
       - name: Install dependencies
-        run: sudo apt update && sudo apt install -y liblzo2-dev libpam0g-dev liblz4-dev linux-libc-dev man2html clang libcmocka-dev python3-docutils libtool automake autoconf libmbedtls-dev
+        run: sudo apt update && sudo apt install -y liblzo2-dev libpam0g-dev liblz4-dev libcap-ng-dev linux-libc-dev man2html clang libcmocka-dev python3-docutils libtool automake autoconf libmbedtls-dev
       - name: Checkout OpenVPN
         uses: actions/checkout@v2
       - name: autoconf