[Openvpn-devel] error.c: remove unused crash() function

Message ID	20220813212040.113-1-lstipakov@gmail.com
State	Accepted
Headers	show Return-Path: <openvpn-devel-bounces@lists.sourceforge.net> From: Lev Stipakov <lstipakov@gmail.com> To: openvpn-devel@lists.sourceforge.net Date: Sun, 14 Aug 2022 00:20:40 +0300 Message-Id: <20220813212040.113-1-lstipakov@gmail.com> preview: From: Lev Stipakov This has been added in 2006 and as of now not used. Signed-off-by: Lev Stipakov --- src/openvpn/error.c \| 9 --------- src/openvpn/error.h \| 5 ----- 2 files changed, 14 deletions(-) Content analysis details: (-0.2 points, 6.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [209.85.208.174 listed in list.dnswl.org] 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider [lstipakov[at]gmail.com] -0.0 RCVD_IN_MSPIKE_H2 RBL: Average reputation (+2) [209.85.208.174 listed in wl.mailspike.net] -0.0 SPF_PASS SPF: sender matches SPF record -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature -0.1 DKIM_VALID_EF Message has a valid DKIM or DK signature from envelope-from domain 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain Subject: [Openvpn-devel] [PATCH] error.c: remove unused crash() function Precedence: list Cc: Lev Stipakov <lev@openvpn.net> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: openvpn-devel-bounces@lists.sourceforge.net X-getmail-retrieved-from-mailbox: Inbox
Series	[Openvpn-devel] error.c: remove unused crash() function \| expand [Openvpn-devel] error.c: remove unused crash() function

Message ID

20220813212040.113-1-lstipakov@gmail.com

State

Accepted

Headers

From: Lev Stipakov <lstipakov@gmail.com>
To: openvpn-devel@lists.sourceforge.net
Date: Sun, 14 Aug 2022 00:20:40 +0300
Message-Id: <20220813212040.113-1-lstipakov@gmail.com>
Subject: [Openvpn-devel] [PATCH] error.c: remove unused crash() function
Precedence: list
Cc: Lev Stipakov <lev@openvpn.net>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Errors-To: openvpn-devel-bounces@lists.sourceforge.net

Series

[Openvpn-devel] error.c: remove unused crash() function | expand

From: Lev Stipakov <lev@openvpn.net> This has been added in 2006 and as of now not used. Signed-off-by: Lev Stipakov <lev@openvpn.net> --- src/openvpn/error.c | 9 --------- src/openvpn/error.h | 5 ----- 2 files changed, 14 deletions(-)

Comments

Gert Doering Aug. 13, 2022, 10:47 p.m. UTC | #1

Acked-by: Gert Doering <gert@greenie.muc.de>

Dead code indeed.  And if we want to crash, we can do this without help!

Test compiled on Linux.

Your patch has been applied to the master branch.

commit 1e1ec038168f22afa584aea79a0323a9fdf45095
Author: Lev Stipakov
Date:   Sun Aug 14 00:20:40 2022 +0300

     error.c: remove unused crash() function

     Signed-off-by: Lev Stipakov <lev@openvpn.net>
     Acked-by: Gert Doering <gert@greenie.muc.de>
     Message-Id: <20220813212040.113-1-lstipakov@gmail.com>
     URL: https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg24924.html
     Signed-off-by: Gert Doering <gert@greenie.muc.de>


--
kind regards,

Gert Doering

diff --git a/src/openvpn/error.c b/src/openvpn/error.c
index 7cd35b17..c8c77358 100644
--- a/src/openvpn/error.c
+++ b/src/openvpn/error.c
@@ -808,15 +808,6 @@  msg_flags_string(const unsigned int flags, struct gc_arena *gc)
     return BSTR(&out);
 }
 
-#ifdef ENABLE_DEBUG
-void
-crash(void)
-{
-    char *null = NULL;
-    *null = 0;
-}
-#endif
-
 #ifdef _WIN32
 
 const char *
diff --git a/src/openvpn/error.h b/src/openvpn/error.h
index 972619fe..89adb3e6 100644
--- a/src/openvpn/error.h
+++ b/src/openvpn/error.h
@@ -220,11 +220,6 @@  __attribute__((__noreturn__))
     [!!sizeof(struct { int __error_if_negative : (expr) ? 2 : -1; })]
 #endif
 
-#ifdef ENABLE_DEBUG
-void crash(void);  /* force a segfault (debugging only) */
-
-#endif
-
 /* Inline functions */
 
 static inline bool

[Openvpn-devel] error.c: remove unused crash() function

Commit Message

Comments

Patch