diff mbox series

[Openvpn-devel] make dist: Ship ovpn_dco_freebsd.h, too

Message ID 20230127203208.305638-1-matthias.andree@gmx.de
State Accepted
Headers show
Series [Openvpn-devel] make dist: Ship ovpn_dco_freebsd.h, too | expand

Commit Message

Matthias Andree Jan. 27, 2023, 8:32 p.m. UTC 
This file was missing from src/openvpn/Makefile.am.
---
 src/openvpn/Makefile.am | 1 +
 1 file changed, 1 insertion(+)

--
2.39.1

Comments

Gert Doering Jan. 28, 2023, 6:55 p.m. UTC | #1 
Acked-by: Gert Doering <gert@greenie.muc.de>

To see the actual failure, one needs to build a tarball ("make dist"),
and from that tarball, compile with "configure --enable-dco", on FreeBSD
- so a pure "make distcheck" did not see it.  Apologies for that oversight.

Your patch has been applied to the master and release/2.6 branch.

commit ffcf20ca7070027ccb16c3697b2a0e263cbc78a4 (master)
commit 680ba43355f6d9e4dcdf6c6eb9ace09946dba8f3 (HEAD -> release/2.6)
Author: Matthias Andree
Date:   Fri Jan 27 21:32:08 2023 +0100

     make dist: Ship ovpn_dco_freebsd.h, too

     Acked-by: Gert Doering <gert@greenie.muc.de>
     Message-Id: <20230127203208.305638-1-matthias.andree@gmx.de>
     URL: https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg26085.html
     Signed-off-by: Gert Doering <gert@greenie.muc.de>


--
kind regards,

Gert Doering
Matthias Andree Jan. 28, 2023, 10:38 p.m. UTC | #2 
Am 28.01.23 um 19:55 schrieb Gert Doering:
> Acked-by: Gert Doering <gert@greenie.muc.de>
>
> To see the actual failure, one needs to build a tarball ("make dist"),
> and from that tarball, compile with "configure --enable-dco", on FreeBSD
> - so a pure "make distcheck" did not see it.  Apologies for that oversight.
>
> Your patch has been applied to the master and release/2.6 branch.

Hi Gert,

Danke.

We could set AM_DISTCHECK_CONFIGURE_FLAGS=--enable-dco (and possibly
other --enable-* or -with-*) in the relevant Makefile.am though if you
want a more complete feature set in "make distcheck".

Cheers,
Matthias
diff mbox series

Patch

diff --git a/src/openvpn/Makefile.am b/src/openvpn/Makefile.am
index 3ed73fa4..a8e44528 100644
--- a/src/openvpn/Makefile.am
+++ b/src/openvpn/Makefile.am
@@ -78,6 +78,7 @@  openvpn_SOURCES = \
 	mbuf.c mbuf.h \
 	memdbg.h \
 	misc.c misc.h \
+	ovpn_dco_freebsd.h \
 	ovpn_dco_linux.h \
 	ovpn_dco_win.h \
 	platform.c platform.h \