diff mbox series

[Openvpn-devel,v1] buf_string_match_head_str: Fix Coverity issue "Unsigned compared against 0"

Message ID 20240119120341.22933-1-gert@greenie.muc.de
State Accepted
Headers show
Series [Openvpn-devel,v1] buf_string_match_head_str: Fix Coverity issue "Unsigned compared against 0" | expand

Commit Message

Gert Doering Jan. 19, 2024, 12:03 p.m. UTC 
From: Frank Lichtenheld <frank@lichtenheld.com>

As Coverity says:
An unsigned value can never be negative, so this test will always
evaluate the same way.

Was changed from int to size_t in commit
7fc608da4ec388c9209bd009cd5053ac0ff7df38 which triggered warning,
but the check did not make sense before, either.

Change-Id: I64f094eeb0ca8c3953a94d742adf468faf27dab3
Signed-off-by: Frank Lichtenheld <frank@lichtenheld.com>
Acked-by: Arne Schwabe <arne-openvpn@rfc2549.org>
---

This change was reviewed on Gerrit and approved by at least one
developer. I request to merge it to master.

Gerrit URL: https://gerrit.openvpn.net/c/openvpn/+/491
This mail reflects revision 1 of this Change.
Acked-by according to Gerrit (reflected above):
Arne Schwabe <arne-openvpn@rfc2549.org>

Comments

Gert Doering Jan. 19, 2024, 1:10 p.m. UTC | #1 
Arguably coverity is right here :-)

Your patch has been applied to the master and release/2.6 branch (bugfix).

commit bc29bd6a3376158b73d069758122739fbf93c022 (master)
commit 68b00a54e779325f4ac9d9416b4e85261f771c23 (release/2.6)
Author: Frank Lichtenheld
Date:   Fri Jan 19 13:03:41 2024 +0100

     buf_string_match_head_str: Fix Coverity issue 'Unsigned compared against 0'

     Signed-off-by: Frank Lichtenheld <frank@lichtenheld.com>
     Acked-by: Arne Schwabe <arne-openvpn@rfc2549.org>
     Message-Id: <20240119120341.22933-1-gert@greenie.muc.de>
     URL: https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg28093.html
     Signed-off-by: Gert Doering <gert@greenie.muc.de>


--
kind regards,

Gert Doering
diff mbox series

Patch

diff --git a/src/openvpn/buffer.c b/src/openvpn/buffer.c
index 0b94a52..2ad3461 100644
--- a/src/openvpn/buffer.c
+++ b/src/openvpn/buffer.c
@@ -822,7 +822,7 @@ 
 buf_string_match_head_str(const struct buffer *src, const char *match)
 {
     const size_t size = strlen(match);
-    if (size < 0 || size > src->len)
+    if (size > src->len)
     {
         return false;
     }