[Openvpn-devel,v1] Haiku: change del to delete in route command. del is undocumented

Message ID 20250128124129.109647-1-frank@lichtenheld.com
State Accepted
Headers show
Series [Openvpn-devel,v1] Haiku: change del to delete in route command. del is undocumented | expand

Commit Message

Frank Lichtenheld Jan. 28, 2025, 12:41 p.m. UTC
From: Alexander von Gluck <alex@terarocket.io>

Change-Id: Ieca0f8aa07413682d39e73dd3ed21a0038d41f49
Signed-off-by: Alexander von Gluck <alex@terarocket.io>
Acked-by: Frank Lichtenheld <frank@lichtenheld.com>
---

This change was reviewed on Gerrit and approved by at least one
developer. I request to merge it to master.

Gerrit URL: https://gerrit.openvpn.net/c/openvpn/+/690
This mail reflects revision 1 of this Change.

Signed-off-by line for the author was added as per our policy.

Acked-by according to Gerrit (reflected above):
Frank Lichtenheld <frank@lichtenheld.com>

Comments

Gert Doering Jan. 28, 2025, 6:01 p.m. UTC | #1
Not much to test here :-) - patch only affects #ifdef TARGET_HAIKU blocks
and only "route" command line naming.

Your patch has been applied to the master branch.

commit 625b3e91b9a5b3283ae59cdab253a55e34feea7f
Author: Alexander von Gluck
Date:   Tue Jan 28 13:41:29 2025 +0100

     Haiku: change del to delete in route command. del is undocumented

     Signed-off-by: Alexander von Gluck <alex@terarocket.io>
     Acked-by: Frank Lichtenheld <frank@lichtenheld.com>
     Message-Id: <20250128124129.109647-1-frank@lichtenheld.com>
     URL: https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg30655.html
     Signed-off-by: Gert Doering <gert@greenie.muc.de>


--
kind regards,

Gert Doering

Patch

diff --git a/src/openvpn/route.c b/src/openvpn/route.c
index d17b285..12d6c07 100644
--- a/src/openvpn/route.c
+++ b/src/openvpn/route.c
@@ -2359,8 +2359,8 @@ 
 
 #elif defined(TARGET_HAIKU)
 
-    /* ex: route del /dev/net/ipro1000/0 inet 192.168.0.0 gw 192.168.1.1 netmask 255.255.0.0 */
-    argv_printf(&argv, "%s del %s inet %s gw %s netmask %s",
+    /* ex: route delete /dev/net/ipro1000/0 inet 192.168.0.0 gw 192.168.1.1 netmask 255.255.0.0 */
+    argv_printf(&argv, "%s delete %s inet %s gw %s netmask %s",
                 ROUTE_PATH,
                 rgi->iface,
                 network,
@@ -2551,8 +2551,8 @@ 
         "on connect only and will clean up automatically.");
 #elif defined(TARGET_HAIKU)
 
-    /* ex: route del /dev/net/ipro1000/0 inet6 :: gw beef::cafe prefixlen 64 */
-    argv_printf(&argv, "%s del %s inet6 %s gw %s prefixlen %d",
+    /* ex: route delete /dev/net/ipro1000/0 inet6 :: gw beef::cafe prefixlen 64 */
+    argv_printf(&argv, "%s delete %s inet6 %s gw %s prefixlen %d",
                 ROUTE_PATH,
                 r6->iface,
                 network,