diff mbox series

[Openvpn-devel] Update systemd service name param to match command

Message ID 20250729180014.11550-2-sourceforge@terrance.allofti.me
State New
Headers show
Series [Openvpn-devel] Update systemd service name param to match command | expand

Commit Message

Terrance July 29, 2025, 6 p.m. UTC 
From: Terrance <git@terrance.allofti.me>

The service name displays `%I` which invokes systemd's path mangling
(notably, converting `-` to `/`), suggesting you need to provide an
encoded parameter (via e.g. `systemd-escape`), but the start command
itself uses `%i` which doesn't do the conversion.

This updates the service name to match the start command.
---
Additional discussion: https://github.com/OpenVPN/openvpn/pull/802

 distro/systemd/openvpn-client@.service.in | 2 +-
 distro/systemd/openvpn-server@.service.in | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

--
2.50.1

Comments

Frank Lichtenheld July 30, 2025, 9:30 a.m. UTC | #1 
On Tue, Jul 29, 2025 at 07:00:05PM +0100, Terrance via Openvpn-devel wrote:
> From: Terrance <git@terrance.allofti.me>
> 
> The service name displays `%I` which invokes systemd's path mangling
> (notably, converting `-` to `/`), suggesting you need to provide an
> encoded parameter (via e.g. `systemd-escape`), but the start command
> itself uses `%i` which doesn't do the conversion.
> 
> This updates the service name to match the start command.

Change makes sense to me. I haven't specifically tested it but it only
changes the description so I don't see how it could break anything.

Acked-by: Frank Lichtenheld <frank@lichtenheld.com>

Regards,
Timo Rothenpieler July 30, 2025, 12:16 p.m. UTC | #2 
On 29/07/2025 20:00, Terrance via Openvpn-devel wrote:
> From: Terrance <git@terrance.allofti.me>
> 
> The service name displays `%I` which invokes systemd's path mangling
> (notably, converting `-` to `/`), suggesting you need to provide an
> encoded parameter (via e.g. `systemd-escape`), but the start command
> itself uses `%i` which doesn't do the conversion.
> 
> This updates the service name to match the start command.

This makes me wonder if it isn't the one passed to the start command 
that's actually not what it was intended to be.

Cause using %I there would enable to put configs in subdirs. With %i 
that's impossible, since it can't contain slashes.
Frank Lichtenheld July 31, 2025, 12:25 p.m. UTC | #3 
On Wed, Jul 30, 2025 at 02:16:43PM +0200, Timo Rothenpieler wrote:
> On 29/07/2025 20:00, Terrance via Openvpn-devel wrote:
> > From: Terrance <git@terrance.allofti.me>
> > 
> > The service name displays `%I` which invokes systemd's path mangling
> > (notably, converting `-` to `/`), suggesting you need to provide an
> > encoded parameter (via e.g. `systemd-escape`), but the start command
> > itself uses `%i` which doesn't do the conversion.
> > 
> > This updates the service name to match the start command.
> 
> This makes me wonder if it isn't the one passed to the start command that's
> actually not what it was intended to be.
> 
> Cause using %I there would enable to put configs in subdirs. With %i that's
> impossible, since it can't contain slashes.

Yes, I agree. I think %I would have been better to use exactly for the reason
you mention. But I think it is too late now. If we would switch to %I now it
would break existing configs.

Regards,
Gert Doering July 31, 2025, 12:33 p.m. UTC | #4 
I have not tested this, but "since this is systemd description only",
I wouldn't really know what to test - and Frank knows better, so fine
with me :-)

I have added a signed-off-by: line as we require (and our docs say
"this will be added if missing").

Thanks, Terrance, for helping us make OpenVPN better ;-)

Your patch has been applied to the master branch.

commit 8854550d4da0b29af122723def898d38e6b3fea2
Author: Terrance
Date:   Tue Jul 29 19:00:05 2025 +0100

     Update systemd service name param to match command

     Signed-off-by: Terrance <git@terrance.allofti.me>
     Acked-by: Frank Lichtenheld <frank@lichtenheld.com>
     Message-Id: <20250729180014.11550-2-sourceforge@terrance.allofti.me>
     URL: https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg32423.html
     Signed-off-by: Gert Doering <gert@greenie.muc.de>


--
kind regards,

Gert Doering
diff mbox series

Patch

diff --git a/distro/systemd/openvpn-client@.service.in b/distro/systemd/openvpn-client@.service.in
index ae62e8c7..c32bb333 100644
--- a/distro/systemd/openvpn-client@.service.in
+++ b/distro/systemd/openvpn-client@.service.in
@@ -1,4 +1,4 @@ 
 [Unit]
-Description=OpenVPN tunnel for %I
+Description=OpenVPN tunnel for %i
 After=network-online.target
 Wants=network-online.target
diff --git a/distro/systemd/openvpn-server@.service.in b/distro/systemd/openvpn-server@.service.in
index 5123e072..547f5f54 100644
--- a/distro/systemd/openvpn-server@.service.in
+++ b/distro/systemd/openvpn-server@.service.in
@@ -1,4 +1,4 @@ 
 [Unit]
-Description=OpenVPN service for %I
+Description=OpenVPN service for %i
 After=network-online.target
 Wants=network-online.target