diff mbox series

[Openvpn-devel,v1] GHA: enable -Werror for mbedTLS v3 and AWS LC builds

Message ID 20250804133413.24729-1-gert@greenie.muc.de
State New
Headers show
Series [Openvpn-devel,v1] GHA: enable -Werror for mbedTLS v3 and AWS LC builds | expand

Commit Message

Gert Doering Aug. 4, 2025, 1:34 p.m. UTC 
From: Frank Lichtenheld <frank@lichtenheld.com>

Because we can and so we should.

Change-Id: I9159e2e354170ad6dbed5a6ce620f57fa8ab128e
Signed-off-by: Frank Lichtenheld <frank@lichtenheld.com>
Acked-by: Yuriy Darnobyt <yura.uddr@gmail.com>
---

This change was reviewed on Gerrit and approved by at least one
developer. I request to merge it to master.

Gerrit URL: https://gerrit.openvpn.net/c/openvpn/+/1128
This mail reflects revision 1 of this Change.

Acked-by according to Gerrit (reflected above):
Yuriy Darnobyt <yura.uddr@gmail.com>

Comments

Gert Doering Aug. 4, 2025, 1:37 p.m. UTC | #1 
Indeed!

Your patch has been applied to the master branch.

commit c667671653fbe0b781cab6eee3e7c90783ffd132
Author: Frank Lichtenheld
Date:   Mon Aug 4 15:34:07 2025 +0200

     GHA: enable -Werror for mbedTLS v3 and AWS LC builds

     Signed-off-by: Frank Lichtenheld <frank@lichtenheld.com>
     Acked-by: Yuriy Darnobyt <yura.uddr@gmail.com>
     Message-Id: <20250804133413.24729-1-gert@greenie.muc.de>
     URL: https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg32505.html
     Signed-off-by: Gert Doering <gert@greenie.muc.de>


--
kind regards,

Gert Doering
diff mbox series

Patch

diff --git a/.github/workflows/build.yaml b/.github/workflows/build.yaml
index cc17fba..0f88d0c 100644
--- a/.github/workflows/build.yaml
+++ b/.github/workflows/build.yaml
@@ -425,7 +425,7 @@ 
       - name: autoconf
         run: autoreconf -fvi
       - name: configure
-        run: ./configure --with-crypto-library=mbedtls
+        run: ./configure --with-crypto-library=mbedtls --enable-werror
       - name: make all
         run: make -j3
       - name: configure checks
@@ -489,7 +489,7 @@ 
           OPENSSL_CFLAGS="-I/${{ env.AWS_LC_INSTALL }}/include" \
           OPENSSL_LIBS="-L/${{ env.AWS_LC_INSTALL }}/lib -lssl -lcrypto" \
           LDFLAGS="-Wl,-rpath=/${{ env.AWS_LC_INSTALL }}/lib" \
-          ./configure --with-crypto-library=openssl
+          ./configure --with-crypto-library=openssl --enable-werror
       - name: make all
         run: make -j3
       - name: configure checks