[Openvpn-devel,v1] buffer: remove unused function buf_write_alloc_prepend

Message ID 20250806144238.11332-1-gert@greenie.muc.de
State New
Headers show
Series [Openvpn-devel,v1] buffer: remove unused function buf_write_alloc_prepend | expand

Commit Message

Gert Doering Aug. 6, 2025, 2:42 p.m. UTC
From: Frank Lichtenheld <frank@lichtenheld.com>

Change-Id: I71981e39932cafe3fd68b475fdb81a8f20a3a547
Signed-off-by: Frank Lichtenheld <frank@lichtenheld.com>
Acked-by: Gert Doering <gert@greenie.muc.de>
---

This change was reviewed on Gerrit and approved by at least one
developer. I request to merge it to master.

Gerrit URL: https://gerrit.openvpn.net/c/openvpn/+/1134
This mail reflects revision 1 of this Change.

Acked-by according to Gerrit (reflected above):
Gert Doering <gert@greenie.muc.de>

Comments

Gert Doering Aug. 6, 2025, 6:05 p.m. UTC | #1
"Remove unused function" is easy to review :-) - out it goes.  BB and
"git grep" confirm.

Your patch has been applied to the master branch.

commit 028846f0f73db0e598a8fcdb3d5578bb5920046c
Author: Frank Lichtenheld
Date:   Wed Aug 6 16:42:31 2025 +0200

     buffer: remove unused function buf_write_alloc_prepend

     Signed-off-by: Frank Lichtenheld <frank@lichtenheld.com>
     Acked-by: Gert Doering <gert@greenie.muc.de>
     Message-Id: <20250806144238.11332-1-gert@greenie.muc.de>
     URL: https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg32565.html
     Signed-off-by: Gert Doering <gert@greenie.muc.de>


--
kind regards,

Gert Doering

Patch

diff --git a/src/openvpn/buffer.h b/src/openvpn/buffer.h
index 8d6bb64..6f15115 100644
--- a/src/openvpn/buffer.h
+++ b/src/openvpn/buffer.h
@@ -644,12 +644,6 @@ 
 }
 
 static inline uint8_t *
-buf_write_alloc_prepend(struct buffer *buf, int size, bool prepend)
-{
-    return prepend ? buf_prepend(buf, size) : buf_write_alloc(buf, size);
-}
-
-static inline uint8_t *
 buf_read_alloc(struct buffer *buf, int size)
 {
     uint8_t *ret;