diff mbox series

[Openvpn-devel,v1] route: Add #endif comment for uncrustify compliance

Message ID 20251017205730.8450-1-gert@greenie.muc.de
State Accepted
Headers show
Series [Openvpn-devel,v1] route: Add #endif comment for uncrustify compliance | expand

Commit Message

Gert Doering Oct. 17, 2025, 8:57 p.m. UTC 
From: Frank Lichtenheld <frank@lichtenheld.com>

Cherry-pick dca6b03098ab0f3ef808c891673305651dc6704a
broke uncrustify compliance. Apparently this one added
line pushed it over the limit to require the #endif
comment.

Change-Id: I46d0e4be82a5cc7e466d6e8f658e5b131b5401c4
Signed-off-by: Frank Lichtenheld <frank@lichtenheld.com>
Acked-by: Gert Doering <gert@greenie.muc.de>
Gerrit URL: https://gerrit.openvpn.net/c/openvpn/+/1284
---

This change was reviewed on Gerrit and approved by at least one
developer. I request to merge it to release/2.6.

Gerrit URL: https://gerrit.openvpn.net/c/openvpn/+/1284
This mail reflects revision 1 of this Change.

Acked-by according to Gerrit (reflected above):
Gert Doering <gert@greenie.muc.de>

Comments

Gert Doering Oct. 18, 2025, 4:48 p.m. UTC | #1 
Yeah, this is a really silly edge-case - you fix one -Werror fail, and
that triggers an uncrustify style violation.  No code change, so nothing
to test here...

Your patch has been applied to the release/2.6 branch.

commit cf6c12f92af4391d82b1ca8e235c4cefde9ef5d2
Author: Frank Lichtenheld
Date:   Fri Oct 17 22:57:24 2025 +0200

     route: Add #endif comment for uncrustify compliance

     Signed-off-by: Frank Lichtenheld <frank@lichtenheld.com>
     Acked-by: Gert Doering <gert@greenie.muc.de>
     Gerrit URL: https://gerrit.openvpn.net/c/openvpn/+/1284
     Message-Id: <20251017205730.8450-1-gert@greenie.muc.de>
     URL: https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg33428.html
     Signed-off-by: Gert Doering <gert@greenie.muc.de>


--
kind regards,

Gert Doering
diff mbox series

Patch

diff --git a/src/openvpn/route.c b/src/openvpn/route.c
index 3ff9717..75e94c2 100644
--- a/src/openvpn/route.c
+++ b/src/openvpn/route.c
@@ -2368,7 +2368,7 @@ 
     {
         gateway_needed = true;
     }
-#endif
+#endif /* ifndef _WIN32 */
 
     struct gc_arena gc = gc_new();
     struct argv argv = argv_new();