| Message ID | 20251210074904.27067-1-gert@greenie.muc.de |
|---|---|
| State | New |
| Headers | show |
| Series | [Openvpn-devel,v1] Remove some obsolete references to --windows-driver | expand |
"Because it makes sense" :-) - stared at the change a bit, and the buildbots
confirm that it didn't accidentially break anything.
Your patch has been applied to the master branch.
commit 2ab3e8733e0d48395cea04ace7a44bbf59b507f4
Author: Frank Lichtenheld
Date: Wed Dec 10 08:48:58 2025 +0100
Remove some obsolete references to --windows-driver
Signed-off-by: Frank Lichtenheld <frank@lichtenheld.com>
Acked-by: Gert Doering <gert@greenie.muc.de>
Gerrit URL: https://gerrit.openvpn.net/c/openvpn/+/1426
Message-Id: <20251210074904.27067-1-gert@greenie.muc.de>
URL: https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg34970.html
Signed-off-by: Gert Doering <gert@greenie.muc.de>
--
kind regards,
Gert Doering
diff --git a/doc/man-sections/unsupported-options.rst b/doc/man-sections/unsupported-options.rst index e8e76eb..821ac07 100644 --- a/doc/man-sections/unsupported-options.rst +++ b/doc/man-sections/unsupported-options.rst @@ -49,3 +49,8 @@ --opt-verify Removed in OpenVPN 2.7. This option does not make sense anymore as option strings may not match due to the introduction of parameters negotiation. + +--windows-driver + Removed in OpenVPN 2.7. OpenVPN will always use ovpn-dco as the default + driver on Windows. It will fall back to tap-windows6 if options are used + that are incompatible with ovpn-dco. diff --git a/doc/man-sections/vpn-network-options.rst b/doc/man-sections/vpn-network-options.rst index 2a06ef6..33ebedb 100644 --- a/doc/man-sections/vpn-network-options.rst +++ b/doc/man-sections/vpn-network-options.rst @@ -89,7 +89,7 @@ On Windows, only the names :code:`tun` and :code:`tap` are supported. Selection among multiple installed drivers or driver instances is done - with ``--dev-node`` and ``--windows-driver``. + with ``--dev-node``. --dev-node node This is a highly system dependent option to influence tun/tap driver diff --git a/src/openvpn/options.c b/src/openvpn/options.c index a3fc19d..1be105b 100644 --- a/src/openvpn/options.c +++ b/src/openvpn/options.c @@ -3905,16 +3905,7 @@ } else { - if (o->windows_driver == DRIVER_DCO) - { - msg(M_WARN, - "Option --windows-driver ovpn-dco is ignored because Data Channel Offload is disabled"); - o->windows_driver = WINDOWS_DRIVER_TAP_WINDOWS6; - } - else if (o->windows_driver == WINDOWS_DRIVER_UNSPECIFIED) - { - o->windows_driver = WINDOWS_DRIVER_TAP_WINDOWS6; - } + o->windows_driver = WINDOWS_DRIVER_TAP_WINDOWS6; } #else /* _WIN32 */ if (dco_enabled(o) && o->dev_node) diff --git a/src/openvpn/tun.c b/src/openvpn/tun.c index 7c61dcf..a7c5ebb 100644 --- a/src/openvpn/tun.c +++ b/src/openvpn/tun.c @@ -6061,7 +6061,7 @@ if (tt->backend_driver != windows_driver) { msg(M_FATAL, - "Adapter '%s' is using %s driver, %s expected. If you want to use this device, adjust --windows-driver.", + "Adapter '%s' is using %s driver, %s expected.", dev_node, print_tun_backend_driver(windows_driver), print_tun_backend_driver(tt->backend_driver)); }