diff mbox series

[Openvpn-devel,v1] openvpnmsica: Fix setting of iTicks in schedule_adapter_delete

Message ID 20260404203525.30790-1-gert@greenie.muc.de
State New
Headers show
Series [Openvpn-devel,v1] openvpnmsica: Fix setting of iTicks in schedule_adapter_delete | expand

Commit Message

Gert Doering April 4, 2026, 8:35 p.m. UTC 
From: Frank Lichtenheld <frank@lichtenheld.com>

Increase the integer, not the pointer.

Found by cppcheck.

Change-Id: I4d6501ddfb321f57a76841f29ff92c5a412908bb
Signed-off-by: Frank Lichtenheld <frank@lichtenheld.com>
Acked-by: Gert Doering <gert@greenie.muc.de>
Gerrit URL: https://gerrit.openvpn.net/c/openvpn/+/1608
---

This change was reviewed on Gerrit and approved by at least one
developer. I request to merge it to master.

Gerrit URL: https://gerrit.openvpn.net/c/openvpn/+/1608
This mail reflects revision 1 of this Change.

Acked-by according to Gerrit (reflected above):
Gert Doering <gert@greenie.muc.de>

Comments

Gert Doering April 5, 2026, 10:18 a.m. UTC | #1 
Good find.  A very clear bug, so goes back to release/2.7 and even
release/2.6 - now it does not really have much consequences except
progress bar not working correctly on uninstall... but still.

Your patch has been applied to the master, release/2.7 and release/2.6
branch.

commit 4494a343967e9cd0fcf32f167b22706512c8c68c (master)
commit f4669642581934d317707e56c297d777946ce5c4 (release/2.7)
commit 246bc0e8d022920889a69d19e2e534b9560c8d9a (release/2.6)
Author: Frank Lichtenheld
Date:   Sat Apr 4 22:35:19 2026 +0200

     openvpnmsica: Fix setting of iTicks in schedule_adapter_delete

     Signed-off-by: Frank Lichtenheld <frank@lichtenheld.com>
     Acked-by: Gert Doering <gert@greenie.muc.de>
     Gerrit URL: https://gerrit.openvpn.net/c/openvpn/+/1608
     Message-Id: <20260404203525.30790-1-gert@greenie.muc.de>
     URL: https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg36476.html
     Signed-off-by: Gert Doering <gert@greenie.muc.de>


--
kind regards,

Gert Doering
diff mbox series

Patch

diff --git a/src/openvpnmsica/openvpnmsica.c b/src/openvpnmsica/openvpnmsica.c
index a145b64..fdb610c 100644
--- a/src/openvpnmsica/openvpnmsica.c
+++ b/src/openvpnmsica/openvpnmsica.c
@@ -613,7 +613,7 @@ 
                 msica_arg_seq_add_tail(seq, szArgument);
             }
 
-            iTicks += MSICA_ADAPTER_TICK_SIZE;
+            *iTicks += MSICA_ADAPTER_TICK_SIZE;
             break; /* Adapter names are unique. There should be no other adapter with this name. */
         }
     }