From patchwork Wed Mar 31 07:03:22 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Maximilian Fillinger X-Patchwork-Id: 1678 Return-Path: Delivered-To: patchwork@openvpn.net Delivered-To: patchwork@openvpn.net Received: from director8.mail.ord1d.rsapps.net ([172.31.255.6]) by backend30.mail.ord1d.rsapps.net with LMTP id cAdaKWa9ZGCRYQAAIUCqbw (envelope-from ) for ; Wed, 31 Mar 2021 14:20:22 -0400 Received: from proxy8.mail.iad3b.rsapps.net ([172.31.255.6]) by director8.mail.ord1d.rsapps.net with LMTP id GN0dKWa9ZGBEeQAAfY0hYg (envelope-from ) for ; Wed, 31 Mar 2021 14:20:22 -0400 Received: from smtp36.gate.iad3b ([172.31.255.6]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) by proxy8.mail.iad3b.rsapps.net with LMTPS id +ExSIma9ZGD5DAAAoCsc3g (envelope-from ) for ; Wed, 31 Mar 2021 14:20:22 -0400 X-Spam-Threshold: 95 X-Spam-Score: 0 X-Spam-Flag: NO X-Virus-Scanned: OK X-Orig-To: openvpnslackdevel@openvpn.net X-Originating-Ip: [216.105.38.7] Authentication-Results: smtp36.gate.iad3b.rsapps.net; iprev=pass policy.iprev="216.105.38.7"; spf=pass smtp.mailfrom="openvpn-devel-bounces@lists.sourceforge.net" smtp.helo="lists.sourceforge.net"; dkim=fail (signature verification failed) header.d=sourceforge.net; dkim=fail (signature verification failed) header.d=sf.net; dkim=fail (key not found in DNS) header.d=foxcrypto.com; dmarc=fail (p=none; dis=none) header.from=foxcrypto.com X-Suspicious-Flag: YES X-Classification-ID: c1137854-924d-11eb-b870-5254003a7283-1-1 Received: from [216.105.38.7] ([216.105.38.7:40332] helo=lists.sourceforge.net) by smtp36.gate.iad3b.rsapps.net (envelope-from ) (ecelerity 4.2.38.62370 r(:)) with ESMTPS (cipher=DHE-RSA-AES256-GCM-SHA384) id 42/A0-07797-56DB4606; Wed, 31 Mar 2021 14:20:22 -0400 Received: from [127.0.0.1] (helo=sfs-ml-2.v29.lw.sourceforge.com) by sfs-ml-2.v29.lw.sourceforge.com with esmtp (Exim 4.92.3) (envelope-from ) id 1lRfR7-0007jN-E1; Wed, 31 Mar 2021 18:19:25 +0000 Received: from [172.30.20.202] (helo=mx.sourceforge.net) by sfs-ml-2.v29.lw.sourceforge.com with esmtps (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.92.3) (envelope-from ) id 1lRfR6-0007jC-6h for openvpn-devel@lists.sourceforge.net; Wed, 31 Mar 2021 18:19:24 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sourceforge.net; s=x; h=Content-Type:MIME-Version:Date:Subject:To:From: Sender:Reply-To:Message-ID:Cc:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:In-Reply-To:References:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=nyFsD4ROnwBMP4wHEBTVz8ri1Aq7/QY5RnVp+UH0YCA=; b=TmWoKgPfbUHS2xcJZ+09FTPmfw Ic6gIVDLPcLStyaXFLOHYojgJKCoWJeUwjCmaLpLRzE4Zhf1CLgV7Dh30cpv8twQiaR927cafCJ1G 3+aGj5Q0/zICCZXBgLrCeO+PP5wjUAvLZoO6IFjFUp1TiUddvjMsU6QfIqWg2P2SB3V8=; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sf.net; s=x ; h=Content-Type:MIME-Version:Date:Subject:To:From:Sender:Reply-To:Message-ID :Cc:Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To: References:List-Id:List-Help:List-Unsubscribe:List-Subscribe:List-Post: List-Owner:List-Archive; bh=nyFsD4ROnwBMP4wHEBTVz8ri1Aq7/QY5RnVp+UH0YCA=; b=j 0hotjO9r1c3i8Mzbg9dH7TXAz+wzsUQqKLCvBIG8rlIdkAZ6gTagpZOtz7eReCnBlMZEmwryx2r0T U6x+ZLHcQqjNmb1Abt0cYBkLAQrQGlfwPpyp+siaJ/AwbMx9TrdiLXKGq+Zvx3G5del+19Mm5axGB eR542d35lHnR78Fw=; Received: from nl-dft-mx-01.fox-it.com ([178.250.144.135]) by sfi-mx-1.v28.lw.sourceforge.com with esmtps (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.92.2) id 1lRfQu-000I8N-39 for openvpn-devel@lists.sourceforge.net; Wed, 31 Mar 2021 18:19:24 +0000 From: Max Fillinger To: Date: Wed, 31 Mar 2021 20:03:22 +0200 X-Mailer: git-send-email 2.11.0 MIME-Version: 1.0 X-ClientProxiedBy: FOXDFT1EX01.FOX.local (10.0.0.129) To FOXDFT1EX01.FOX.local (10.0.0.129) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; d=foxcrypto.com; s=NL-DFT-MX-01; c=relaxed/relaxed; h=from:to:subject:date:mime-version:content-type; bh=nyFsD4ROnwBMP4wHEBTVz8ri1Aq7/QY5RnVp+UH0YCA=; b=u1U3qxqJAu6pG28cemSK2cR/SMn3KPvD8hYwj0wnuKo7zNwHWNwOkVig2FcGCHaBvSrRdiQYgGy+ 6HqnPReZUrDsUQ9ovJi/zX/feBvNvgVzmeRB1hRS2XLDIoytNtgFkHWe4Sj8/cDSoUvcBPuaSutF IrKW/aQl0gkVezNeFZlL+ye/1X0BzdFSHdgt/33Zb9toYccGBzCXA3XHiRkJhT44u2l5XTpgFcVs r2yFKOaP4CKnn7SHGX7LFhdNkLgwGzShiurnhh3N6+ZZajpFtN4yothrnU5oA2QiY1rxOU5LumbK LQBZ+60v6hN5fdXm7zrmZ61DHaTBWLlLaWeG8g== X-Spam-Report: Spam Filtering performed by mx.sourceforge.net. See http://spamassassin.org/tag/ for more details. -0.0 SPF_PASS SPF: sender matches SPF record 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid 1.0 MISSING_MID Missing Message-Id: header 0.1 DKIM_INVALID DKIM or DK signature exists, but is not valid X-Headers-End: 1lRfQu-000I8N-39 Subject: [Openvpn-devel] [PATCH 0/1] reliable: retransmit if 3 follow-up ACKs are received X-BeenThere: openvpn-devel@lists.sourceforge.net X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: openvpn-devel-bounces@lists.sourceforge.net Message-Id: X-getmail-retrieved-from-mailbox: Inbox This is my second attempt at sending this patch, this time without mixing up commit message and cover letter, and from an account that (I hope) doesn't hate mailing lists. This patch changes reliable_send() to resend a packet if at least three later packets have been ACKed. This improves performance when there are small amounts of packet loss. The patch was originally written by Steffan Karger for OpenVPN-NL. I added some comments as suggested by Arne Schwabe. Steffan Karger (1): reliable: retransmit if 3 follow-up ACKs are received src/openvpn/reliable.c | 20 +++++++++++++++++--- src/openvpn/reliable.h | 7 +++++++ 2 files changed, 24 insertions(+), 3 deletions(-)