From patchwork Thu Apr 1 02:13:23 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Arne Schwabe X-Patchwork-Id: 1697 Return-Path: Delivered-To: patchwork@openvpn.net Delivered-To: patchwork@openvpn.net Received: from director13.mail.ord1d.rsapps.net ([172.30.191.6]) by backend30.mail.ord1d.rsapps.net with LMTP id iDlqEETHZWBeFAAAIUCqbw (envelope-from ) for ; Thu, 01 Apr 2021 09:14:44 -0400 Received: from proxy16.mail.ord1d.rsapps.net ([172.30.191.6]) by director13.mail.ord1d.rsapps.net with LMTP id kKAoEETHZWChPgAA91zNiA (envelope-from ) for ; Thu, 01 Apr 2021 09:14:44 -0400 Received: from smtp9.gate.ord1d ([172.30.191.6]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) by proxy16.mail.ord1d.rsapps.net with LMTPS id mCXiD0THZWDiNgAAetu3IA (envelope-from ) for ; Thu, 01 Apr 2021 09:14:44 -0400 X-Spam-Threshold: 95 X-Spam-Score: 0 X-Spam-Flag: NO X-Virus-Scanned: OK X-Orig-To: openvpnslackdevel@openvpn.net X-Originating-Ip: [216.105.38.7] Authentication-Results: smtp9.gate.ord1d.rsapps.net; iprev=pass policy.iprev="216.105.38.7"; spf=pass smtp.mailfrom="openvpn-devel-bounces@lists.sourceforge.net" smtp.helo="lists.sourceforge.net"; dkim=fail (signature verification failed) header.d=sourceforge.net; dkim=fail (signature verification failed) header.d=sf.net; dmarc=none (p=nil; dis=none) header.from=rfc2549.org X-Suspicious-Flag: YES X-Classification-ID: 394d8ba4-92ec-11eb-b2c6-525400bd3b1f-1-1 Received: from [216.105.38.7] ([216.105.38.7:53616] helo=lists.sourceforge.net) by smtp9.gate.ord1d.rsapps.net (envelope-from ) (ecelerity 4.2.38.62370 r(:)) with ESMTPS (cipher=DHE-RSA-AES256-GCM-SHA384) id 02/76-05275-347C5606; Thu, 01 Apr 2021 09:14:44 -0400 Received: from [127.0.0.1] (helo=sfs-ml-2.v29.lw.sourceforge.com) by sfs-ml-2.v29.lw.sourceforge.com with esmtp (Exim 4.92.3) (envelope-from ) id 1lRx8z-0007FH-W8; Thu, 01 Apr 2021 13:13:54 +0000 Received: from [172.30.20.202] (helo=mx.sourceforge.net) by sfs-ml-2.v29.lw.sourceforge.com with esmtps (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.92.3) (envelope-from ) id 1lRx8w-0007Ej-6v for openvpn-devel@lists.sourceforge.net; Thu, 01 Apr 2021 13:13:50 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sourceforge.net; s=x; h=Message-Id:Date:Subject:To:From:Sender:Reply-To:Cc: MIME-Version:Content-Type:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:In-Reply-To:References:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=ejgg5z+aeNxsRBZmab9206S8h0lrbVA3SuELT1pK2cs=; b=mlwOS6xCuhu5HO61p2/78wa9/B y6Myt5FvQu5XeumPgP+cYKWlsQqqu/EggY69AqwhGNKSTFD5DZ+3boEcDKThR/t+yq8SG92kXLO+r i1xUFDKjX/yGYBr6jqsUelgsrPp+ABT45q+jRP1OKau1SsIstIMqT2xdqCWIm0UN/T3I=; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sf.net; s=x ; h=Message-Id:Date:Subject:To:From:Sender:Reply-To:Cc:MIME-Version: Content-Type:Content-Transfer-Encoding:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: In-Reply-To:References:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=ejgg5z+aeNxsRBZmab9206S8h0lrbVA3SuELT1pK2cs=; b=R0o22Em3AeyR7OlOG0LX7Kzedw LGpNeHr87FMr+1qtUtYJBruQ8o/PtW+VJvr59SAoYblBqSz7E1XbDM8L/xMj2A1R08q4L50YVLZBP b2cyN+n9Gmq+7SBJDM238rOARgPXijuE1nCFroTFh2ywJUMFdx/y7SWbLHbmMJ7q6czQ=; Received: from mail.blinkt.de ([192.26.174.232]) by sfi-mx-2.v28.lw.sourceforge.com with esmtps (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.92.3) id 1lRx8q-0003Uh-3a for openvpn-devel@lists.sourceforge.net; Thu, 01 Apr 2021 13:13:50 +0000 Received: from kamera.blinkt.de ([2001:638:502:390:20c:29ff:fec8:535c]) by mail.blinkt.de with smtp (Exim 4.94 (FreeBSD)) (envelope-from ) id 1lRx8j-000J7r-M6 for openvpn-devel@lists.sourceforge.net; Thu, 01 Apr 2021 15:13:37 +0200 Received: (nullmailer pid 3729 invoked by uid 10006); Thu, 01 Apr 2021 13:13:37 -0000 From: Arne Schwabe To: openvpn-devel@lists.sourceforge.net Date: Thu, 1 Apr 2021 15:13:23 +0200 Message-Id: <20210401131337.3684-1-arne@rfc2549.org> X-Mailer: git-send-email 2.17.1 X-Spam-Report: Spam Filtering performed by mx.sourceforge.net. See http://spamassassin.org/tag/ for more details. 0.2 HEADER_FROM_DIFFERENT_DOMAINS From and EnvelopeFrom 2nd level mail domains are different 0.0 SPF_NONE SPF: sender does not publish an SPF Record 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record X-Headers-End: 1lRx8q-0003Uh-3a Subject: [Openvpn-devel] [PATCH 00/14] Various clean up patches X-BeenThere: openvpn-devel@lists.sourceforge.net X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: openvpn-devel-bounces@lists.sourceforge.net X-getmail-retrieved-from-mailbox: Inbox These are a number of patches that do various cleanups that I did as part of implementing DCO but are good on their own. Arne Schwabe (14): Remove code for aligning non-swapped compression Remove superflous ifdefs around enum like defines Rename tunnel_server_udp_single_threaded to tunnel_server_udp Add documentation on EVENT_READ/EVENT_WRITE constants Remove unused variable pass_config_info Remove pointless tun_adjust_frame_parameters function Remove unused field txqueuelen from struct tuntap Remove unused function tls_test_auth_deferred_interval Move is_proto function to the socket.h header Remove thread_mode field of multi_context Remove P2MP mode and check for gettimeofday Extract multi_assign_peer_id into its own function log file descriptor in more socket related error messages Remove do_init_socket_2 and do_init_socket_1 wrapper function doc/doxygen/doc_eventloop.h | 2 +- doc/doxygen/doc_tunnel_state.h | 2 +- src/compat/compat-gettimeofday.c | 2 +- src/openvpn/comp.h | 6 -- src/openvpn/error.c | 8 +- src/openvpn/event.c | 8 +- src/openvpn/forward.c | 26 +----- src/openvpn/forward.h | 6 -- src/openvpn/helper.c | 3 - src/openvpn/init.c | 122 +------------------------- src/openvpn/manage.c | 4 - src/openvpn/mbuf.c | 3 - src/openvpn/mbuf.h | 3 - src/openvpn/mtcp.c | 7 +- src/openvpn/mtu.h | 6 -- src/openvpn/mudp.c | 45 +--------- src/openvpn/mudp.h | 7 +- src/openvpn/multi.c | 95 +++++++++++--------- src/openvpn/multi.h | 20 +++-- src/openvpn/openvpn.h | 25 +++--- src/openvpn/options.c | 55 ++---------- src/openvpn/options.h | 49 ++++++----- src/openvpn/otime.c | 4 - src/openvpn/pool.c | 4 - src/openvpn/pool.h | 3 - src/openvpn/push.c | 3 - src/openvpn/push.h | 3 - src/openvpn/pushlist.h | 4 +- src/openvpn/route.h | 2 - src/openvpn/shaper.c | 5 +- src/openvpn/shaper.h | 4 - src/openvpn/socket.c | 145 ++++++++++--------------------- src/openvpn/socket.h | 90 +++++++++---------- src/openvpn/ssl.h | 11 --- src/openvpn/ssl_common.h | 4 - src/openvpn/syshead.h | 32 ------- src/openvpn/tun.h | 13 --- 37 files changed, 234 insertions(+), 597 deletions(-)