From patchwork Wed May 12 03:15:02 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Arne Schwabe X-Patchwork-Id: 1802 Return-Path: Delivered-To: patchwork@openvpn.net Delivered-To: patchwork@openvpn.net Received: from director11.mail.ord1d.rsapps.net ([172.31.255.6]) by backend30.mail.ord1d.rsapps.net with LMTP id YCDaBCDVm2CldQAAIUCqbw (envelope-from ) for ; Wed, 12 May 2021 09:16:16 -0400 Received: from proxy19.mail.iad3b.rsapps.net ([172.31.255.6]) by director11.mail.ord1d.rsapps.net with LMTP id oPuRBCDVm2ArCgAAvGGmqA (envelope-from ) for ; Wed, 12 May 2021 09:16:16 -0400 Received: from smtp24.gate.iad3b ([172.31.255.6]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) by proxy19.mail.iad3b.rsapps.net with LMTPS id eCMJOB/Vm2D8LgAAIG4riQ (envelope-from ) for ; Wed, 12 May 2021 09:16:15 -0400 X-Spam-Threshold: 95 X-Spam-Score: 0 X-Spam-Flag: NO X-Virus-Scanned: OK X-Orig-To: openvpnslackdevel@openvpn.net X-Originating-Ip: [216.105.38.7] Authentication-Results: smtp24.gate.iad3b.rsapps.net; iprev=pass policy.iprev="216.105.38.7"; spf=pass smtp.mailfrom="openvpn-devel-bounces@lists.sourceforge.net" smtp.helo="lists.sourceforge.net"; dkim=fail (signature verification failed) header.d=sourceforge.net; dkim=fail (signature verification failed) header.d=sf.net; dmarc=none (p=nil; dis=none) header.from=rfc2549.org X-Suspicious-Flag: YES X-Classification-ID: 3a817320-b324-11eb-8970-525400892b35-1-1 Received: from [216.105.38.7] ([216.105.38.7:48464] helo=lists.sourceforge.net) by smtp24.gate.iad3b.rsapps.net (envelope-from ) (ecelerity 4.2.38.62370 r(:)) with ESMTPS (cipher=DHE-RSA-AES256-GCM-SHA384) id 61/63-21095-F15DB906; Wed, 12 May 2021 09:16:15 -0400 Received: from [127.0.0.1] (helo=sfs-ml-2.v29.lw.sourceforge.com) by sfs-ml-2.v29.lw.sourceforge.com with esmtp (Exim 4.92.3) (envelope-from ) id 1lgoi3-0001pK-0t; Wed, 12 May 2021 13:15:31 +0000 Received: from [172.30.20.202] (helo=mx.sourceforge.net) by sfs-ml-2.v29.lw.sourceforge.com with esmtps (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.92.3) (envelope-from ) id 1lgoi0-0001nP-TJ for openvpn-devel@lists.sourceforge.net; Wed, 12 May 2021 13:15:28 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sourceforge.net; s=x; h=Content-Transfer-Encoding:MIME-Version:Message-Id: Date:Subject:To:From:Sender:Reply-To:Cc:Content-Type:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:In-Reply-To:References:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=ejSKmf/x9/wUpJF3cGPUXkGVwB+iIB+p0N4j5YKwqd0=; b=OxoyDJtrY1jmsFpBGrkbOXHCBR b8f6SprDGkdOv/WM8d+gLZdPYpvKzluRO0/yKzmSuGc7tgfdo9dIrFeENOuKtNlsHlT4RVgfTwGtg ylBIvcgit/ewvYkmyqrUj2mDEt2gzRy4CzHyI+YtALQxEyyk83xtI4+XDE8h5CBkg5e4=; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sf.net; s=x ; h=Content-Transfer-Encoding:MIME-Version:Message-Id:Date:Subject:To:From: Sender:Reply-To:Cc:Content-Type:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To: References:List-Id:List-Help:List-Unsubscribe:List-Subscribe:List-Post: List-Owner:List-Archive; bh=ejSKmf/x9/wUpJF3cGPUXkGVwB+iIB+p0N4j5YKwqd0=; b=f O+7HLGWktMwCqTDQcpGkhE6V8QqJzofwHnmBkejKcUP9f4ZS6Z+vboj1EbTsgxH31TEzHOrhonIAT eFmn+yeBCOcJl5ul+4WXmWt0V16RUUjwdplOtYNYke6rL+akZ4nqkAOHvPDgue09FPon5IMgA91Vw i2ORPSFC+m83T9RY=; Received: from mail.blinkt.de ([192.26.174.232]) by sfi-mx-1.v28.lw.sourceforge.com with esmtps (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.92.2) id 1lgohx-005SPt-13 for openvpn-devel@lists.sourceforge.net; Wed, 12 May 2021 13:15:29 +0000 Received: from kamera.blinkt.de ([2001:638:502:390:20c:29ff:fec8:535c]) by mail.blinkt.de with smtp (Exim 4.94.2 (FreeBSD)) (envelope-from ) id 1lgohj-000Byz-1b for openvpn-devel@lists.sourceforge.net; Wed, 12 May 2021 15:15:11 +0200 Received: (nullmailer pid 1309962 invoked by uid 10006); Wed, 12 May 2021 13:15:11 -0000 From: Arne Schwabe To: openvpn-devel@lists.sourceforge.net Date: Wed, 12 May 2021 15:15:02 +0200 Message-Id: <20210512131511.1309914-1-arne@rfc2549.org> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 X-Spam-Report: Spam Filtering performed by mx.sourceforge.net. See http://spamassassin.org/tag/ for more details. 0.0 URIBL_BLOCKED ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [URIs: makefile.am] 0.2 HEADER_FROM_DIFFERENT_DOMAINS From and EnvelopeFrom 2nd level mail domains are different 0.0 SPF_NONE SPF: sender does not publish an SPF Record 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record X-Headers-End: 1lgohx-005SPt-13 Subject: [Openvpn-devel] [PATCH 0/9] Miscellaneous cleanup patches/small fixes X-BeenThere: openvpn-devel@lists.sourceforge.net X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: openvpn-devel-bounces@lists.sourceforge.net X-getmail-retrieved-from-mailbox: Inbox This patch set has a number of small fixes/improvements and documentation fixes/updates. They should be able to be applied in any order and have weak relationship to each other at best. I am sending them in one patch set to make review/keeping track of patches easier. Arne Schwabe (9): Remove explicit struct iovec check (HAVE_IOVEC) Remove getpeername, getpid check Inline do_init_auth_token_key Add missing free_key_ctx for auth_token Add ifdef guards to unit test Add noreturn attribute for MSVC to assert_failed method. Move utility function from win32.c to win32-util.c Document stub-v2 being basically an alias for no compression at all Add detailed man page section to setup a OpenVPN setup with peer-fingerprint Changes.rst | 4 + configure.ac | 5 +- doc/Makefile.am | 1 + doc/man-sections/example-fingerprint.rst | 194 +++++++++++++++++++++ doc/man-sections/protocol-options.rst | 5 + src/openvpn/Makefile.am | 1 + src/openvpn/error.h | 12 +- src/openvpn/init.c | 24 +-- src/openvpn/openvpn.vcxproj | 2 + src/openvpn/openvpn.vcxproj.filters | 3 + src/openvpn/platform.c | 4 - src/openvpn/socket.c | 7 - src/openvpn/syshead.h | 6 +- src/openvpn/win32-util.c | 137 +++++++++++++++ src/openvpn/win32-util.h | 41 +++++ src/openvpn/win32.c | 96 +--------- src/openvpn/win32.h | 6 - tests/unit_tests/openvpn/test_argv.c | 2 + tests/unit_tests/openvpn/test_auth_token.c | 2 + tests/unit_tests/openvpn/test_crypto.c | 4 + tests/unit_tests/openvpn/test_misc.c | 2 + tests/unit_tests/openvpn/test_ncp.c | 2 + tests/unit_tests/openvpn/test_tls_crypt.c | 2 + 23 files changed, 426 insertions(+), 136 deletions(-) create mode 100644 doc/man-sections/example-fingerprint.rst create mode 100644 src/openvpn/win32-util.c create mode 100644 src/openvpn/win32-util.h