[Openvpn-devel,0/2] AUTH_PENDING docs and related

Message ID 20210602034253.19984-1-selva.nair@gmail.com
Headers show
Series
  • AUTH_PENDING docs and related
Related show

Message

Selva Nair June 2, 2021, 3:42 a.m.
From: Selva Nair <selva.nair@gmail.com>

I couldn't figure out the details of how to use CR_TEXT or OPEN_URL
from the docs. This is an attempt to improve the documentation based
on my reading of the sources and some guess-work.

I might have edited somethings wrongly. If so, please correct.

Also found a minor parsing bug that will trigger only if the
client announces more than two keywords in IV_SSO.

Question: is the IV_SSO the keyword for PROXY_URL named proxy_url
or proxyurl or url_proxy? I would ahve guessed "proxyurl" based on
crtext and openurl but have settled for proxy_url. If there is
no established convention as yet, I suggest proxyurl without
the _.
 
Selva Nair (2):
  Improve documentation of AUTH_PENDING related directives
  Fix parsing of IV_SSO string

 doc/man-sections/server-options.rst |   4 ++
 doc/management-notes.txt            | 101 +++++++++++++++++-----------
 src/openvpn/ssl_verify.c            |   2 +-
 3 files changed, 68 insertions(+), 39 deletions(-)

Comments

Arne Schwabe June 2, 2021, 11:59 a.m. | #1
Am 02.06.21 um 05:42 schrieb selva.nair@gmail.com:
> From: Selva Nair <selva.nair@gmail.com>
> 
> I couldn't figure out the details of how to use CR_TEXT or OPEN_URL
> from the docs. This is an attempt to improve the documentation based
> on my reading of the sources and some guess-work.
> 
> I might have edited somethings wrongly. If so, please correct.
> 
> Also found a minor parsing bug that will trigger only if the
> client announces more than two keywords in IV_SSO.
> 
> Question: is the IV_SSO the keyword for PROXY_URL named proxy_url
> or proxyurl or url_proxy? I would ahve guessed "proxyurl" based on
> crtext and openurl but have settled for proxy_url. If there is
> no established convention as yet, I suggest proxyurl without
> the _.

So far proxyurl openurl_proxy or whatever we call it has not yet
implemented anywhere yet. So we can still change the name.

Arne
Selva Nair June 2, 2021, 1:37 p.m. | #2
Hi,

On Wed, Jun 2, 2021 at 7:59 AM Arne Schwabe <arne@rfc2549.org> wrote:
>
> Am 02.06.21 um 05:42 schrieb selva.nair@gmail.com:
> > From: Selva Nair <selva.nair@gmail.com>
> >
> > I couldn't figure out the details of how to use CR_TEXT or OPEN_URL
> > from the docs. This is an attempt to improve the documentation based
> > on my reading of the sources and some guess-work.
> >
> > I might have edited some things wrongly. If so, please correct.
> >
> > Also found a minor parsing bug that will trigger only if the
> > client announces more than two keywords in IV_SSO.
> >
> > Question: is the IV_SSO the keyword for PROXY_URL named proxy_url
> > or proxyurl or url_proxy? I would have guessed "proxyurl" based on
> > crtext and openurl but have settled for proxy_url. If there is
> > no established convention as yet, I suggest proxyurl without
> > the _.
>
> So far proxyurl openurl_proxy or whatever we call it has not yet
> implemented anywhere yet. So we can still change the name.

In the patch I wrote it as proxy_url. Shall we change it to
"proxyurl" to match with "crtext" and "openurl" which have no underscore?


Selva