[Openvpn-devel,0/6] sitnl follow-up

Message ID 20190805092529.9467-1-a@unstable.cc
Headers show
Series
  • sitnl follow-up
Related show

Message

Antonio Quartulli Aug. 5, 2019, 9:25 a.m.
From: Antonio Quartulli <antonio@openvpn.net>

Hi all, 

this small patchset aims at tackling most of the concerns raised by Gert
while merging the sitnl introduction patchset.

All patches are fairly small, but they are a bit intertwined (they
change nearby lines), therefore it would be better to merge them in the
provided order to avoid ugly merge conflicts.


Cheers,


Antonio Quartulli (6):
  sitnl: harden strncpy() by forcing arguments to have the same length
  networking/best_gw: remove useless prefixlen parameter
  networking: extend API for better memory management
  tun.c: undo_ifconfig_ipv4/6 remove useless gc argument
  networking_sitnl.c: uncrustify file
  route.c: simplify ifdef logic

 src/openvpn/networking.h          | 33 +++++++++--
 src/openvpn/networking_iproute2.c | 78 ++++++++++---------------
 src/openvpn/networking_iproute2.h |  1 +
 src/openvpn/networking_sitnl.c    | 96 +++++++++++++++++++++----------
 src/openvpn/openvpn.c             |  1 +
 src/openvpn/route.c               | 32 ++++++-----
 src/openvpn/route.h               |  6 +-
 src/openvpn/tun.c                 | 28 ++++-----
 8 files changed, 165 insertions(+), 110 deletions(-)

Comments

Antonio Quartulli Aug. 5, 2019, 11:11 a.m. | #1
FYI,

this patchset has undergone buildbot, travis-ci and gitlab-ci testing
and nothing out of the ordinary came out.

Regards,

On 05/08/2019 11:25, Antonio Quartulli wrote:
> From: Antonio Quartulli <antonio@openvpn.net>
> 
> Hi all, 
> 
> this small patchset aims at tackling most of the concerns raised by Gert
> while merging the sitnl introduction patchset.
> 
> All patches are fairly small, but they are a bit intertwined (they
> change nearby lines), therefore it would be better to merge them in the
> provided order to avoid ugly merge conflicts.
> 
> 
> Cheers,
> 
> 
> Antonio Quartulli (6):
>   sitnl: harden strncpy() by forcing arguments to have the same length
>   networking/best_gw: remove useless prefixlen parameter
>   networking: extend API for better memory management
>   tun.c: undo_ifconfig_ipv4/6 remove useless gc argument
>   networking_sitnl.c: uncrustify file
>   route.c: simplify ifdef logic
> 
>  src/openvpn/networking.h          | 33 +++++++++--
>  src/openvpn/networking_iproute2.c | 78 ++++++++++---------------
>  src/openvpn/networking_iproute2.h |  1 +
>  src/openvpn/networking_sitnl.c    | 96 +++++++++++++++++++++----------
>  src/openvpn/openvpn.c             |  1 +
>  src/openvpn/route.c               | 32 ++++++-----
>  src/openvpn/route.h               |  6 +-
>  src/openvpn/tun.c                 | 28 ++++-----
>  8 files changed, 165 insertions(+), 110 deletions(-)
>