From patchwork Fri Oct 4 07:12:42 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: David Sommerseth X-Patchwork-Id: 842 Return-Path: Delivered-To: patchwork@openvpn.net Delivered-To: patchwork@openvpn.net Received: from director8.mail.ord1d.rsapps.net ([172.30.191.6]) by backend30.mail.ord1d.rsapps.net with LMTP id aNj9Jex9l10YagAAIUCqbw for ; Fri, 04 Oct 2019 13:14:20 -0400 Received: from proxy6.mail.ord1d.rsapps.net ([172.30.191.6]) by director8.mail.ord1d.rsapps.net with LMTP id gFPUJex9l10gLAAAfY0hYg ; Fri, 04 Oct 2019 13:14:20 -0400 Received: from smtp5.gate.ord1d ([172.30.191.6]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) by proxy6.mail.ord1d.rsapps.net with LMTP id 6ASEJex9l12kVQAAQyIf0w ; Fri, 04 Oct 2019 13:14:20 -0400 X-Spam-Threshold: 95 X-Spam-Score: 0 X-Spam-Flag: NO X-Virus-Scanned: OK X-Orig-To: openvpnslackdevel@openvpn.net X-Originating-Ip: [216.105.38.7] Authentication-Results: smtp5.gate.ord1d.rsapps.net; iprev=pass policy.iprev="216.105.38.7"; spf=pass smtp.mailfrom="openvpn-devel-bounces@lists.sourceforge.net" smtp.helo="lists.sourceforge.net"; dkim=fail (signature verification failed) header.d=sourceforge.net; dkim=fail (signature verification failed) header.d=sf.net; dmarc=fail (p=none; dis=none) header.from=openvpn.net X-Suspicious-Flag: YES X-Classification-ID: 66c239d8-e6ca-11e9-b45f-525400d73c44-1-1 Received: from [216.105.38.7] ([216.105.38.7:41678] helo=lists.sourceforge.net) by smtp5.gate.ord1d.rsapps.net (envelope-from ) (ecelerity 4.2.38.62370 r(:)) with ESMTPS (cipher=DHE-RSA-AES256-GCM-SHA384) id 96/FB-10562-BED779D5; Fri, 04 Oct 2019 13:14:19 -0400 Received: from [127.0.0.1] (helo=sfs-ml-2.v29.lw.sourceforge.com) by sfs-ml-2.v29.lw.sourceforge.com with esmtp (Exim 4.90_1) (envelope-from ) id 1iGR8r-0005cP-VP; Fri, 04 Oct 2019 17:13:21 +0000 Received: from [172.30.20.202] (helo=mx.sourceforge.net) by sfs-ml-2.v29.lw.sourceforge.com with esmtps (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.90_1) (envelope-from ) id 1iGR8p-0005c4-U8 for openvpn-devel@lists.sourceforge.net; Fri, 04 Oct 2019 17:13:19 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sourceforge.net; s=x; h=Message-Id:Date:Subject:To:From:Sender:Reply-To:Cc: MIME-Version:Content-Type:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:In-Reply-To:References:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=PrJ+9IgdqGQZvs+Xh6LHtJNKzT2e59835H9E2dh7auI=; b=k5S26U3gRgJiUnZc0wqexIIpBe nEq2QGfJna2mgc5t3V2RjH1p8RKN9eSpjS2+FUcmxPXgkw8iPzN9ZV7YhrFS+kPRhTIIudWMyWgUl Tyye0kHmUmHMS9rgybqSvp7RcsVz7qBhYy7L79CcdeqlIKZnyXJBFiPD8p9iif/7DsG8=; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sf.net; s=x ; h=Message-Id:Date:Subject:To:From:Sender:Reply-To:Cc:MIME-Version: Content-Type:Content-Transfer-Encoding:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: In-Reply-To:References:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=PrJ+9IgdqGQZvs+Xh6LHtJNKzT2e59835H9E2dh7auI=; b=eIssZpFZwt8/hTHZvq5KdtGOHs Pucvm/LDozPAx9gjM2caC7gl1N7YL643PTmHgJtCC0GMkReqOs0tCL8tkSkpJSvsqrfxfk0b3aDQU d5oKLzDRMu4Z3aCVZYVKu344/8KVBpNVJOXeeU08ERBALCIo22KIgpZDhv62y1m8LvlU=; Received: from mx0.basenordic.cloud ([185.212.44.139]) by sfi-mx-4.v28.lw.sourceforge.com with esmtps (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.92.2) id 1iGR8l-00Gy5Z-PW for openvpn-devel@lists.sourceforge.net; Fri, 04 Oct 2019 17:13:18 +0000 Received: from localhost (unknown [IPv6:::1]) by mx0.basenordic.cloud (Postfix) with ESMTP id DF90283C6E3 for ; Fri, 4 Oct 2019 17:12:59 +0000 (UTC) Received: from mx0.basenordic.cloud ([127.0.0.1]) by localhost (winterfell.topphemmelig.net [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id m0i35TcvoTbX for ; Fri, 4 Oct 2019 19:12:51 +0200 (CEST) Received: from zimbra.sommerseth.email (zimbra.sommerseth.email [172.16.33.42]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx0.basenordic.cloud (Postfix) with ESMTPS id 3FD0981E8EB for ; Fri, 4 Oct 2019 19:12:51 +0200 (CEST) Received: from localhost (localhost [127.0.0.1]) by zimbra.sommerseth.email (Postfix) with ESMTP id 6D02D4ECDDF1 for ; Fri, 4 Oct 2019 19:12:50 +0200 (CEST) Received: from zimbra.sommerseth.email ([127.0.0.1]) by localhost (zimbra.sommerseth.email [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id rZasnL2sOqr7 for ; Fri, 4 Oct 2019 19:12:50 +0200 (CEST) Received: from optimus.homebase.sommerseths.net (unknown [10.35.7.2]) by zimbra.sommerseth.email (Postfix) with ESMTPS id C2D144E9D0E5 for ; Fri, 4 Oct 2019 19:12:49 +0200 (CEST) From: David Sommerseth To: openvpn-devel@lists.sourceforge.net Date: Fri, 4 Oct 2019 19:12:42 +0200 Message-Id: <20191004171246.26343-1-davids@openvpn.net> X-Mailer: git-send-email 2.17.1 X-Spam-Report: Spam Filtering performed by mx.sourceforge.net. See http://spamassassin.org/tag/ for more details. -0.0 SPF_HELO_PASS SPF: HELO matches SPF record 0.2 HEADER_FROM_DIFFERENT_DOMAINS From and EnvelopeFrom 2nd level mail domains are different -0.0 SPF_PASS SPF: sender matches SPF record X-Headers-End: 1iGR8l-00Gy5Z-PW Subject: [Openvpn-devel] [PATCH 0/4] struct argv overhual - Oct 2019 edition X-BeenThere: openvpn-devel@lists.sourceforge.net X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: openvpn-devel-bounces@lists.sourceforge.net X-getmail-retrieved-from-mailbox: Inbox Hi, I've rebased the last attempt of the struct argv overual patches [1] to the lastest public git master [2]. This rebase just needed a few minor changes to account for changes with tls-crypt-v2 and sitnl patches now being included. I've also applied Arne's review comments [3]. To simplify the review, I've also pushed these changes to my gitlab account: https://gitlab.com/dazo/openvpn.git Look at the dev/struct-argv-overhaul-2019.10 branch for the proper commits. [1] [2] git master commit ef2c7b2fa4fd9fae934e608e37dc8d98edbace5f [3] Message-ID: --- kind regards, David Sommerseth OpenVPN Inc ---------------------------------------------------------------- David Sommerseth (1): Documented all the argv related code with minor refactoring Heiko Hund (3): re-implement argv_printf_*() argv: do fewer memory re-allocations Add gc_arena to struct argv to save allocations src/openvpn/argv.c | 525 +++++++++++++++++---------- src/openvpn/argv.h | 7 +- src/openvpn/console_systemd.c | 2 +- src/openvpn/init.c | 15 +- src/openvpn/lladdr.c | 2 +- src/openvpn/multi.c | 10 +- src/openvpn/networking_iproute2.c | 23 +- src/openvpn/options.c | 2 +- src/openvpn/plugin.c | 2 +- src/openvpn/route.c | 16 +- src/openvpn/socket.c | 4 +- src/openvpn/ssl_verify.c | 6 +- src/openvpn/tls_crypt.c | 2 +- src/openvpn/tun.c | 62 ++-- tests/unit_tests/openvpn/test_argv.c | 118 +++++- 15 files changed, 509 insertions(+), 287 deletions(-)