From patchwork Mon Mar 30 01:44:28 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Paolo Cerrito X-Patchwork-Id: 1058 Return-Path: Delivered-To: patchwork@openvpn.net Delivered-To: patchwork@openvpn.net Received: from director8.mail.ord1d.rsapps.net ([172.31.255.6]) by backend30.mail.ord1d.rsapps.net with LMTP id 4DutCVjqgV6qSgAAIUCqbw for ; Mon, 30 Mar 2020 08:47:20 -0400 Received: from proxy19.mail.iad3b.rsapps.net ([172.31.255.6]) by director8.mail.ord1d.rsapps.net with LMTP id 4AgGB1jqgV6/PwAAfY0hYg ; Mon, 30 Mar 2020 08:47:20 -0400 Received: from smtp35.gate.iad3b ([172.31.255.6]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) by proxy19.mail.iad3b.rsapps.net with LMTP id UNdKAVjqgV7QOgAAIG4riQ ; Mon, 30 Mar 2020 08:47:20 -0400 X-Spam-Threshold: 95 X-Spam-Score: 0 X-Spam-Flag: NO X-Virus-Scanned: OK X-Orig-To: openvpnslackdevel@openvpn.net X-Originating-Ip: [216.105.38.7] Authentication-Results: smtp35.gate.iad3b.rsapps.net; iprev=pass policy.iprev="216.105.38.7"; spf=pass smtp.mailfrom="openvpn-devel-bounces@lists.sourceforge.net" smtp.helo="lists.sourceforge.net"; dkim=fail (signature verification failed) header.d=sourceforge.net; dkim=fail (signature verification failed) header.d=sf.net; dkim=fail (signature verification failed) header.d=gmail.com; dmarc=fail (p=none; dis=none) header.from=gmail.com X-Suspicious-Flag: YES X-Classification-ID: 97552fc4-7284-11ea-b69d-525400503131-1-1 Received: from [216.105.38.7] ([216.105.38.7:44576] helo=lists.sourceforge.net) by smtp35.gate.iad3b.rsapps.net (envelope-from ) (ecelerity 4.2.38.62370 r(:)) with ESMTPS (cipher=DHE-RSA-AES256-GCM-SHA384) id CC/01-22416-75AE18E5; Mon, 30 Mar 2020 08:47:19 -0400 Received: from [127.0.0.1] (helo=sfs-ml-1.v29.lw.sourceforge.com) by sfs-ml-1.v29.lw.sourceforge.com with esmtp (Exim 4.90_1) (envelope-from ) id 1jIto7-0002Fe-6Y; Mon, 30 Mar 2020 12:46:23 +0000 Received: from [172.30.20.202] (helo=mx.sourceforge.net) by sfs-ml-1.v29.lw.sourceforge.com with esmtps (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jIto6-0002FP-Bv for openvpn-devel@lists.sourceforge.net; Mon, 30 Mar 2020 12:46:22 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sourceforge.net; s=x; h=Content-Transfer-Encoding:MIME-Version:Message-Id: Date:Subject:Cc:To:From:Sender:Reply-To:Content-Type:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:In-Reply-To:References:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=fXZ8OkWJzGmpFGqufR/lN7BnkJOlgg7jrwwPHbUlPT8=; b=EuRnK1TwTLtTgmKylBdfkG1Mcu nI6rs93FeLPtx0aapZypLwAIDyKen8j96sih3wlWMziqhZRd9GEvxPjIwJyvAlBleFdNgxHWkqoeS 4StDAfcWw7kQi6NogtmC+d3o9UFNJZ04h8XNfEyB23mlRdEFhA9KTJRNAbIhKoJdaH5U=; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sf.net; s=x ; h=Content-Transfer-Encoding:MIME-Version:Message-Id:Date:Subject:Cc:To:From :Sender:Reply-To:Content-Type:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To: References:List-Id:List-Help:List-Unsubscribe:List-Subscribe:List-Post: List-Owner:List-Archive; bh=fXZ8OkWJzGmpFGqufR/lN7BnkJOlgg7jrwwPHbUlPT8=; b=L ayKcJ4Bt/N0uK+eayS3Ig6Jk79Nb3HOjFDyT9ee0vhMiY+XQc7T1ZoK2Ug9HfUGmEDtl60IvGzE5J t/CONLftfk/wfA64Rj8U9+ShVfXgxGtVsr4tkathdONWNiC528wEZPGtGDZ0VOxpW5g68KqFFeVgk dqFpLnCdl9MnXBFo=; Received: from mail-wm1-f45.google.com ([209.85.128.45]) by sfi-mx-4.v28.lw.sourceforge.com with esmtps (TLSv1.2:ECDHE-RSA-AES128-GCM-SHA256:128) (Exim 4.92.2) id 1jIto2-001R9N-3N for openvpn-devel@lists.sourceforge.net; Mon, 30 Mar 2020 12:46:22 +0000 Received: by mail-wm1-f45.google.com with SMTP id t128so1375566wma.0 for ; Mon, 30 Mar 2020 05:46:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=fXZ8OkWJzGmpFGqufR/lN7BnkJOlgg7jrwwPHbUlPT8=; b=c+hbpXFbiJMXU0ca0U2UetPhFysy1MRQmXVCq9onFuPDooxwKe/8sbzeFlZk+7EUq/ SKMD3ZovaVyVX/t9+R8xE9KZJnHBmkbNN1pVIWctrQ0aLlXIH3JH7C4WbPKkGtWuya6j l4w9gIu9Z2AKQV2TsGej9nY8kEwO6raF1+zH7u9timPfx/xNMXfuA6O9w10weXeDeC+t 3l+QmE/RhsfaNjKoP/HlQKlVju5m5cUgAQEFijCZopHWHqRv1HPoXwSaDGjJyN//azvH HvQ6hhVpMdtQOHh7rNT+Rt/qrWM28IVWzxWYiQpZhYw8W+eQWbTR0jHMlQDokn6MtCQg hk8A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=fXZ8OkWJzGmpFGqufR/lN7BnkJOlgg7jrwwPHbUlPT8=; b=Zrhi0Uo5Ysj2iIOTIp/N5xpjNG4JyrpsWzfgRZBTFtY/zLMdU1yBcOmKT7IXfD1/TL MpxCvxHh+lxCYqBLhRpa9Vk/AsofYWPjsM8p+7jPfZBAjvcj2wr6MAD9lmGciEa/cHY0 O60fi5UmG2X3sop0c4NAIK2tEuzwT+ruSPlO83mvz18/LU3+VHHX3BEsoJUFkWHb1jI3 vTspo/37Pgt6Nfdn6dsScapmPbB2lDH3BmkLCjOfz3Sjs3YsN2uzDdjuViBo9BZiF8va E+IGQ1xPKmNOQIVHtQl0QemRpU31V/9aNC/4VQYI9KNFS2whIDTRJs8H3U2/Rozl8MOL 3jlw== X-Gm-Message-State: ANhLgQ3+xLYz2/OR+g2NaFn0PFSPRGnADoZIr+VLRISRcGzzVUqbgRUe y2usoK1BGYmFMtdTT6dJsmUOyyPOyWo= X-Google-Smtp-Source: ADFU+vt/tczrwGEY3GidiB5zhsgvYwoc9mFLC3xze/eVACAw9ZgHPZHlUInGmfWHDbE7QHmGiiLlIw== X-Received: by 2002:a7b:cd10:: with SMTP id f16mr12245939wmj.132.1585572368169; Mon, 30 Mar 2020 05:46:08 -0700 (PDT) Received: from wardragon.ccd.uniroma2.it (wardragon-m.ccd.uniroma2.it. [160.80.8.176]) by smtp.gmail.com with ESMTPSA id t81sm21108695wmb.15.2020.03.30.05.46.06 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 30 Mar 2020 05:46:07 -0700 (PDT) From: Paolo Cerrito To: openvpn-devel@lists.sourceforge.net Date: Mon, 30 Mar 2020 14:44:28 +0200 Message-Id: <20200330124427.764219-1-wardragon78@gmail.com> X-Mailer: git-send-email 2.26.0 MIME-Version: 1.0 X-Spam-Report: Spam Filtering performed by mx.sourceforge.net. See http://spamassassin.org/tag/ for more details. 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider (wardragon78[at]gmail.com) -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [209.85.128.45 listed in list.dnswl.org] -0.0 SPF_PASS SPF: sender matches SPF record 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record 0.2 FREEMAIL_ENVFROM_END_DIGIT Envelope-from freemail username ends in digit (wardragon78[at]gmail.com) -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid 0.0 URIBL_BLOCKED ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [URIs: uniroma2.it] 1.1 AWL AWL: Adjusted score from AWL reputation of From: address X-Headers-End: 1jIto2-001R9N-3N Subject: [Openvpn-devel] [Openvpn-Devel] [PATCH v4] Insert client connection data into PAM environment X-BeenThere: openvpn-devel@lists.sourceforge.net X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Paolo Cerrito Errors-To: openvpn-devel-bounces@lists.sourceforge.net X-getmail-retrieved-from-mailbox: Inbox From: Paolo Cerrito 1) changed again remote lenght, we have to consider only the lenght op ipv6 address into form nnnn:nnnn:nnnn:nnnn:nnnn:ddd.ddd.ddd.ddd not the mask, so we have max lenght of 45 plus terminator. 2) refactored calls to get_env, now we make one call to take ipv6 address, the if it's NULL, we try to get ipv4 address. --- src/plugins/auth-pam/auth-pam.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/plugins/auth-pam/auth-pam.c b/src/plugins/auth-pam/auth-pam.c index b55a2ecd..ae0d495a 100644 --- a/src/plugins/auth-pam/auth-pam.c +++ b/src/plugins/auth-pam/auth-pam.c @@ -115,7 +115,7 @@ struct user_pass { char password[128]; char common_name[128]; char response[128]; - char remote[51]; //51 as ipv6 form n:n:n:n:n:n:d.d.d.d/mask and terminator+1 + char remote[46]; //46 as ipv6 form n:n:n:n:n:n:d.d.d.d and + terminator \0 const struct name_value_list *name_value_list; };