[Openvpn-devel] t_net.sh: assign MAC address directly during interface creation

Message ID 20200428131700.9123-1-a@unstable.cc
State Accepted
Headers show
Series
  • [Openvpn-devel] t_net.sh: assign MAC address directly during interface creation
Related show

Commit Message

Antonio Quartulli April 28, 2020, 1:17 p.m.
Signed-off-by: Antonio Quartulli <a@unstable.cc>
---

- tested with buildbot

 tests/t_net.sh | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

Comments

Gert Doering May 7, 2020, 11:33 a.m. | #1
Acked-by: Gert Doering <gert@greenie.muc.de>

"If you say this helps" :-)  (it's test code, and it seems to stop the
spurious t_net failure triggers on some linux variants)

Your patch has been applied to the master branch.

commit 3cb9b156c8094ab333fc4f3da57818471135ac5e
Author: Antonio Quartulli
Date:   Tue Apr 28 15:17:00 2020 +0200

     t_net.sh: assign MAC address directly during interface creation

     Signed-off-by: Antonio Quartulli <a@unstable.cc>
     Acked-by: Gert Doering <gert@greenie.muc.de>
     Message-Id: <20200428131700.9123-1-a@unstable.cc>
     URL: https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg19832.html
     Signed-off-by: Gert Doering <gert@greenie.muc.de>


--
kind regards,

Gert Doering

Patch

diff --git a/tests/t_net.sh b/tests/t_net.sh
index 8f1bc361..c67c3df2 100755
--- a/tests/t_net.sh
+++ b/tests/t_net.sh
@@ -33,15 +33,13 @@  LAST_STATE=$((${#GET_STATE[@]} - 1))
 reload_dummy()
 {
     $RUN_SUDO ip link del $IFACE
-    $RUN_SUDO ip link add $IFACE type dummy
+    $RUN_SUDO ip link add $IFACE address 00:11:22:33:44:55 type dummy
     $RUN_SUDO ip link set dev $IFACE state up
 
     if [ $? -ne 0 ]; then
         echo "can't create interface $IFACE"
         exit 1
     fi
-
-    $RUN_SUDO ip link set dev $IFACE address 00:11:22:33:44:55
 }
 
 run_test()