[Openvpn-devel,6/7] Remove MD5SUM

Message ID 20171202134541.7688-6-a@unstable.cc
State Accepted
Headers show
Series
  • [Openvpn-devel,1/7] Remove option to disable crypto engine
Related show

Commit Message

Antonio Quartulli Dec. 2, 2017, 1:45 p.m.
Apparently the MS5SUM macro is not used anywhere.
Remove it.

Signed-off-by: Antonio Quartulli <a@unstable.cc>
---
 src/openvpn/openvpn.h | 1 -
 1 file changed, 1 deletion(-)

Comments

Steffan Karger Dec. 3, 2017, 2:18 p.m. | #1
On 02-12-17 14:45, Antonio Quartulli wrote:
> Apparently the MS5SUM macro is not used anywhere.
> Remove it.
> 
> Signed-off-by: Antonio Quartulli <a@unstable.cc>
> ---
>  src/openvpn/openvpn.h | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/src/openvpn/openvpn.h b/src/openvpn/openvpn.h
> index d843c913..fe8324ab 100644
> --- a/src/openvpn/openvpn.h
> +++ b/src/openvpn/openvpn.h
> @@ -563,7 +563,6 @@ struct context
>                                            |(c->c2.tls_multi ? PD_TLS : 0)   \
>                                            |(c->options.tls_auth_file ? c->c1.ks.key_type.hmac_length : 0), \
>                                            gc)
> -#define MD5SUM(buf, len, gc) md5sum((buf), (len), 0, (gc))
>  
>  /* this represents "disabled peer-id" */
>  #define MAX_PEER_ID 0xFFFFFF
> 

Acked-by: Steffan Karger <steffan@karger.me>

-Steffan

------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot
Gert Doering Dec. 4, 2017, 6:48 p.m. | #2
Your patch has been applied to the master branch.

commit 5a0e82cb73ce072ef6cedc629d698cf873923bf6
Author: Antonio Quartulli
Date:   Sat Dec 2 21:45:40 2017 +0800

     Remove MD5SUM

     Signed-off-by: Antonio Quartulli <a@unstable.cc>
     Acked-by: Steffan Karger <steffan.karger@fox-it.com>
     Message-Id: <20171202134541.7688-6-a@unstable.cc>
     URL: https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg15954.html
     Signed-off-by: Gert Doering <gert@greenie.muc.de>


--
kind regards,

Gert Doering


------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot

Patch

diff --git a/src/openvpn/openvpn.h b/src/openvpn/openvpn.h
index d843c913..fe8324ab 100644
--- a/src/openvpn/openvpn.h
+++ b/src/openvpn/openvpn.h
@@ -563,7 +563,6 @@  struct context
                                           |(c->c2.tls_multi ? PD_TLS : 0)   \
                                           |(c->options.tls_auth_file ? c->c1.ks.key_type.hmac_length : 0), \
                                           gc)
-#define MD5SUM(buf, len, gc) md5sum((buf), (len), 0, (gc))
 
 /* this represents "disabled peer-id" */
 #define MAX_PEER_ID 0xFFFFFF