[Openvpn-devel] Depreciation warning for --topology net30 on servers with IPv4 pools.

Message ID 20200620180532.15738-1-gert@greenie.muc.de
State Accepted
Headers show
Series
  • [Openvpn-devel] Depreciation warning for --topology net30 on servers with IPv4 pools.
Related show

Commit Message

Gert Doering June 20, 2020, 6:05 p.m.
IPv4 pool handling needs lots of extra code to deal with "topology net30",
so we want to remove that combination in a future release.

Warn people about this in 2.5 so nobody is hit by this as a surprise.

Client- and ifconfig-support for net30 will stay, as "just net30" is not
what brings maintenance effort here (totally removing all options except
"topology subnet" would be beneficial but is a bit too radical today)

Trac: #1288

Signed-off-by: Gert Doering <gert@greenie.muc.de>
---
 src/openvpn/helper.c | 8 ++++++++
 1 file changed, 8 insertions(+)

Comments

Arne Schwabe June 20, 2020, 6:36 p.m. | #1
Am 20.06.20 um 20:05 schrieb Gert Doering:
> IPv4 pool handling needs lots of extra code to deal with "topology net30",
> so we want to remove that combination in a future release.
> 
> Warn people about this in 2.5 so nobody is hit by this as a surprise.
> 
> Client- and ifconfig-support for net30 will stay, as "just net30" is not
> what brings maintenance effort here (totally removing all options except
> "topology subnet" would be beneficial but is a bit too radical today)

Acked-By: Arne Schwabe <arne@rfc2549.org>
Gert Doering June 20, 2020, 8:59 p.m. | #2
Patch has been applied to the master branch.

commit 02a0332084f0dc08e39067cc6fd68abb77a03c47
Author: Gert Doering
Date:   Sat Jun 20 20:05:32 2020 +0200

     Depreciation warning for --topology net30 on servers with IPv4 pools.

     Signed-off-by: Gert Doering <gert@greenie.muc.de>
     Acked-by: Arne Schwabe <arne@rfc2549.org>
     Message-Id: <20200620180532.15738-1-gert@greenie.muc.de>
     URL: https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg20041.html
     Signed-off-by: Gert Doering <gert@greenie.muc.de>


--
kind regards,

Gert Doering

Patch

diff --git a/src/openvpn/helper.c b/src/openvpn/helper.c
index fbfc287f..2cc579e7 100644
--- a/src/openvpn/helper.c
+++ b/src/openvpn/helper.c
@@ -359,6 +359,14 @@  helper_client_server(struct options *o)
             }
 
             push_option(o, print_opt_topology(topology, &o->gc), M_USAGE);
+
+            if (topology == TOP_NET30 && !(o->server_flags & SF_NOPOOL))
+            {
+                msg(M_WARN, "WARNING: --topology net30 support for server "
+                    "configs with IPv4 pools will be removed in a future "
+                    "release. Please migrate to --topology subnet as soon "
+                    "as possible.");
+            }
         }
         else if (dev == DEV_TYPE_TAP)
         {