[Openvpn-devel,1/2] Unified success messages for setting mtu

Message ID 20200629190930.1360-1-cschenk@mail.uni-paderborn.de
State Changes Requested
Headers show
Series
  • [Openvpn-devel,1/2] Unified success messages for setting mtu
Related show

Commit Message

Christopher Schenk June 29, 2020, 7:09 p.m.
---
 src/openvpn/tun.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

Comments

Gert Doering June 29, 2020, 8:58 p.m. | #1
Hi,

On Mon, Jun 29, 2020 at 09:09:29PM +0200, Christopher Schenk wrote:
> diff --git a/src/openvpn/tun.c b/src/openvpn/tun.c
> index 18cdf38d..3ef79b2f 100644
> --- a/src/openvpn/tun.c
> +++ b/src/openvpn/tun.c
> @@ -251,7 +251,7 @@ do_set_mtu_service(const struct tuntap *tt, const short family, const int mtu)
>      }
>      else
>      {
> -        msg(M_INFO, "%s MTU set to %d on interface %d using service", family_name, mtu, mtu_msg.iface.index);
> +        msg(M_INFO, "%s MTU set to %d on interface %d using SetIpInterfaceEntry()", family_name, mtu, mtu_msg.iface.index);
>          ret = true;
>      }

While I do like unified messages, this is not exactly what I had in mind
- the "using service" bit should stay, if using the service :-) - too
much unification.

gert

Patch

diff --git a/src/openvpn/tun.c b/src/openvpn/tun.c
index 18cdf38d..3ef79b2f 100644
--- a/src/openvpn/tun.c
+++ b/src/openvpn/tun.c
@@ -251,7 +251,7 @@  do_set_mtu_service(const struct tuntap *tt, const short family, const int mtu)
     }
     else
     {
-        msg(M_INFO, "%s MTU set to %d on interface %d using service", family_name, mtu, mtu_msg.iface.index);
+        msg(M_INFO, "%s MTU set to %d on interface %d using SetIpInterfaceEntry()", family_name, mtu, mtu_msg.iface.index);
         ret = true;
     }
 
@@ -5516,7 +5516,7 @@  windows_set_mtu(const int iface_index, const short family,
     }
     else
     {
-        msg(M_INFO, "Successfully set %s mtu on interface %d", family_name, iface_index);
+        msg(M_INFO, "%s MTU set to %d on interface %d using SetIpInterfaceEntry()", family_name, mtu, iface_index);
     }
 }