[Openvpn-devel] New man page corrections - windows-options.rst

Message ID 20200701011018.31364-1-tincanteksup@gmail.com
State Accepted, archived
Delegated to: David Sommerseth
Headers show
Series
  • [Openvpn-devel] New man page corrections - windows-options.rst
Related show

Commit Message

tincanteksup July 1, 2020, 1:10 a.m.
Signed-off-by: Richard Bonhomme <tincanteksup@gmail.com>
---
 doc/man-sections/windows-options.rst | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

Comments

Jonathan K. Bullard July 2, 2020, 1:41 p.m. | #1
Improves English diction and/or grammar of man page.

Acked-by: Jonathan K. Bullard <jkbullard@gmail.com>

On Tue, Jun 30, 2020 at 9:11 PM Richard Bonhomme <tincanteksup@gmail.com> wrote:
>
> Signed-off-by: Richard Bonhomme <tincanteksup@gmail.com>
> ---
>  doc/man-sections/windows-options.rst | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/doc/man-sections/windows-options.rst b/doc/man-sections/windows-options.rst
> index 5ae7116c..72424d6b 100644
> --- a/doc/man-sections/windows-options.rst
> +++ b/doc/man-sections/windows-options.rst
> @@ -231,7 +231,7 @@ Windows-Specific Options
>    directive is not specified, OpenVPN will use the SystemRoot environment
>    variable.
>
> -  This option have changed behaviour in OpenVPN 2.3. Earlier you had to
> +  This option has changed behaviour since OpenVPN 2.3. Earlier you had to
>    define ``--win-sys env`` to use the SystemRoot environment variable,
>    otherwise it defaulted to :code:`C:\\WINDOWS`. It is not needed to use
>    the ``env`` keyword any more, and it will just be ignored. A warning is
> @@ -239,7 +239,7 @@ Windows-Specific Options
>
>  --windows-driver drv
>    Specifies which tun driver to use. Values are :code:`tap-windows6`
> -  (default) and :code:`wintun`.  This is Windows-only option.
> +  (default) and :code:`wintun`.  This is a Windows-only option.
>    :code:`wintun`" requires ``--dev tun`` and the OpenVPN process to run
>    elevated, or be invoked using the Interactive Service.
>
> --
> 2.17.1
>
>
>
> _______________________________________________
> Openvpn-devel mailing list
> Openvpn-devel@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/openvpn-devel
tincanteksup July 2, 2020, 1:50 p.m. | #2
Hi Jonathan,

these are going to the new manpage, see:
https://gitlab.com/dazo/openvpn/-/tree/dev/man-reformatting

They don't really need an ACK because dazo will review them first anyway 
but thanks all the same :)

Regards


On 02/07/2020 14:41, Jonathan K. Bullard wrote:
> Improves English diction and/or grammar of man page.
> 
> Acked-by: Jonathan K. Bullard <jkbullard@gmail.com>
> 
> On Tue, Jun 30, 2020 at 9:11 PM Richard Bonhomme <tincanteksup@gmail.com> wrote:
>>
>> Signed-off-by: Richard Bonhomme <tincanteksup@gmail.com>
>> ---
>>   doc/man-sections/windows-options.rst | 4 ++--
>>   1 file changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/doc/man-sections/windows-options.rst b/doc/man-sections/windows-options.rst
>> index 5ae7116c..72424d6b 100644
>> --- a/doc/man-sections/windows-options.rst
>> +++ b/doc/man-sections/windows-options.rst
>> @@ -231,7 +231,7 @@ Windows-Specific Options
>>     directive is not specified, OpenVPN will use the SystemRoot environment
>>     variable.
>>
>> -  This option have changed behaviour in OpenVPN 2.3. Earlier you had to
>> +  This option has changed behaviour since OpenVPN 2.3. Earlier you had to
>>     define ``--win-sys env`` to use the SystemRoot environment variable,
>>     otherwise it defaulted to :code:`C:\\WINDOWS`. It is not needed to use
>>     the ``env`` keyword any more, and it will just be ignored. A warning is
>> @@ -239,7 +239,7 @@ Windows-Specific Options
>>
>>   --windows-driver drv
>>     Specifies which tun driver to use. Values are :code:`tap-windows6`
>> -  (default) and :code:`wintun`.  This is Windows-only option.
>> +  (default) and :code:`wintun`.  This is a Windows-only option.
>>     :code:`wintun`" requires ``--dev tun`` and the OpenVPN process to run
>>     elevated, or be invoked using the Interactive Service.
>>
>> --
>> 2.17.1
>>
>>
>>
>> _______________________________________________
>> Openvpn-devel mailing list
>> Openvpn-devel@lists.sourceforge.net
>> https://lists.sourceforge.net/lists/listinfo/openvpn-devel
tincanteksup July 2, 2020, 1:55 p.m. | #3
BTW: This is only round 1 of spelling and grammar checking. I have had 
to really hold off from getting nasty with commas etc.
I have tried to only fix the most obvious faux-pars ... ;-)

On 02/07/2020 14:50, tincanteksup wrote:
> Hi Jonathan,
> 
> these are going to the new manpage, see:
> https://gitlab.com/dazo/openvpn/-/tree/dev/man-reformatting
> 
> They don't really need an ACK because dazo will review them first anyway 
> but thanks all the same :)
> 
> Regards
> 
> 
> On 02/07/2020 14:41, Jonathan K. Bullard wrote:
>> Improves English diction and/or grammar of man page.
>>
>> Acked-by: Jonathan K. Bullard <jkbullard@gmail.com>
>>
>> On Tue, Jun 30, 2020 at 9:11 PM Richard Bonhomme 
>> <tincanteksup@gmail.com> wrote:
>>>
>>> Signed-off-by: Richard Bonhomme <tincanteksup@gmail.com>
>>> ---
>>>   doc/man-sections/windows-options.rst | 4 ++--
>>>   1 file changed, 2 insertions(+), 2 deletions(-)
>>>
>>> diff --git a/doc/man-sections/windows-options.rst 
>>> b/doc/man-sections/windows-options.rst
>>> index 5ae7116c..72424d6b 100644
>>> --- a/doc/man-sections/windows-options.rst
>>> +++ b/doc/man-sections/windows-options.rst
>>> @@ -231,7 +231,7 @@ Windows-Specific Options
>>>     directive is not specified, OpenVPN will use the SystemRoot 
>>> environment
>>>     variable.
>>>
>>> -  This option have changed behaviour in OpenVPN 2.3. Earlier you had to
>>> +  This option has changed behaviour since OpenVPN 2.3. Earlier you 
>>> had to
>>>     define ``--win-sys env`` to use the SystemRoot environment variable,
>>>     otherwise it defaulted to :code:`C:\\WINDOWS`. It is not needed 
>>> to use
>>>     the ``env`` keyword any more, and it will just be ignored. A 
>>> warning is
>>> @@ -239,7 +239,7 @@ Windows-Specific Options
>>>
>>>   --windows-driver drv
>>>     Specifies which tun driver to use. Values are :code:`tap-windows6`
>>> -  (default) and :code:`wintun`.  This is Windows-only option.
>>> +  (default) and :code:`wintun`.  This is a Windows-only option.
>>>     :code:`wintun`" requires ``--dev tun`` and the OpenVPN process to 
>>> run
>>>     elevated, or be invoked using the Interactive Service.
>>>
>>> -- 
>>> 2.17.1
>>>
>>>
>>>
>>> _______________________________________________
>>> Openvpn-devel mailing list
>>> Openvpn-devel@lists.sourceforge.net
>>> https://lists.sourceforge.net/lists/listinfo/openvpn-devel

Patch

diff --git a/doc/man-sections/windows-options.rst b/doc/man-sections/windows-options.rst
index 5ae7116c..72424d6b 100644
--- a/doc/man-sections/windows-options.rst
+++ b/doc/man-sections/windows-options.rst
@@ -231,7 +231,7 @@  Windows-Specific Options
   directive is not specified, OpenVPN will use the SystemRoot environment
   variable.
 
-  This option have changed behaviour in OpenVPN 2.3. Earlier you had to
+  This option has changed behaviour since OpenVPN 2.3. Earlier you had to
   define ``--win-sys env`` to use the SystemRoot environment variable,
   otherwise it defaulted to :code:`C:\\WINDOWS`. It is not needed to use
   the ``env`` keyword any more, and it will just be ignored. A warning is
@@ -239,7 +239,7 @@  Windows-Specific Options
 
 --windows-driver drv
   Specifies which tun driver to use. Values are :code:`tap-windows6`
-  (default) and :code:`wintun`.  This is Windows-only option.
+  (default) and :code:`wintun`.  This is a Windows-only option.
   :code:`wintun`" requires ``--dev tun`` and the OpenVPN process to run
   elevated, or be invoked using the Interactive Service.