[Openvpn-devel] Make openvpn --version exit with exit code 0

Message ID E1jsoYQ-0007AZ-8u@sfs-ml-1.v29.lw.sourceforge.com
State Accepted
Headers show
Series
  • [Openvpn-devel] Make openvpn --version exit with exit code 0
Related show

Commit Message

Steffan Karger July 7, 2020, 2:26 p.m.
For some reason, openvpn --version has since the beginning of time
returned exit code 1. A quick sample among common unix utilities confirms
that the rest of the world agrees with me that 0 makes more sense. Let's
make openvpn --version exit with exit code 0 too.

Signed-off-by: Steffan Karger <steffan.karger@foxcrypto.com>
---
 src/openvpn/options.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Patch

diff --git a/src/openvpn/options.c b/src/openvpn/options.c
index 2073b4a6..a72b677a 100644
--- a/src/openvpn/options.c
+++ b/src/openvpn/options.c
@@ -4326,7 +4326,7 @@  usage_version(void)
     msg(M_INFO|M_NOPREFIX, "special build: %s", CONFIGURE_SPECIAL_BUILD);
 #endif
 #endif
-    openvpn_exit(OPENVPN_EXIT_STATUS_USAGE); /* exit point */
+    openvpn_exit(OPENVPN_EXIT_STATUS_GOOD);
 }
 
 void