From patchwork Tue Jul 7 04:26:21 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Steffan Karger X-Patchwork-Id: 1214 Return-Path: Delivered-To: patchwork@openvpn.net Delivered-To: patchwork@openvpn.net Received: from director8.mail.ord1d.rsapps.net ([172.27.255.51]) by backend30.mail.ord1d.rsapps.net with LMTP id OPwvD0mGBF8gIwAAIUCqbw for ; Tue, 07 Jul 2020 10:27:21 -0400 Received: from proxy17.mail.iad3a.rsapps.net ([172.27.255.51]) by director8.mail.ord1d.rsapps.net with LMTP id IOWEDEmGBF+1UwAAfY0hYg ; Tue, 07 Jul 2020 10:27:21 -0400 Received: from smtp19.gate.iad3a ([172.27.255.51]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) by proxy17.mail.iad3a.rsapps.net with LMTP id WDNVBkmGBF85AwAAR4KW9A ; Tue, 07 Jul 2020 10:27:21 -0400 X-Spam-Threshold: 95 X-Spam-Score: 0 X-Spam-Flag: NO X-Virus-Scanned: OK X-Orig-To: openvpnslackdevel@openvpn.net X-Originating-Ip: [216.105.38.7] Authentication-Results: smtp19.gate.iad3a.rsapps.net; iprev=pass policy.iprev="216.105.38.7"; spf=pass smtp.mailfrom="openvpn-devel-bounces@lists.sourceforge.net" smtp.helo="lists.sourceforge.net"; dkim=fail (signature verification failed) header.d=sourceforge.net; dkim=fail (signature verification failed) header.d=sf.net; dkim=fail (signature verification failed) header.d=foxcrypto.com; dmarc=fail (p=none; dis=none) header.from=foxcrypto.com X-Suspicious-Flag: YES X-Classification-ID: f70b53cc-c05d-11ea-b813-5254005d39f2-1-1 Received: from [216.105.38.7] ([216.105.38.7:49550] helo=lists.sourceforge.net) by smtp19.gate.iad3a.rsapps.net (envelope-from ) (ecelerity 4.2.38.62370 r(:)) with ESMTPS (cipher=DHE-RSA-AES256-GCM-SHA384) id FB/CC-05140-846840F5; Tue, 07 Jul 2020 10:27:20 -0400 Received: from [127.0.0.1] (helo=sfs-ml-1.v29.lw.sourceforge.com) by sfs-ml-1.v29.lw.sourceforge.com with esmtp (Exim 4.90_1) (envelope-from ) id 1jsoYQ-0007AZ-8u; Tue, 07 Jul 2020 14:26:38 +0000 Received: from [172.30.20.202] (helo=mx.sourceforge.net) by sfs-ml-1.v29.lw.sourceforge.com with esmtps (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jsoYP-0007AK-5n for openvpn-devel@lists.sourceforge.net; Tue, 07 Jul 2020 14:26:37 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sourceforge.net; s=x; h=Content-Type:MIME-Version:Date:Subject:CC:To:From: Sender:Reply-To:Message-ID:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:In-Reply-To:References:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=cbPKobMVj5x7dB6XeF+FkXS9Y/5awH2YjGiifqMfNoM=; b=GWa9WMH87sRAsc3c0zidTn9LuZ KDKzujVoLkGJy348HP1Yhc1E8QPqHfbyFD7XmLzs5i490CiKcOnGl8e7X1I0VhW5yOIi9sjuyceHP dKyAEHx7wrpI8pt2sqrHDc1shw/IAMlS3eEdq0E/kc1gwv07NtVxnNAoO/Ep9xMku+mo=; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sf.net; s=x ; h=Content-Type:MIME-Version:Date:Subject:CC:To:From:Sender:Reply-To: Message-ID:Content-Transfer-Encoding:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: In-Reply-To:References:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=cbPKobMVj5x7dB6XeF+FkXS9Y/5awH2YjGiifqMfNoM=; b=iT9fdpmcIlO05/DOUDzRM/cfHH +6rYSKhtUfM58UU4ck+04fQSN2hdem5tmVi/G+TCJKyzEFMsPQ5FaSm3jFGz9jiSeVhLB2989imdq wGCzLtqZI9Dz9oyW/50R7ebHCJCLZ4aS6M4y0aJiury0nuauaqwP6/j73QAJNk57Ewz8=; Received: from nl-dft-mx-01.fox-it.com ([178.250.144.135]) by sfi-mx-1.v28.lw.sourceforge.com with esmtps (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.92.2) id 1jsoYM-00GFHX-Mx for openvpn-devel@lists.sourceforge.net; Tue, 07 Jul 2020 14:26:37 +0000 From: Steffan Karger To: Date: Tue, 7 Jul 2020 16:26:21 +0200 X-Mailer: git-send-email 2.17.1 MIME-Version: 1.0 X-ClientProxiedBy: FOXDFT1EX01.FOX.local (10.0.0.129) To FOXDFT1EX01.FOX.local (10.0.0.129) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; d=foxcrypto.com; s=NL-DFT-MX-01; c=relaxed/relaxed; h=from:to:cc:subject:date:mime-version:content-type; bh=cbPKobMVj5x7dB6XeF+FkXS9Y/5awH2YjGiifqMfNoM=; b=nFMxGPywoBkUbFU2gazjp8TPbTsv6JpH0pDTLXc4rNM2kdrutTBeu+sL2MF8OfsyttFPigsxSRKw McUvMWIqbpq+7px+fV9hAjtFoeibyY2l5tk8eXPY1c884DBYmOLQJ44WJ6E6goywmxaseIkV9ubL dYsmF/kgqErQO9SIPqepIBJS0vbWxys3QnRYFrvAz1uhfjWOU79v+B6kWaZjgOl5a7c+3HnvgTqj e9ORNj590k+clgrUC9NtSbTfx4o7zI/2FTU8dGqX2Ml1HOUWd0eAqTYkfEV+8S/2gg1NlaWjIE5s mIg+nxiIzNNxL9vrZbCjWGM5wVBy33xzJIeNmg== X-Spam-Report: Spam Filtering performed by mx.sourceforge.net. See http://spamassassin.org/tag/ for more details. 0.0 URIBL_BLOCKED ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [URIs: foxcrypto.com] -0.0 SPF_PASS SPF: sender matches SPF record 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid 1.0 MISSING_MID Missing Message-Id: header 0.8 AWL AWL: Adjusted score from AWL reputation of From: address X-Headers-End: 1jsoYM-00GFHX-Mx Subject: [Openvpn-devel] [PATCH] Make openvpn --version exit with exit code 0 X-BeenThere: openvpn-devel@lists.sourceforge.net X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: openvpn-devel-bounces@lists.sourceforge.net Message-Id: X-getmail-retrieved-from-mailbox: Inbox For some reason, openvpn --version has since the beginning of time returned exit code 1. A quick sample among common unix utilities confirms that the rest of the world agrees with me that 0 makes more sense. Let's make openvpn --version exit with exit code 0 too. Signed-off-by: Steffan Karger --- src/openvpn/options.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/openvpn/options.c b/src/openvpn/options.c index 2073b4a6..a72b677a 100644 --- a/src/openvpn/options.c +++ b/src/openvpn/options.c @@ -4326,7 +4326,7 @@ usage_version(void) msg(M_INFO|M_NOPREFIX, "special build: %s", CONFIGURE_SPECIAL_BUILD); #endif #endif - openvpn_exit(OPENVPN_EXIT_STATUS_USAGE); /* exit point */ + openvpn_exit(OPENVPN_EXIT_STATUS_GOOD); } void