From patchwork Fri Jul 17 07:09:48 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Matthias Andree X-Patchwork-Id: 1295 Return-Path: Delivered-To: patchwork@openvpn.net Delivered-To: patchwork@openvpn.net Received: from director9.mail.ord1d.rsapps.net ([172.30.191.6]) by backend30.mail.ord1d.rsapps.net with LMTP id 2FVYKabbEV9LFAAAIUCqbw for ; Fri, 17 Jul 2020 13:11:02 -0400 Received: from proxy18.mail.ord1d.rsapps.net ([172.30.191.6]) by director9.mail.ord1d.rsapps.net with LMTP id EGIPKabbEV/9bQAAalYnBA ; Fri, 17 Jul 2020 13:11:02 -0400 Received: from smtp22.gate.ord1d ([172.30.191.6]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) by proxy18.mail.ord1d.rsapps.net with LMTP id MHScKKbbEV9wRwAATCaURg ; Fri, 17 Jul 2020 13:11:02 -0400 X-Spam-Threshold: 95 X-Spam-Score: 0 X-Spam-Flag: NO X-Virus-Scanned: OK X-Orig-To: openvpnslackdevel@openvpn.net X-Originating-Ip: [216.105.38.7] Authentication-Results: smtp22.gate.ord1d.rsapps.net; iprev=pass policy.iprev="216.105.38.7"; spf=pass smtp.mailfrom="openvpn-devel-bounces@lists.sourceforge.net" smtp.helo="lists.sourceforge.net"; dkim=fail (signature verification failed) header.d=sourceforge.net; dkim=fail (signature verification failed) header.d=sf.net; dkim=fail (signature verification failed) header.d=gmx.net; dmarc=none (p=nil; dis=none) header.from=gmx.de X-Suspicious-Flag: YES X-Classification-ID: 7d76fb4c-c850-11ea-93bf-5254001a15c2-1-1 Received: from [216.105.38.7] ([216.105.38.7:44214] helo=lists.sourceforge.net) by smtp22.gate.ord1d.rsapps.net (envelope-from ) (ecelerity 4.2.38.62370 r(:)) with ESMTPS (cipher=DHE-RSA-AES256-GCM-SHA384) id 5D/87-29944-6ABD11F5; Fri, 17 Jul 2020 13:11:02 -0400 Received: from [127.0.0.1] (helo=sfs-ml-1.v29.lw.sourceforge.com) by sfs-ml-1.v29.lw.sourceforge.com with esmtp (Exim 4.90_1) (envelope-from ) id 1jwTsB-0002Dl-17; Fri, 17 Jul 2020 17:10:11 +0000 Received: from [172.30.20.202] (helo=mx.sourceforge.net) by sfs-ml-1.v29.lw.sourceforge.com with esmtps (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jwTrz-0002CF-9x for openvpn-devel@lists.sourceforge.net; Fri, 17 Jul 2020 17:09:59 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sourceforge.net; s=x; h=Content-Transfer-Encoding:MIME-Version:Message-Id: Date:Subject:Cc:To:From:Sender:Reply-To:Content-Type:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:In-Reply-To:References:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=q/Jvv7cEpl9MJ11OyVWYvpyFC4gotDYbFbMkCQ7gp7Y=; b=ghC0ErUn5JyRd3oRFD8aqM7w4F mgnI3wmf1KG0+3yQQODGRtrn1x0CdZX5DX4fBtVJoNfN73p3gU3upKcqltiWuptOd66qSm/sFlLlA G6ouyjALlojTVgo3Ds3dZtuP9Kqq1EVbv4wdktb6TRXauO+IZhG3wsIriYHd8bVZpUFk=; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sf.net; s=x ; h=Content-Transfer-Encoding:MIME-Version:Message-Id:Date:Subject:Cc:To:From :Sender:Reply-To:Content-Type:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To: References:List-Id:List-Help:List-Unsubscribe:List-Subscribe:List-Post: List-Owner:List-Archive; bh=q/Jvv7cEpl9MJ11OyVWYvpyFC4gotDYbFbMkCQ7gp7Y=; b=W 8Kwk3zvn3t/o58OhEppmd/eytIfjd+HmzxKezc9nWB8rdGRQ/U44w/D+0Ag5eZ1geJCCAss32uoG2 acAc9Rxt+2Snj94e4M+mdRoph5AhAqkUnuQe5RstbPQNW4/cwIctSo6cthyQrDZhSAC5mEjjMRm6K N4bGV4qtK62plz1E=; Received: from mout.gmx.net ([212.227.15.19]) by sfi-mx-3.v28.lw.sourceforge.com with esmtps (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.92.2) id 1jwTrw-004gCt-Mu for openvpn-devel@lists.sourceforge.net; Fri, 17 Jul 2020 17:09:59 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=badeba3b8450; t=1595005790; bh=8CXPO1cxb0QL/S4ByiMRf5umurJI83ppdONVwxe1IiY=; h=X-UI-Sender-Class:From:To:Cc:Subject:Date; b=lyk9jc+g14wWeOBzt3FYKe0dEjXocIkuAbQ4DgnZAHJM0aqpgYlRe4t29lxeAh5Zn NpIudv1Tjm2vWeIdyy4A6RDNwDnaLGcFqcy6X+PuL24KzwrVVoJAVOmfw3N9PAF9Lh lmCgg7PI7WyR2sZ6dNPdBlG7McjMSV2ER67uGoXM= X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c Received: from mandree.no-ip.org ([84.160.55.91]) by mail.gmx.com (mrgmx005 [212.227.17.190]) with ESMTPSA (Nemesis) id 1My32L-1kmDnl0YQB-00zYVr; Fri, 17 Jul 2020 19:09:50 +0200 Received: by ryzen.an3e.de (Postfix, from userid 1000) id C3A39120275; Fri, 17 Jul 2020 19:09:49 +0200 (CEST) From: Matthias Andree To: openvpn-devel@lists.sourceforge.net Date: Fri, 17 Jul 2020 19:09:48 +0200 Message-Id: <20200717170948.227787-1-matthias.andree@gmx.de> X-Mailer: git-send-email 2.25.4 MIME-Version: 1.0 X-Provags-ID: V03:K1:pQsoSL2Ad5+sD1pzn6sOiHweYt9F+tNc0Gfrqe66uCFVM5MixR0 tG1hu4ivC/18N2QM6XIKg9+qinGSY6WZt53fo3b8SwTtWdBjRKQm6dC2SOFMfxvcpXOlGuO cIA8EHmkK6ejpeWxxrEoEieM5HHpV3NjDQqPXawSZOeZa3u2J3c5+7aZhtdP2+YJwow2r95 XgI/196xC+iBJ1pcNbKTQ== X-UI-Out-Filterresults: notjunk:1;V03:K0:d7mr4EULrBU=:VnEv1/PVGZLeRssEQu6QBy 7+SsDu4JGo0UpWahl4rMOQEiLQvh9i87ylxjjfcEOrKxY32V7e7LXMy3s2fLweStC8UsVDOmo wA+NLmCInMymGj9O2Q5xptvt5+P77sj1ejRRGWRMllonwov4GudHp1tBGfiFyCXD8idvZQ/VW pvP+6qeszTtHj+1UnJdbV/aw6jt+K65WeRx//tTD8Vv013JrpIxPw4iACl4lMd9sjKidadKbM bK+QmEKr0jQFiSz3EMRmsw86V5lX2SygQ5RwcUGWWMWfjk4uwnWh08TsrVAuMNYd4+xU/GtIg DOGp9H1oidLFZOdITJPsAE6IBsmV0Ka8YAq0iATxktKfR6U8ihEMr5Da2T44bmX2fMVuLHSc9 BR5Vbq5ipJfN2FlRnhLPZyBlm58dmcIpBY+OS61EWz18NuScnX2cA46HpRqDCiZ2h5Dlsm77P ITRTBJ84Nm9/DISASwYBivYa8mkevR9dej3+44ssHOWxqLaGOUsAydWvlh44bBvn/dsCheeDX hZ1l23kl2+pdKEGVaOIxG1eXqOm77YZZc15qYmOYMier5VyL744Fp541BeZreNWqN+tYyyQ6K tUWr/lzVO2WW49WwF9HhhLnRIJ6zXQ877wvUjtphL72r1dQhWOir/uDFG5YlxCJYgOBppfQnu AVjLuSWSxJ7o9dJrY0+zuRaCQcQrPeo8FHX1lDq6sh79LHhGFVp6c4WU/jxk0t4fkE23exQzy nXQqWurNj0cAoS21Uhe0ncy978wdt8PZxiihpkSsVS9A1J5pV2rBZGwtSE9viCvSm5BrvtX2T JCmYGDPjqfd+dHFQviw8RhrglMCy5J8pwLLMmRqR6yhB/1O9Ue5FKx3mySKucDz93i3N8Aj09 DqFN1awdcQ1/a43wRJLVWzVRIwdYMMTPK4Yja99FSvZG1ItXf10sjHGPIqER8w9KS4pdGORpj xUNNHFQIOW2ZBVV8Fce13qQHc5v0CEwamQ2rHWZSbjvW6eo9d6ZMjrNeNaHiZ6q3Jr34/NNs6 n6Yo8ZTTDOZHWIC6cGbqG8xtarrh9Ko4ZiMjKoTuA/NfqebgHarGAa0rpPmasLSQ3US5xLFFz Vqjb0yKQSboMQOrkeSl9SHaAZGgBTu8u5eZtxEusMmiBDqdRuYke9nKEdNjPl3p30khLYbJ2q vy7eHfXbNV8Lts/b9yRqo+NG63pLIz1uW31QymGE/nMiRh7OnqtMtzbZGRfcJEmx6u9hAMl4i hmNlFAuTSP8VMUh89jYOgydrkHd+zdXi7c1jVbw== X-Spam-Report: Spam Filtering performed by mx.sourceforge.net. See http://spamassassin.org/tag/ for more details. 0.0 URIBL_BLOCKED ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [URIs: gmx.de] 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider (matthias.andree[at]gmx.de) -0.0 RCVD_IN_MSPIKE_H2 RBL: Average reputation (+2) [212.227.15.19 listed in wl.mailspike.net] -0.0 SPF_PASS SPF: sender matches SPF record 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid -0.0 AWL AWL: Adjusted score from AWL reputation of From: address X-Headers-End: 1jwTrw-004gCt-Mu Subject: [Openvpn-devel] [PATCH] Fix stack buffer overruns in NEXTADDR() macro: X-BeenThere: openvpn-devel@lists.sourceforge.net X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Matthias Andree Errors-To: openvpn-devel-bounces@lists.sourceforge.net X-getmail-retrieved-from-mailbox: Inbox copy first, then round up the length when adding padding to the advance. Found by: GCC 9.3.0 (FreeBSD) Signed-off-by: Matthias Andree --- src/openvpn/route.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) -- 2.25.4 diff --git a/src/openvpn/route.c b/src/openvpn/route.c index b57da5dd..7f760e9d 100644 --- a/src/openvpn/route.c +++ b/src/openvpn/route.c @@ -3436,7 +3436,7 @@ struct rtmsg { #else /* if defined(TARGET_SOLARIS) */ #define NEXTADDR(w, u) \ if (rtm_addrs & (w)) { \ - l = ROUNDUP( ((struct sockaddr *)&(u))->sa_len); memmove(cp, &(u), l); cp += l; \ + l = ((struct sockaddr *)&(u))->sa_len; memmove(cp, &(u), l); cp += ROUNDUP(l); \ } #define ADVANCE(x, n) (x += ROUNDUP((n)->sa_len)) @@ -3727,6 +3727,7 @@ get_default_gateway_ipv6(struct route_ipv6_gateway_info *rgi6, msg(M_WARN, "GDG6: socket #1 failed"); goto done; } + errno = 0; if (write(sockfd, (char *)&m_rtmsg, l) < 0) { msg(M_WARN, "GDG6: problem writing to routing socket");