[Openvpn-devel] mbedtls: fix typ0 in comment

Message ID 20171205085711.25075-1-a@unstable.cc
State Accepted
Headers show
Series
  • [Openvpn-devel] mbedtls: fix typ0 in comment
Related show

Commit Message

Antonio Quartulli Dec. 5, 2017, 8:57 a.m.
From: Antonio Quartulli <antonio@openvpn.net>

the function used to set the verify callback in mbedTLS is
actually called mbedtls_ssl_conf_verify() and it is invoked
in key_state_ssl_init().

Fix comment accordingly.

Signed-off-by: Antonio Quartulli <antonio@openvpn.net>
---
 src/openvpn/ssl_verify_mbedtls.h | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

Comments

Steffan Karger Dec. 5, 2017, 10:03 p.m. | #1
On 05-12-17 09:57, Antonio Quartulli wrote:
> From: Antonio Quartulli <antonio@openvpn.net>
> 
> the function used to set the verify callback in mbedTLS is
> actually called mbedtls_ssl_conf_verify() and it is invoked
> in key_state_ssl_init().
> 
> Fix comment accordingly.
> 
> Signed-off-by: Antonio Quartulli <antonio@openvpn.net>
> ---
>  src/openvpn/ssl_verify_mbedtls.h | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/src/openvpn/ssl_verify_mbedtls.h b/src/openvpn/ssl_verify_mbedtls.h
> index 8b0a5ae9..2fba362f 100644
> --- a/src/openvpn/ssl_verify_mbedtls.h
> +++ b/src/openvpn/ssl_verify_mbedtls.h
> @@ -48,9 +48,9 @@ typedef mbedtls_x509_crt openvpn_x509_cert_t;
>   * This callback function is called when a new TLS session is being setup to
>   * determine whether the remote OpenVPN peer's certificate is allowed to
>   * connect. It is called for once for every certificate in the chain. The
> - * callback functionality is configured in the \c init_ssl() function, which
> - * calls the mbed TLS library's \c ssl_set_verify_callback() function with \c
> - * verify_callback() as its callback argument.
> + * callback functionality is configured in the \c key_state_ssl_init() function,
> + * which calls the mbed TLS library's \c mbedtls_ssl_conf_verify() function with
> + * \c verify_callback() as its callback argument.
>   *
>   * It checks *flags and registers the certificate hash. If these steps succeed,
>   * it calls the \c verify_cert() function, which performs OpenVPN-specific
> 

Acked-by: Steffan Karger <steffan@karger.me>

-Steffan

------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot
sameer.s.athaley Dec. 6, 2017, 4:14 a.m. | #2
How the fuck unsubscribe this, its very annoynng

On 05-Dec-2017 2:28 PM, "Antonio Quartulli" <a@unstable.cc> wrote:

> From: Antonio Quartulli <antonio@openvpn.net>
>
> the function used to set the verify callback in mbedTLS is
> actually called mbedtls_ssl_conf_verify() and it is invoked
> in key_state_ssl_init().
>
> Fix comment accordingly.
>
> Signed-off-by: Antonio Quartulli <antonio@openvpn.net>
> ---
>  src/openvpn/ssl_verify_mbedtls.h | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/src/openvpn/ssl_verify_mbedtls.h b/src/openvpn/ssl_verify_
> mbedtls.h
> index 8b0a5ae9..2fba362f 100644
> --- a/src/openvpn/ssl_verify_mbedtls.h
> +++ b/src/openvpn/ssl_verify_mbedtls.h
> @@ -48,9 +48,9 @@ typedef mbedtls_x509_crt openvpn_x509_cert_t;
>   * This callback function is called when a new TLS session is being setup
> to
>   * determine whether the remote OpenVPN peer's certificate is allowed to
>   * connect. It is called for once for every certificate in the chain. The
> - * callback functionality is configured in the \c init_ssl() function,
> which
> - * calls the mbed TLS library's \c ssl_set_verify_callback() function
> with \c
> - * verify_callback() as its callback argument.
> + * callback functionality is configured in the \c key_state_ssl_init()
> function,
> + * which calls the mbed TLS library's \c mbedtls_ssl_conf_verify()
> function with
> + * \c verify_callback() as its callback argument.
>   *
>   * It checks *flags and registers the certificate hash. If these steps
> succeed,
>   * it calls the \c verify_cert() function, which performs OpenVPN-specific
> --
> 2.15.1
>
>
> ------------------------------------------------------------
> ------------------
> Check out the vibrant tech community on one of the world's most
> engaging tech sites, Slashdot.org! http://sdm.link/slashdot
> _______________________________________________
> Openvpn-devel mailing list
> Openvpn-devel@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/openvpn-devel
>
<div dir="auto">How the fuck unsubscribe this, its very annoynng </div><div class="gmail_extra"><br><div class="gmail_quote">On 05-Dec-2017 2:28 PM, &quot;Antonio Quartulli&quot; &lt;a@unstable.cc&gt; wrote:<br type="attribution"><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">From: Antonio Quartulli &lt;<a href="mailto:antonio@openvpn.net">antonio@openvpn.net</a>&gt;<br>
<br>
the function used to set the verify callback in mbedTLS is<br>
actually called mbedtls_ssl_conf_verify() and it is invoked<br>
in key_state_ssl_init().<br>
<br>
Fix comment accordingly.<br>
<br>
Signed-off-by: Antonio Quartulli &lt;<a href="mailto:antonio@openvpn.net">antonio@openvpn.net</a>&gt;<br>
---<br>
 src/openvpn/ssl_verify_<wbr>mbedtls.h | 6 +++---<br>
 1 file changed, 3 insertions(+), 3 deletions(-)<br>
<br>
diff --git a/src/openvpn/ssl_verify_<wbr>mbedtls.h b/src/openvpn/ssl_verify_<wbr>mbedtls.h<br>
index 8b0a5ae9..2fba362f 100644<br>
--- a/src/openvpn/ssl_verify_<wbr>mbedtls.h<br>
+++ b/src/openvpn/ssl_verify_<wbr>mbedtls.h<br>
@@ -48,9 +48,9 @@ typedef mbedtls_x509_crt openvpn_x509_cert_t;<br>
  * This callback function is called when a new TLS session is being setup to<br>
  * determine whether the remote OpenVPN peer&#39;s certificate is allowed to<br>
  * connect. It is called for once for every certificate in the chain. The<br>
- * callback functionality is configured in the \c init_ssl() function, which<br>
- * calls the mbed TLS library&#39;s \c ssl_set_verify_callback() function with \c<br>
- * verify_callback() as its callback argument.<br>
+ * callback functionality is configured in the \c key_state_ssl_init() function,<br>
+ * which calls the mbed TLS library&#39;s \c mbedtls_ssl_conf_verify() function with<br>
+ * \c verify_callback() as its callback argument.<br>
  *<br>
  * It checks *flags and registers the certificate hash. If these steps succeed,<br>
  * it calls the \c verify_cert() function, which performs OpenVPN-specific<br>
--<br>
2.15.1<br>
<br>
<br>
------------------------------<wbr>------------------------------<wbr>------------------<br>
Check out the vibrant tech community on one of the world&#39;s most<br>
engaging tech sites, Slashdot.org! <a href="http://sdm.link/slashdot" rel="noreferrer" target="_blank">http://sdm.link/slashdot</a><br>
______________________________<wbr>_________________<br>
Openvpn-devel mailing list<br>
<a href="mailto:Openvpn-devel@lists.sourceforge.net">Openvpn-devel@lists.<wbr>sourceforge.net</a><br>
<a href="https://lists.sourceforge.net/lists/listinfo/openvpn-devel" rel="noreferrer" target="_blank">https://lists.sourceforge.net/<wbr>lists/listinfo/openvpn-devel</a><br>
</blockquote></div></div>
------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot
Gert Doering Dec. 8, 2017, 8:07 a.m. | #3
Thanks.

Your patch has been applied to the master and release/2.4 branch.

commit c68a025a1ca687c19d7ae8599464f768b7525df5 (master)
commit 9df9faeb9fec197f27dd2e51580992b55c085dc5 (release/2.4)
Author: Antonio Quartulli
Date:   Tue Dec 5 16:57:11 2017 +0800

     mbedtls: fix typ0 in comment

     Signed-off-by: Antonio Quartulli <antonio@openvpn.net>
     Acked-by: Steffan Karger <steffan.karger@fox-it.com>
     Message-Id: <20171205085711.25075-1-a@unstable.cc>
     URL: https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg16026.html
     Signed-off-by: Gert Doering <gert@greenie.muc.de>


--
kind regards,

Gert Doering


------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot

Patch

diff --git a/src/openvpn/ssl_verify_mbedtls.h b/src/openvpn/ssl_verify_mbedtls.h
index 8b0a5ae9..2fba362f 100644
--- a/src/openvpn/ssl_verify_mbedtls.h
+++ b/src/openvpn/ssl_verify_mbedtls.h
@@ -48,9 +48,9 @@  typedef mbedtls_x509_crt openvpn_x509_cert_t;
  * This callback function is called when a new TLS session is being setup to
  * determine whether the remote OpenVPN peer's certificate is allowed to
  * connect. It is called for once for every certificate in the chain. The
- * callback functionality is configured in the \c init_ssl() function, which
- * calls the mbed TLS library's \c ssl_set_verify_callback() function with \c
- * verify_callback() as its callback argument.
+ * callback functionality is configured in the \c key_state_ssl_init() function,
+ * which calls the mbed TLS library's \c mbedtls_ssl_conf_verify() function with
+ * \c verify_callback() as its callback argument.
  *
  * It checks *flags and registers the certificate hash. If these steps succeed,
  * it calls the \c verify_cert() function, which performs OpenVPN-specific