From patchwork Fri Oct 23 01:02:54 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Arne Schwabe X-Patchwork-Id: 1521 Return-Path: Delivered-To: patchwork@openvpn.net Delivered-To: patchwork@openvpn.net Received: from director10.mail.ord1d.rsapps.net ([172.27.255.53]) by backend41.mail.ord1d.rsapps.net with LMTP id 4BuPAbLGkl9EfwAAqwncew (envelope-from ) for ; Fri, 23 Oct 2020 08:04:02 -0400 Received: from proxy9.mail.iad3a.rsapps.net ([172.27.255.53]) by director10.mail.ord1d.rsapps.net with LMTP id YCBvAbLGkl8vLgAApN4f7A (envelope-from ) for ; Fri, 23 Oct 2020 08:04:02 -0400 Received: from smtp35.gate.iad3a ([172.27.255.53]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) by proxy9.mail.iad3a.rsapps.net with LMTPS id IP7yNLHGkl+2cwAAGuSQww (envelope-from ) for ; Fri, 23 Oct 2020 08:04:01 -0400 X-Spam-Threshold: 95 X-Spam-Score: 0 X-Spam-Flag: NO X-Virus-Scanned: OK X-Orig-To: openvpnslackdevel@openvpn.net X-Originating-Ip: [216.105.38.7] Authentication-Results: smtp35.gate.iad3a.rsapps.net; iprev=pass policy.iprev="216.105.38.7"; spf=pass smtp.mailfrom="openvpn-devel-bounces@lists.sourceforge.net" smtp.helo="lists.sourceforge.net"; dkim=fail (signature verification failed) header.d=sourceforge.net; dkim=fail (signature verification failed) header.d=sf.net; dmarc=none (p=nil; dis=none) header.from=rfc2549.org X-Suspicious-Flag: YES X-Classification-ID: d64ce6ae-1527-11eb-90cc-52540083445f-1-1 Received: from [216.105.38.7] ([216.105.38.7:40196] helo=lists.sourceforge.net) by smtp35.gate.iad3a.rsapps.net (envelope-from ) (ecelerity 4.2.38.62370 r(:)) with ESMTPS (cipher=DHE-RSA-AES256-GCM-SHA384) id 22/24-06534-1B6C29F5; Fri, 23 Oct 2020 08:04:01 -0400 Received: from [127.0.0.1] (helo=sfs-ml-2.v29.lw.sourceforge.com) by sfs-ml-2.v29.lw.sourceforge.com with esmtp (Exim 4.90_1) (envelope-from ) id 1kVvn4-0003kB-7L; Fri, 23 Oct 2020 12:03:26 +0000 Received: from [172.30.20.202] (helo=mx.sourceforge.net) by sfs-ml-2.v29.lw.sourceforge.com with esmtps (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kVvmx-0003jk-Lp for openvpn-devel@lists.sourceforge.net; Fri, 23 Oct 2020 12:03:19 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sourceforge.net; s=x; h=References:In-Reply-To:Message-Id:Date:Subject:To: From:Sender:Reply-To:Cc:MIME-Version:Content-Type:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=0Wu/CWHPXkhzUuxMUDxwC6ktQUGztHu8XJBFh8Vz+40=; b=kmnSAAdnkUPNGFlfeeVl3FBjdm lZi48XEpVevkHovFodQRTzNseNmKxXAvI2xXwz0Lv+nmXSnK5hJWAj7ppUpFerKqBqEiC5QValhJ9 tPvSrUJuKTabisRogCLTbjaimpy/a6DjUlX66MeTGzIUtljSnQl36QnxPYy6K4ZUsQUM=; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sf.net; s=x ; h=References:In-Reply-To:Message-Id:Date:Subject:To:From:Sender:Reply-To:Cc :MIME-Version:Content-Type:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=0Wu/CWHPXkhzUuxMUDxwC6ktQUGztHu8XJBFh8Vz+40=; b=fkKjktokBIRLYpwZKTekvbGDh+ zC9QSwcJB2HyFpJY9OwXl4PdjSkiy2JeEK/192jGJ9QllBWccjPspuI9EcOkHJGKz3PPPTZb2Qf7i KWCcTpQZLNRi99IVNscY+YMe8zvowqFvR3ekcMHJ6xChIw5scA1OaMXJJbAyjPBHCC28=; Received: from mail.blinkt.de ([192.26.174.232]) by sfi-mx-3.v28.lw.sourceforge.com with esmtps (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.92.2) id 1kVvmm-003qid-K2 for openvpn-devel@lists.sourceforge.net; Fri, 23 Oct 2020 12:03:19 +0000 Received: from kamera.blinkt.de ([2001:638:502:390:20c:29ff:fec8:535c]) by mail.blinkt.de with smtp (Exim 4.94 (FreeBSD)) (envelope-from ) id 1kVvmd-000JFo-On for openvpn-devel@lists.sourceforge.net; Fri, 23 Oct 2020 14:02:59 +0200 Received: (nullmailer pid 29831 invoked by uid 10006); Fri, 23 Oct 2020 12:02:59 -0000 From: Arne Schwabe To: openvpn-devel@lists.sourceforge.net Date: Fri, 23 Oct 2020 14:02:54 +0200 Message-Id: <20201023120259.29783-2-arne@rfc2549.org> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20201023120259.29783-1-arne@rfc2549.org> References: <20201023113244.26295-1-arne@rfc2549.org> <20201023120259.29783-1-arne@rfc2549.org> X-Spam-Report: Spam Filtering performed by mx.sourceforge.net. See http://spamassassin.org/tag/ for more details. 0.0 URIBL_BLOCKED ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [URIs: rfc2549.org] 0.2 HEADER_FROM_DIFFERENT_DOMAINS From and EnvelopeFrom 2nd level mail domains are different 0.0 SPF_NONE SPF: sender does not publish an SPF Record 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record X-Headers-End: 1kVvmm-003qid-K2 Subject: [Openvpn-devel] [PATCH 3/8] Add more documentation about our internal TLS functions X-BeenThere: openvpn-devel@lists.sourceforge.net X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: openvpn-devel-bounces@lists.sourceforge.net X-getmail-retrieved-from-mailbox: Inbox Signed-off-by: Arne Schwabe Acked-by: Gert Doering --- src/openvpn/ssl.c | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/src/openvpn/ssl.c b/src/openvpn/ssl.c index 618cc9cc..98ce38f9 100644 --- a/src/openvpn/ssl.c +++ b/src/openvpn/ssl.c @@ -1109,7 +1109,10 @@ tls_session_init(struct tls_multi *multi, struct tls_session *session) * @param session - A pointer to the \c tls_session structure to be * cleaned up. * @param clear - Whether the memory allocated for the \a session - * object should be overwritten with 0s. + * object should be overwritten with 0s. This + * implicitly sets many states to 0/false, + * e.g. the validity of the keys in the structure + * */ static void tls_session_free(struct tls_session *session, bool clear) @@ -1118,6 +1121,9 @@ tls_session_free(struct tls_session *session, bool clear) for (size_t i = 0; i < KS_SIZE; ++i) { + /* we don't need clear=true for this call since + * the structs are part of session and get cleared + * as part of session */ key_state_free(&session->key[i], false); }