From patchwork Sat Feb 13 09:25:43 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: romain loutrel X-Patchwork-Id: 1594 X-Patchwork-Delegate: davids@openvpn.net Return-Path: Delivered-To: patchwork@openvpn.net Delivered-To: patchwork@openvpn.net Received: from director7.mail.ord1d.rsapps.net ([172.31.255.6]) by backend30.mail.ord1d.rsapps.net with LMTP id CPkEEyE2KGAGVgAAIUCqbw (envelope-from ) for ; Sat, 13 Feb 2021 15:27:13 -0500 Received: from proxy2.mail.iad3b.rsapps.net ([172.31.255.6]) by director7.mail.ord1d.rsapps.net with LMTP id aFXzEiE2KGC8bAAAovjBpQ (envelope-from ) for ; Sat, 13 Feb 2021 15:27:13 -0500 Received: from smtp7.gate.iad3b ([172.31.255.6]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) by proxy2.mail.iad3b.rsapps.net with LMTPS id gOUuDCE2KGAnKAAAvAZTew (envelope-from ) for ; Sat, 13 Feb 2021 15:27:13 -0500 X-Spam-Threshold: 95 X-Spam-Score: 0 X-Spam-Flag: NO X-Virus-Scanned: OK X-Orig-To: openvpnslackdevel@openvpn.net X-Originating-Ip: [216.105.38.7] Authentication-Results: smtp7.gate.iad3b.rsapps.net; iprev=pass policy.iprev="216.105.38.7"; spf=pass smtp.mailfrom="openvpn-devel-bounces@lists.sourceforge.net" smtp.helo="lists.sourceforge.net"; dkim=fail (signature verification failed) header.d=sourceforge.net; dkim=fail (signature verification failed) header.d=sf.net; dkim=fail (signature verification failed) header.d=gmail.com; dmarc=fail (p=none; dis=none) header.from=gmail.com X-Suspicious-Flag: YES X-Classification-ID: d99bfd02-6e39-11eb-82d7-525400e292e5-1-1 Received: from [216.105.38.7] ([216.105.38.7:44716] helo=lists.sourceforge.net) by smtp7.gate.iad3b.rsapps.net (envelope-from ) (ecelerity 4.2.38.62370 r(:)) with ESMTPS (cipher=DHE-RSA-AES256-GCM-SHA384) id B4/9C-06552-F1638206; Sat, 13 Feb 2021 15:27:11 -0500 Received: from [127.0.0.1] (helo=sfs-ml-1.v29.lw.sourceforge.com) by sfs-ml-1.v29.lw.sourceforge.com with esmtp (Exim 4.90_1) (envelope-from ) id 1lB1Uf-0007am-Jw; Sat, 13 Feb 2021 20:26:17 +0000 Received: from [172.30.20.202] (helo=mx.sourceforge.net) by sfs-ml-1.v29.lw.sourceforge.com with esmtps (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lB1UX-0007ZX-53 for openvpn-devel@lists.sourceforge.net; Sat, 13 Feb 2021 20:26:09 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sourceforge.net; s=x; h=Content-Type:To:Subject:Message-ID:Date:From: MIME-Version:Sender:Reply-To:Cc:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:In-Reply-To:References:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=BIfh2STh/MPLtl3YSdGgiwrE1uu2gsOXMRuwqMa5jHk=; b=g3id3n+Gha2ecAdgBX+3EGenCn nrZ3pJKM0HnD/mvJRYGIMeZAndPml7m8hOddrWxx4IdClejTXz+unfGCwWK+P8I2co2f0m5onq+Gl 7Vxsipq+aadPtEUZr8onUQD3ainSDyyX0a5a+41WeyD4ZK697A5CiZqNBFo1KSXsXqpE=; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sf.net; s=x ; h=Content-Type:To:Subject:Message-ID:Date:From:MIME-Version:Sender:Reply-To :Cc:Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To: References:List-Id:List-Help:List-Unsubscribe:List-Subscribe:List-Post: List-Owner:List-Archive; bh=BIfh2STh/MPLtl3YSdGgiwrE1uu2gsOXMRuwqMa5jHk=; b=k wE0dxxKPjEEVRq3QkhNddy8Qf23daxG9oYBeS3ebzFWBwwhbXZyCIoBTIijXSaNGCvgJ8ItffjORS vTQNMtbJ3FN/LCo7Se6bJSKku9uMVLMnNPNKvrVaGknlGezIPYHqg35SrjxVOIwKgrszs2AN9hQSM ofbXYVMz3O9stZCo=; Received: from mail-lf1-f54.google.com ([209.85.167.54]) by sfi-mx-2.v28.lw.sourceforge.com with esmtps (TLSv1.2:ECDHE-RSA-AES128-GCM-SHA256:128) (Exim 4.92.3) id 1lB1UP-0007aK-43 for openvpn-devel@lists.sourceforge.net; Sat, 13 Feb 2021 20:26:07 +0000 Received: by mail-lf1-f54.google.com with SMTP id d3so4528490lfg.10 for ; Sat, 13 Feb 2021 12:26:00 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:from:date:message-id:subject:to; bh=BIfh2STh/MPLtl3YSdGgiwrE1uu2gsOXMRuwqMa5jHk=; b=Kx7StAIWKMOF1APPo5eTerQy1fJw4CUjOLFvSgq33UcsYZeSCOPBXPJDm/FUvhd9e8 dvdWdOHJGruQVzLbh5R6TEnU6Kr1GjP1/p+iVV0IRkoHw2PK1aVsrpggpRXcBQzWTTVb GR5nfcT0WO4JNmduZgE0oOzMvsK3Sy1bdtZCzoyFN0HotbogewBgh2+dezJfUnPLHMaz wPdGeQWmWpN2QQcQY08Qx/I9gQVewgZ2IgcjPGLOgoreMR/iAjDBfSOF/jqsoH+LxW1L dFELS7em7m6E1F+K0TzyY0NARUJrj+vWzGCPiBMsug5fnAQbuP3oSSJCl+qB5n1upi/G P8aw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:from:date:message-id:subject:to; bh=BIfh2STh/MPLtl3YSdGgiwrE1uu2gsOXMRuwqMa5jHk=; b=pKeOTxvwveOqE/be6jFAARsUmRsJNe5aLVm9NQiH3bVDGYh9wOcCNvpBYnZZCh29K4 VC3AdKq/BQmkDZiu+XPEn8RIMF+1lPIqU3eS+yNCHu1uTBaLiX0i+slUsiZgtWPz+GCp F4jck5MQDhKiqazX4Dko1urU5jDv4VCkekrrGqIgrEke0ht658pu4IVx2BCpF42E4Vyg KmtI4PK5j7M94Ur0JdSGPnn9GVMY820C0Bwop+tjCqF+ucp5yIaO/Qv2Zpu8NQ0o4QY2 Vj55ScMK7t+CJcG+fVXZ9K3qZbdwHpFfMz7u+K2rDRjnpDBWqXdyXdX1mUoZwkpiWELe dx4g== X-Gm-Message-State: AOAM533MlGFoQwAYEkQ+YKGh2mLdGu53Ltjg9b3XQn8L2njzHJM+r8Ds 3iSzAFHm16vg9zlDEXRWZ/ydwLQUzgmS0fYT/UYdves9VDclDqEI X-Google-Smtp-Source: ABdhPJz3COxmyukbMZVGiCI2qU8lgEloBhks9pYcpN/nVwev1nlaRorwfXus9mQSpWuMMsAXHqyGOq4rbQzGmQhPMgk= X-Received: by 2002:ac2:4144:: with SMTP id c4mr4695558lfi.549.1613247954483; Sat, 13 Feb 2021 12:25:54 -0800 (PST) MIME-Version: 1.0 From: romain loutrel Date: Sat, 13 Feb 2021 21:25:43 +0100 Message-ID: To: openvpn-devel@lists.sourceforge.net X-Spam-Report: Spam Filtering performed by mx.sourceforge.net. See http://spamassassin.org/tag/ for more details. 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider (un.romain.loutrel[at]gmail.com) -0.0 RCVD_IN_MSPIKE_H2 RBL: Average reputation (+2) [209.85.167.54 listed in wl.mailspike.net] -0.0 SPF_PASS SPF: sender matches SPF record 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid 0.0 URIBL_BLOCKED ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [URIs: configparser.py] -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [209.85.167.54 listed in list.dnswl.org] X-Headers-End: 1lB1UP-0007aK-43 Subject: [Openvpn-devel] [Patch] Add argument from openvpn2 to be ignored in openvpn3 client X-BeenThere: openvpn-devel@lists.sourceforge.net X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: openvpn-devel-bounces@lists.sourceforge.net X-getmail-retrieved-from-mailbox: Inbox Hi I created today the bug ticket: https://github.com/OpenVPN/openvpn3-linux/issues/36 I have a patch to fix the problem (accept but ignore old parameters from openvpn2 in openvpn3) I hope I made everything correctly. Thanks for your consideration Index: src/python/openvpn3/ConfigParser.py IDEA additional info: Subsystem: com.intellij.openapi.diff.impl.patch.CharsetEP <+>UTF-8 =================================================================== diff --git a/src/python/openvpn3/ConfigParser.py b/src/python/openvpn3/ConfigParser.py --- a/src/python/openvpn3/ConfigParser.py (revision 20319752618587500d7d5bc496965d742ce161dc) +++ b/src/python/openvpn3/ConfigParser.py (revision 9cb300d007775fd68964e107f85cc3808d6e583c) @@ -718,6 +718,13 @@ + 'Not needed with OpenVPN 3 which uses a ' + 'different privilege separation approach') + ignored.add_argument('--mute', + metavar='SECS', + action=ConfigParser.IgnoreArg, + nargs=1, + help='Silence repeating messages during n ' + + 'seconds. Not supported in OpenVPN3') + ignored.add_argument('--nice', metavar='LEVEL', action=ConfigParser.IgnoreArg, @@ -763,6 +770,19 @@ + 'retry resolve for n seconds before failing. ' + 'Not supported by OpenVPN 3') + ignored.add_argument('--route-delay', + action=ConfigParser.IgnoreArg, + nargs='*', + help='Delay n seconds (default 0) after ' + + 'connection establishment, before adding ' + + ' routes. Not supported by OpenVPN 3.') + + ignored.add_argument('--route-method', + action=ConfigParser.IgnoreArg, + nargs=1, + help='Which method m to use for adding routes on ' + + 'Windows. Not supported by OpenVPN 3.') + ignored.add_argument('--script-security', metavar='LEVEL', action=ConfigParser.IgnoreArg,