From patchwork Wed Mar 31 21:29:34 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Gert Doering X-Patchwork-Id: 1681 Return-Path: Delivered-To: patchwork@openvpn.net Delivered-To: patchwork@openvpn.net Received: from director8.mail.ord1d.rsapps.net ([172.27.255.56]) by backend30.mail.ord1d.rsapps.net with LMTP id KC1RDrOEZWDYRAAAIUCqbw (envelope-from ) for ; Thu, 01 Apr 2021 04:30:43 -0400 Received: from proxy16.mail.iad3a.rsapps.net ([172.27.255.56]) by director8.mail.ord1d.rsapps.net with LMTP id MMIxDrOEZWClBAAAfY0hYg (envelope-from ) for ; Thu, 01 Apr 2021 04:30:43 -0400 Received: from smtp5.gate.iad3a ([172.27.255.56]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) by proxy16.mail.iad3a.rsapps.net with LMTPS id IBb9CLOEZWDjWAAADc5QwQ (envelope-from ) for ; Thu, 01 Apr 2021 04:30:43 -0400 X-Spam-Threshold: 95 X-Spam-Score: 0 X-Spam-Flag: NO X-Virus-Scanned: OK X-Orig-To: openvpnslackdevel@openvpn.net X-Originating-Ip: [216.105.38.7] Authentication-Results: smtp5.gate.iad3a.rsapps.net; iprev=pass policy.iprev="216.105.38.7"; spf=pass smtp.mailfrom="openvpn-devel-bounces@lists.sourceforge.net" smtp.helo="lists.sourceforge.net"; dkim=fail (signature verification failed) header.d=sourceforge.net; dkim=fail (signature verification failed) header.d=sf.net; dmarc=none (p=nil; dis=none) header.from=greenie.muc.de X-Suspicious-Flag: YES X-Classification-ID: 8b08ff32-92c4-11eb-b0bd-525400de824c-1-1 Received: from [216.105.38.7] ([216.105.38.7:52234] helo=lists.sourceforge.net) by smtp5.gate.iad3a.rsapps.net (envelope-from ) (ecelerity 4.2.38.62370 r(:)) with ESMTPS (cipher=DHE-RSA-AES256-GCM-SHA384) id F6/6D-25578-1B485606; Thu, 01 Apr 2021 04:30:42 -0400 Received: from [127.0.0.1] (helo=sfs-ml-2.v29.lw.sourceforge.com) by sfs-ml-2.v29.lw.sourceforge.com with esmtp (Exim 4.92.3) (envelope-from ) id 1lRsiA-0002Kd-7A; Thu, 01 Apr 2021 08:29:54 +0000 Received: from [172.30.20.202] (helo=mx.sourceforge.net) by sfs-ml-2.v29.lw.sourceforge.com with esmtps (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.92.3) (envelope-from ) id 1lRsi8-0002KV-IM for openvpn-devel@lists.sourceforge.net; Thu, 01 Apr 2021 08:29:52 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sourceforge.net; s=x; h=Content-Transfer-Encoding:MIME-Version:Message-Id: Date:Subject:To:From:Sender:Reply-To:Cc:Content-Type:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:In-Reply-To:References:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=EfdMKQHP2H4JoH2T/QNux56pV37QhIhrGurjFca4ECQ=; b=Ugu90EMwdTn4OGpD9lRIxJIlYL Wnou/Nck5xh41r5gXOS0qJNwvWUF+m5qE57X7GFXEer7fXUX47N7604gTVqvcWODPG5srO2mBikdi +ZydttB3sHdAM1wP5Z9jq8qnGHKPouFuzxNiaNRoOo7ek1KJeNbL3TDZmT0AIVa0q/Dk=; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sf.net; s=x ; h=Content-Transfer-Encoding:MIME-Version:Message-Id:Date:Subject:To:From: Sender:Reply-To:Cc:Content-Type:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To: References:List-Id:List-Help:List-Unsubscribe:List-Subscribe:List-Post: List-Owner:List-Archive; bh=EfdMKQHP2H4JoH2T/QNux56pV37QhIhrGurjFca4ECQ=; b=O VvfPWHGljMhrKTenZIeP1ES4oSoBigSLViUMsedXzseQOArNI75eTgSo+eFkujtFqCjfadX3hQR31 GsSfJMkWY5duA7u6MOLVTkcMU9yRWt0al2QX5n5a6h2NWTUxTeT8Y+UbOfuyrgNMTimGW6KTAksU5 bfDXpeICW3Xr2V4g=; Received: from dhcp-174.greenie.muc.de ([193.149.48.174] helo=blue.greenie.muc.de) by sfi-mx-1.v28.lw.sourceforge.com with esmtps (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.92.2) id 1lRsi1-002McL-FR for openvpn-devel@lists.sourceforge.net; Thu, 01 Apr 2021 08:29:52 +0000 Received: from blue.greenie.muc.de (localhost [127.0.0.1]) by blue.greenie.muc.de (8.15.2/8.14.9) with ESMTP id 1318TZ3Y029970 for ; Thu, 1 Apr 2021 10:29:35 +0200 Received: (from gert@localhost) by blue.greenie.muc.de (8.15.2/8.14.9/Submit) id 1318TZ1w029969 for openvpn-devel@lists.sourceforge.net; Thu, 1 Apr 2021 10:29:35 +0200 From: Gert Doering To: openvpn-devel@lists.sourceforge.net Date: Thu, 1 Apr 2021 10:29:34 +0200 Message-Id: <20210401082934.29922-1-gert@greenie.muc.de> X-Mailer: git-send-email 2.26.2 MIME-Version: 1.0 X-Spam-Report: Spam Filtering performed by mx.sourceforge.net. See http://spamassassin.org/tag/ for more details. 0.0 URIBL_BLOCKED ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [URIs: muc.de] -0.0 SPF_HELO_PASS SPF: HELO matches SPF record -0.0 SPF_PASS SPF: sender matches SPF record X-Headers-End: 1lRsi1-002McL-FR Subject: [Openvpn-devel] [PATCH] Get rid of last PLUGIN_DEF_AUTH #ifdef X-BeenThere: openvpn-devel@lists.sourceforge.net X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: openvpn-devel-bounces@lists.sourceforge.net X-getmail-retrieved-from-mailbox: Inbox Commit 99d217b200 attempted to get rid of all #ifdef related to --disable-def-auth but one of them managed to hide. Remove. The effect of this is that the "openvpn_acf_...tmp" files get not removed after when an async auth plugin is in use. This is can get very annoying on a busy server. Trac: #1186 Signed-off-by: Gert Doering Acked-by: Antonio Quartulli --- src/openvpn/ssl.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/src/openvpn/ssl.c b/src/openvpn/ssl.c index 893e5753..08222b5e 100644 --- a/src/openvpn/ssl.c +++ b/src/openvpn/ssl.c @@ -992,9 +992,7 @@ key_state_free(struct key_state *ks, bool clear) packet_id_free(&ks->crypto_options.packet_id); -#ifdef PLUGIN_DEF_AUTH key_state_rm_auth_control_files(ks); -#endif if (clear) {