[Openvpn-devel,2/2] Fix parsing of IV_SSO string

Message ID 20210602034253.19984-3-selva.nair@gmail.com
State Accepted
Headers show
Series
  • AUTH_PENDING docs and related
Related show

Commit Message

Selva Nair June 2, 2021, 3:42 a.m.
From: Selva Nair <selva.nair@gmail.com>

Expect comma separated keywords

Signed-off-by: Selva Nair <selva.nair@gmail.com>
---
 src/openvpn/ssl_verify.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Arne Schwabe June 2, 2021, 11:58 a.m. | #1
Am 02.06.21 um 05:42 schrieb selva.nair@gmail.com:
> From: Selva Nair <selva.nair@gmail.com>
> 
> Expect comma separated keywords
> 
> Signed-off-by: Selva Nair <selva.nair@gmail.com>
> ---
>  src/openvpn/ssl_verify.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/src/openvpn/ssl_verify.c b/src/openvpn/ssl_verify.c
> index 0b41eea2..512b4f72 100644
> --- a/src/openvpn/ssl_verify.c
> +++ b/src/openvpn/ssl_verify.c
> @@ -913,7 +913,7 @@ check_auth_pending_method(const char *peer_info, const char *method)
>              supported = true;
>              break;
>          }
> -        client_method = strtok(NULL, ":");
> +        client_method = strtok(NULL, ",");
>      }
>  
>      gc_free(&gc);
> 

Yes. Stupid copy&paste mistake from my side.

Acked-By: Arne Schwabe <arne@rfc2549.org>
Gert Doering June 2, 2021, 2:14 p.m. | #2
I have not tested anything ("for the archives"), but the change makes
sense, is not going to cause build failures anywhere :-) and Arne has
ACKed it.

Your patch has been applied to the master branch.

commit 28240c4a6e9e8134d6a62822918436dbd62b7fde
Author: Selva Nair
Date:   Tue Jun 1 23:42:53 2021 -0400

     Fix parsing of IV_SSO string

     Signed-off-by: Selva Nair <selva.nair@gmail.com>
     Acked-by: Arne Schwabe <arne@rfc2549.org>
     Message-Id: <20210602034253.19984-3-selva.nair@gmail.com>
     URL: https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg22474.html
     Signed-off-by: Gert Doering <gert@greenie.muc.de>


--
kind regards,

Gert Doering

Patch

diff --git a/src/openvpn/ssl_verify.c b/src/openvpn/ssl_verify.c
index 0b41eea2..512b4f72 100644
--- a/src/openvpn/ssl_verify.c
+++ b/src/openvpn/ssl_verify.c
@@ -913,7 +913,7 @@  check_auth_pending_method(const char *peer_info, const char *method)
             supported = true;
             break;
         }
-        client_method = strtok(NULL, ":");
+        client_method = strtok(NULL, ",");
     }
 
     gc_free(&gc);