[Openvpn-devel,v3] Add example script demonstrating TOTP via auth-pending

Message ID 20210802095211.693800-1-arne@rfc2549.org
State New
Headers show
Series
  • [Openvpn-devel,v3] Add example script demonstrating TOTP via auth-pending
Related show

Commit Message

Arne Schwabe Aug. 2, 2021, 9:52 a.m.
Signed-off-by: Arne Schwabe <arne@rfc2549.org>

Patch v3: Some minor cleanups in the script (rename CNs, add more comments)

Signed-off-by: Arne Schwabe <arne@rfc2549.org>
---
 doc/man-sections/script-options.rst |   3 +
 sample/sample-scripts/totpauth.py   | 111 ++++++++++++++++++++++++++++
 2 files changed, 114 insertions(+)
 create mode 100755 sample/sample-scripts/totpauth.py

Comments

tincantech via Openvpn-devel Aug. 2, 2021, 2:25 p.m. | #1
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256

Hi,

Sent with ProtonMail Secure Email.

‐‐‐‐‐‐‐ Original Message ‐‐‐‐‐‐‐

On Monday, August 2nd, 2021 at 10:52, Arne Schwabe <arne@rfc2549.org> wrote:

> Signed-off-by: Arne Schwabe arne@rfc2549.org
>
> Patch v3: Some minor cleanups in the script (rename CNs, add more comments)
>
> Signed-off-by: Arne Schwabe arne@rfc2549.org
>
> doc/man-sections/script-options.rst | 3 +
>
> sample/sample-scripts/totpauth.py | 111 ++++++++++++++++++++++++++++
>
> 2 files changed, 114 insertions(+)
>
> create mode 100755 sample/sample-scripts/totpauth.py
>
> diff --git a/doc/man-sections/script-options.rst b/doc/man-sections/script-options.rst
>
> index f48e5818d..6517f8474 100644
>
> --- a/doc/man-sections/script-options.rst
>
> +++ b/doc/man-sections/script-options.rst
>
> @@ -147,6 +147,9 @@ SCRIPT HOOKS
>
> :code:`auth_control_file or further defer it. See `--auth-user-pass-verify`
>
> for details.
>
> -   For a sample script that implement TOTP (RFC 6238) based two-factor
> -   authentication, see :code:`sample-scripts/totp.py`.

sample-scripts/totp.py -> sample-scripts/totpauth.py

Checked everything else and it all LGTM.
-----BEGIN PGP SIGNATURE-----
Version: ProtonMail

wsBzBAEBCAAGBQJhCABYACEJEE+XnPZrkLidFiEECbw9RGejjXJ5xVVVT5ec
9muQuJ1MTgf+KJa9xstxZXVoGhTer7jFDn+EQdKeBQT3S2JOiu/lLVrGFhCG
+4nEXmsVSN/G/UIqwIzTfe0c6bTALGeEI4YUjL2Rsqixt96xxVUWeer+YVdv
DF4Jxza/vCagzH3uszCpvBgiqB4YIhk7ZaTpLGfXqbY0VgVrwUD1AYPPWPFH
tssgUx5UxSqqoT+AnIpsHTkT/svKCmd1d5IYLjAPy0I9+2vhBQEauWr4f/xa
eoRJb6CQET3z3Lag9DEuqct/k4kT+twS4WYh4Ljr5SzNhuRZV+fbqHQYgk3n
50QttAoUmgzVKkwPSzwTd6u5DZUiT4KyH5REeqAOdwzNYwmxjwKCkQ==
=YOUk
-----END PGP SIGNATURE-----
Antonio Quartulli Aug. 10, 2021, 12:32 p.m. | #2
Hi,

On 02/08/2021 11:52, Arne Schwabe wrote:
> Signed-off-by: Arne Schwabe <arne@rfc2549.org>
> 
> Patch v3: Some minor cleanups in the script (rename CNs, add more comments)
> 
> Signed-off-by: Arne Schwabe <arne@rfc2549.org>

Other than the small fix reported by tincantech, this patch has already
been ACK'd by David in a previous version (also named v3..).

This version is just a rebase, so I would consider his ACK still valid.


Regards,

Patch

diff --git a/doc/man-sections/script-options.rst b/doc/man-sections/script-options.rst
index f48e5818d..6517f8474 100644
--- a/doc/man-sections/script-options.rst
+++ b/doc/man-sections/script-options.rst
@@ -147,6 +147,9 @@  SCRIPT HOOKS
   :code:`auth_control_file or further defer it. See ``--auth-user-pass-verify``
   for details.
 
+  For a sample script that implement TOTP (RFC 6238) based two-factor
+  authentication, see :code:`sample-scripts/totp.py`.
+
 --client-connect cmd
   Run command ``cmd`` on client connection.
 
diff --git a/sample/sample-scripts/totpauth.py b/sample/sample-scripts/totpauth.py
new file mode 100755
index 000000000..2991d6590
--- /dev/null
+++ b/sample/sample-scripts/totpauth.py
@@ -0,0 +1,111 @@ 
+#! /usr/bin/python3
+# Copyright (c) 2021 OpenVPN Inc <sales@openvpn.net>
+# Copyright (c) 2021 Arne Schwabe <arne@rfc2549.org>
+#
+# Permission is hereby granted, free of charge, to any person obtaining a copy
+# of this software and associated documentation files (the "Software"), to deal
+# in the Software without restriction, including without limitation the rights
+# to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
+# copies of the Software, and to permit persons to whom the Software is
+# furnished to do so, subject to the following conditions:
+#
+# The above copyright notice and this permission notice shall be included in all
+# copies or substantial portions of the Software.
+#
+# THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
+# IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
+# FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
+# AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
+# LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
+# OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE
+# SOFTWARE.
+
+import sys
+import os
+from base64 import standard_b64decode
+
+import pyotp
+
+# Example script demonstrating how to use the auth-pending API in
+# OpenVPN. This script is provided under MIT license to allow easy
+# modification for other purposes.
+#
+# This needs support of crtext support on the client (e.g. OpenVPN for Android)
+# See also the management-notes.txt file for more information about the auth pending
+# protocol
+#
+# To use this script add the following lines in the openvpn config
+
+# client-crresponse /path/to/totpauth.py 
+# auth-user-pass-verify /path/to/totpauth.py via-file
+# auth-user-pass-optional
+# auth-gen-token
+
+# Note that this script does NOT verify username/password
+# It is only meant for querying additional 2FA when certificates are
+# used to authenticate
+
+
+# For this demo script we hardcode the TOTP secrets in a simple dictionary.
+secrets = {"Test-Client": "OS6JDNRK2BNUPQVX",
+           "Client-2": "IXWEMP7SK2QWSHTG"}
+
+
+def main():
+    # Get common name and script type from environment
+    script_type = os.environ['script_type']
+    cn = os.environ['common_name']
+
+    if script_type == 'user-pass-verify':
+        # signal text based challenge response
+        if cn in secrets:
+            extra = "CR_TEXT:E,R:Please enter your TOTP code!"
+            write_auth_pending(300, 'crtext', extra)
+
+            # Signal authentication being deferred
+            sys.exit(2)
+        else:
+            # For unknown CN we report failure. Change to 0
+            # to allow CNs without secret to auth without 2FA
+            sys.exit(1)
+
+    elif script_type == 'client-crresponse':
+        response = None
+
+        # Read the crresponse from the argument file
+        # and convert it into text. A failure because of bad user
+        # input (e.g. invalid base64) will make the script throw
+        # an error and make OpenVPN return AUTH_FAILED
+        with open(sys.argv[1], 'r') as crinput:
+            response = crinput.read()
+            response = standard_b64decode(response)
+            response = response.decode().strip()
+
+        if cn not in secrets:
+            write_auth_control(1)
+            return
+
+        totp = pyotp.TOTP(secrets[cn])
+
+        # Check if the code is valid (and also allow code +/-1)
+        if totp.verify(response, valid_window=1):
+            write_auth_control(1)
+        else:
+            write_auth_control(0)
+    else:
+        print(f"Unknown script type {script_type}")
+        sys.exit(1)
+
+
+def write_auth_control(status):
+    with open(os.environ['auth_control_file'], 'w') as auth_control:
+        auth_control.write("%d" % status)
+
+
+def write_auth_pending(timeout, method, extra):
+    with open(os.environ['auth_pending_file'], 'w') as auth_pending:
+        auth_pending.write("%d\n%s\n%s" % (timeout, method, extra))
+
+
+if __name__ == '__main__':
+    main()