[Openvpn-devel] multi: remove extra brackets in multi_process_incoming_link()

Message ID 20210913144531.8889-1-a@unstable.cc
State Accepted
Headers show
Series
  • [Openvpn-devel] multi: remove extra brackets in multi_process_incoming_link()
Related show

Commit Message

Antonio Quartulli Sept. 13, 2021, 2:45 p.m.
After getting rid of all PF related ifdef blocks, a pair of
useless brackets has remained in multi_process_incoming_link().
These brackets do nothing at the moment and can be just removed.

Signed-off-by: Antonio Quartulli <a@unstable.cc>
---
 src/openvpn/multi.c | 6 ++----
 1 file changed, 2 insertions(+), 4 deletions(-)

Comments

Gert Doering Sept. 15, 2021, 12:41 p.m. | #1
Acked-by: Gert Doering <gert@greenie.muc.de>

"trivial" :-)  ("git show -w").

Your patch has been applied to the master branch.

commit c768ee96b49a3df459f584d6050802312815deec
Author: Antonio Quartulli
Date:   Mon Sep 13 16:45:31 2021 +0200

     multi: remove extra brackets in multi_process_incoming_link()

     Signed-off-by: Antonio Quartulli <a@unstable.cc>
     Acked-by: Gert Doering <gert@greenie.muc.de>
     Message-Id: <20210913144531.8889-1-a@unstable.cc>
     URL: https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg22834.html
     Signed-off-by: Gert Doering <gert@greenie.muc.de>


--
kind regards,

Gert Doering

Patch

diff --git a/src/openvpn/multi.c b/src/openvpn/multi.c
index 3453d6aa..103e882e 100644
--- a/src/openvpn/multi.c
+++ b/src/openvpn/multi.c
@@ -3250,10 +3250,8 @@  multi_process_incoming_link(struct multi_context *m, struct multi_instance *inst
                                 /* if dest addr is a known client, route to it */
                                 if (mi)
                                 {
-                                    {
-                                        multi_unicast(m, &c->c2.to_tun, mi);
-                                        register_activity(c, BLEN(&c->c2.to_tun));
-                                    }
+                                    multi_unicast(m, &c->c2.to_tun, mi);
+                                    register_activity(c, BLEN(&c->c2.to_tun));
                                     c->c2.to_tun.len = 0;
                                 }
                             }