[Openvpn-devel] GitHub Actions: use latest working lukka/run-vcpkg

Message ID 20211015213115.516-1-lstipakov@gmail.com
State Accepted
Headers show
Series [Openvpn-devel] GitHub Actions: use latest working lukka/run-vcpkg | expand

Commit Message

Lev Stipakov Oct. 15, 2021, 10:31 a.m. UTC
From: Lev Stipakov <lev@openvpn.net>

Latest lukka/run-vcpkg@v10 seem to break non-manifest
mode with custom triplets, so revert to latest working version.

While on it, bump vcpkg commit.

Signed-off-by: Lev Stipakov <lev@openvpn.net>
---
 .github/workflows/build.yaml | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

Comments

Gert Doering Oct. 19, 2021, 4:08 a.m. UTC | #1
Acked-by: Gert Doering <gert@greenie.muc.de>

Thanks.  Tested, makes GH actions for MSVC work again.

Your patch has been applied to the master branch.

commit 93fadaa0268dbe81a8c7ad3e73b3d54a0cca8c9c
Author: Lev Stipakov
Date:   Sat Oct 16 00:31:15 2021 +0300

     GitHub Actions: use latest working lukka/run-vcpkg

     Signed-off-by: Lev Stipakov <lev@openvpn.net>
     Acked-by: Gert Doering <gert@greenie.muc.de>
     Message-Id: <20211015213115.516-1-lstipakov@gmail.com>
     URL: https://www.mail-archive.com/search?l=mid&q=20211015213115.516-1-lstipakov@gmail.com
     Signed-off-by: Gert Doering <gert@greenie.muc.de>


--
kind regards,

Gert Doering

Patch

diff --git a/.github/workflows/build.yaml b/.github/workflows/build.yaml
index 514ae66b..abf32b14 100644
--- a/.github/workflows/build.yaml
+++ b/.github/workflows/build.yaml
@@ -215,11 +215,11 @@  jobs:
         run: python -m pip install --upgrade pip rst2html
 
       - name: Restore artifacts, or run vcpkg, build and cache artifacts
-        uses: lukka/run-vcpkg@main
+        uses: lukka/run-vcpkg@v7.4
         with:
+          vcpkgGitCommitId: '71422c627264daedcbcd46f01f1ed0dcd8460f1b'
           vcpkgArguments: 'openssl lz4 lzo pkcs11-helper tap-windows6'
           vcpkgTriplet: '${{ matrix.triplet }}-windows-ovpn'
-          vcpkgGitCommitId: '261c458af6e3eed5d099144aff95d2b5035f656b'
           cleanAfterBuild: false
 
       - name: Build