[Openvpn-devel] Remove unused havege.h header

Message ID 20211107160508.3935-1-maximilian.fillinger@foxcrypto.com
State Accepted
Headers show
Series
  • [Openvpn-devel] Remove unused havege.h header
Related show

Commit Message

Max Fillinger Nov. 7, 2021, 4:05 p.m.
This header was removed in mbedtls 3. Luckily, we weren't actually
using it, it seems.

Signed-off-by: Max Fillinger <maximilian.fillinger@foxcrypto.com>
---
 src/openvpn/crypto_mbedtls.c | 1 -
 src/openvpn/ssl_mbedtls.c    | 2 --
 2 files changed, 3 deletions(-)

Comments

Gert Doering Nov. 7, 2021, 9:04 p.m. | #1
Acked-by: Gert Doering <gert@greenie.muc.de>

That seems to be an easy one - all definitions in that file have
"havege" in their name, and "git grep havege" does not show any uses
of them.  Out it goes!

Your patch has been applied to the master branch.

commit d6d4feb4ddd0f23c3816878ff88b49b37379e31b
Author: Max Fillinger
Date:   Sun Nov 7 17:05:08 2021 +0100

     Remove unused havege.h header

     Signed-off-by: Max Fillinger <maximilian.fillinger@foxcrypto.com>
     Acked-by: Gert Doering <gert@greenie.muc.de>
     Message-Id: <20211107160508.3935-1-maximilian.fillinger@foxcrypto.com>
     URL: https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg23126.html
     Signed-off-by: Gert Doering <gert@greenie.muc.de>


--
kind regards,

Gert Doering

Patch

diff --git a/src/openvpn/crypto_mbedtls.c b/src/openvpn/crypto_mbedtls.c
index 2f7f00d1..72e19d23 100644
--- a/src/openvpn/crypto_mbedtls.c
+++ b/src/openvpn/crypto_mbedtls.c
@@ -50,7 +50,6 @@ 
 #include <mbedtls/error.h>
 #include <mbedtls/md5.h>
 #include <mbedtls/cipher.h>
-#include <mbedtls/havege.h>
 #include <mbedtls/pem.h>
 
 #include <mbedtls/entropy.h>
diff --git a/src/openvpn/ssl_mbedtls.c b/src/openvpn/ssl_mbedtls.c
index e7c45c09..1cb27aaa 100644
--- a/src/openvpn/ssl_mbedtls.c
+++ b/src/openvpn/ssl_mbedtls.c
@@ -46,8 +46,6 @@ 
 #include "pkcs11_backend.h"
 #include "ssl_common.h"
 
-#include <mbedtls/havege.h>
-
 #include "ssl_verify_mbedtls.h"
 #include <mbedtls/debug.h>
 #include <mbedtls/error.h>