[Openvpn-devel] README.down-root: Fix plugin module name

Message ID 20211107183805.8357-1-frank@lichtenheld.com
State Accepted
Headers show
Series
  • [Openvpn-devel] README.down-root: Fix plugin module name
Related show

Commit Message

Frank Lichtenheld Nov. 7, 2021, 6:38 p.m.
From: Ville Skyttä <ville.skytta@iki.fi>

The module name is openvpn-plugin-down-root.so, not openvpn-down-root.so.

Signed-off-by: Frank Lichtenheld <frank@lichtenheld.com>
---
 src/plugins/down-root/README.down-root | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

As part of an initative to clean up the Github PR submissions, submitting
this patch to the mailing list for inclusion. Looks obviously correct to
me.
PR: https://github.com/OpenVPN/openvpn/pull/98

Comments

David Sommerseth Nov. 9, 2021, 12:54 p.m. | #1
On 07/11/2021 19:38, Frank Lichtenheld wrote:
> From: Ville Skyttä <ville.skytta@iki.fi>
> 
> The module name is openvpn-plugin-down-root.so, not openvpn-down-root.so.
> 
> Signed-off-by: Frank Lichtenheld <frank@lichtenheld.com>
> ---
>   src/plugins/down-root/README.down-root | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
> 
> As part of an initative to clean up the Github PR submissions, submitting
> this patch to the mailing list for inclusion. Looks obviously correct to
> me.
> PR: https://github.com/OpenVPN/openvpn/pull/98
> 
> diff --git a/src/plugins/down-root/README.down-root b/src/plugins/down-root/README.down-root
> index d337ffe9..98a3ee63 100644
> --- a/src/plugins/down-root/README.down-root
> +++ b/src/plugins/down-root/README.down-root
> @@ -16,13 +16,13 @@ run in the same execution environment as the up script.
>   BUILD
>   
>   Build this module with the "make" command.  The plugin
> -module will be named openvpn-down-root.so
> +module will be named openvpn-plugin-down-root.so
>   
>   USAGE
>   
>   To use this module, add to your OpenVPN config file:
>   
> -  plugin openvpn-down-root.so "command ..."
> +  plugin openvpn-plugin-down-root.so "command ..."
>   
>   CAVEATS

This change is correct.  And even according to
src/plugins/down-root/Makefile.am:

      plugin_LTLIBRARIES = openvpn-plugin-down-root.la

Acked-By: David Sommerseth <davids@openvpn.net>
Gert Doering Nov. 9, 2021, 2:28 p.m. | #2
Your patch has been applied to the master and release/2.5 branch (bugfix).

commit 728064d1e4772af3b83ace770d20ea8c0f652274 (master)
commit b01a43e3bf477973cc070b7f63f1a800d539cea1 (release/2.5)
Author: Ville Skyttä
Date:   Sun Nov 7 19:38:05 2021 +0100

     README.down-root: Fix plugin module name

     Signed-off-by: Frank Lichtenheld <frank@lichtenheld.com>
     Acked-by: David Sommerseth <davids@openvpn.net>
     Message-Id: <20211107183805.8357-1-frank@lichtenheld.com>
     URL: https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg23130.html
     Signed-off-by: Gert Doering <gert@greenie.muc.de>


--
kind regards,

Gert Doering

Patch

diff --git a/src/plugins/down-root/README.down-root b/src/plugins/down-root/README.down-root
index d337ffe9..98a3ee63 100644
--- a/src/plugins/down-root/README.down-root
+++ b/src/plugins/down-root/README.down-root
@@ -16,13 +16,13 @@  run in the same execution environment as the up script.
 BUILD
 
 Build this module with the "make" command.  The plugin
-module will be named openvpn-down-root.so
+module will be named openvpn-plugin-down-root.so
 
 USAGE
 
 To use this module, add to your OpenVPN config file:
 
-  plugin openvpn-down-root.so "command ..."
+  plugin openvpn-plugin-down-root.so "command ..."
 
 CAVEATS