From patchwork Sun Nov 14 02:03:11 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Arne Schwabe X-Patchwork-Id: 2074 Return-Path: Delivered-To: patchwork@openvpn.net Delivered-To: patchwork@openvpn.net Received: from director13.mail.ord1d.rsapps.net ([172.30.191.6]) by backend30.mail.ord1d.rsapps.net with LMTP id GG+cCWwJkWG2YQAAIUCqbw (envelope-from ) for ; Sun, 14 Nov 2021 08:04:44 -0500 Received: from proxy6.mail.ord1d.rsapps.net ([172.30.191.6]) by director13.mail.ord1d.rsapps.net with LMTP id 0PReCWwJkWENGQAA91zNiA (envelope-from ) for ; Sun, 14 Nov 2021 08:04:44 -0500 Received: from smtp19.gate.ord1d ([172.30.191.6]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) by proxy6.mail.ord1d.rsapps.net with LMTPS id EFFACWwJkWHbEgAAQyIf0w (envelope-from ) for ; Sun, 14 Nov 2021 08:04:44 -0500 X-Spam-Threshold: 95 X-Spam-Score: 0 X-Spam-Flag: NO X-Virus-Scanned: OK X-Orig-To: openvpnslackdevel@openvpn.net X-Originating-Ip: [216.105.38.7] Authentication-Results: smtp19.gate.ord1d.rsapps.net; iprev=pass policy.iprev="216.105.38.7"; spf=pass smtp.mailfrom="openvpn-devel-bounces@lists.sourceforge.net" smtp.helo="lists.sourceforge.net"; dkim=fail (signature verification failed) header.d=sourceforge.net; dkim=fail (signature verification failed) header.d=sf.net; dmarc=none (p=nil; dis=none) header.from=rfc2549.org X-Suspicious-Flag: YES X-Classification-ID: 6f080c76-454b-11ec-854f-525400d67fa8-1-1 Received: from [216.105.38.7] ([216.105.38.7:54040] helo=lists.sourceforge.net) by smtp19.gate.ord1d.rsapps.net (envelope-from ) (ecelerity 4.2.38.62370 r(:)) with ESMTPS (cipher=DHE-RSA-AES256-GCM-SHA384) id 4C/69-27429-B6901916; Sun, 14 Nov 2021 08:04:43 -0500 Received: from [127.0.0.1] (helo=sfs-ml-2.v29.lw.sourceforge.com) by sfs-ml-2.v29.lw.sourceforge.com with esmtp (Exim 4.94.2) (envelope-from ) id 1mmFAO-0001U8-FB; Sun, 14 Nov 2021 13:03:28 +0000 Received: from [172.30.20.202] (helo=mx.sourceforge.net) by sfs-ml-2.v29.lw.sourceforge.com with esmtps (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1mmFAM-0001U2-Lw for openvpn-devel@lists.sourceforge.net; Sun, 14 Nov 2021 13:03:26 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sourceforge.net; s=x; h=Content-Transfer-Encoding:MIME-Version:Message-Id: Date:Subject:To:From:Sender:Reply-To:Cc:Content-Type:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:In-Reply-To:References:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=dRzKvK3dZomQosIOdmtTLxudIGyE23UBQvQqyxDznnU=; b=E9qIjfQpiX+xmLqTjY2kJVN6Rw o/nvfFd4FmmuU5m/Ph/5K0NyvKD01/1pUAc3Ak3vy6qF1rAfzvTXg3HVy/1Q6vUZUZ+qmmdUETemY 0nQyDaXN4ecFGYYsPL40vCQhdcWYRrJEjlE6q5B7RFK39KshOQKeGQt/DmP/L6ucRWpU=; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sf.net; s=x ; h=Content-Transfer-Encoding:MIME-Version:Message-Id:Date:Subject:To:From: Sender:Reply-To:Cc:Content-Type:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To: References:List-Id:List-Help:List-Unsubscribe:List-Subscribe:List-Post: List-Owner:List-Archive; bh=dRzKvK3dZomQosIOdmtTLxudIGyE23UBQvQqyxDznnU=; b=I EuErXlTa9hjkrAA5GuaSDUJWWVqfr4gxIesxwS/+gisBihu3HctFH8aRsLks1aL2gCTeabkq+e1DX Sur8tNqguOh9QJ1DjlpL/cv5X2I5L1fLD/jTKjp8dPX095O/Ktl+03nrEoZm+v0bkxGd8hkzta2hW zWIq8s2Jie7KQyIk=; Received: from mail.blinkt.de ([192.26.174.232]) by sfi-mx-1.v28.lw.sourceforge.com with esmtps (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.92.3) id 1mmFAI-00ChjH-Uu for openvpn-devel@lists.sourceforge.net; Sun, 14 Nov 2021 13:03:26 +0000 Received: from kamera.blinkt.de ([2001:638:502:390:20c:29ff:fec8:535c]) by mail.blinkt.de with smtp (Exim 4.94.2 (FreeBSD)) (envelope-from ) id 1mmFA7-0000Ia-BL for openvpn-devel@lists.sourceforge.net; Sun, 14 Nov 2021 14:03:11 +0100 Received: (nullmailer pid 4043584 invoked by uid 10006); Sun, 14 Nov 2021 13:03:11 -0000 From: Arne Schwabe To: openvpn-devel@lists.sourceforge.net Date: Sun, 14 Nov 2021 14:03:11 +0100 Message-Id: <20211114130311.4043536-1-arne@rfc2549.org> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 X-Spam-Report: Spam detection software, running on the system "util-spamd-1.v13.lw.sourceforge.com", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: This IV variable has nothing to do with compression and should not depend if OpenVPN is compiled with USE_COMP. So move it to the other generic IV variables. Signed-off-by: Arne Schwabe --- src/openvpn/comp.c | 1 - src/openvpn/ssl.c | 3 +++ 2 files changed, 3 insertions(+), 1 deletion(-) Content analysis details: (0.3 points, 6.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record 0.0 SPF_NONE SPF: sender does not publish an SPF Record 0.2 HEADER_FROM_DIFFERENT_DOMAINS From and EnvelopeFrom 2nd level mail domains are different X-Headers-End: 1mmFAI-00ChjH-Uu Subject: [Openvpn-devel] [PATCH] Move IV_TCPNL from comp_generate_peer_info_string to push_peer_info X-BeenThere: openvpn-devel@lists.sourceforge.net X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: openvpn-devel-bounces@lists.sourceforge.net X-getmail-retrieved-from-mailbox: Inbox This IV variable has nothing to do with compression and should not depend if OpenVPN is compiled with USE_COMP. So move it to the other generic IV variables. Signed-off-by: Arne Schwabe Acked-by: Gert Doering --- src/openvpn/comp.c | 1 - src/openvpn/ssl.c | 3 +++ 2 files changed, 3 insertions(+), 1 deletion(-) diff --git a/src/openvpn/comp.c b/src/openvpn/comp.c index 72b1511ea..ad49b00b9 100644 --- a/src/openvpn/comp.c +++ b/src/openvpn/comp.c @@ -169,7 +169,6 @@ comp_generate_peer_info_string(const struct compress_options *opt, struct buffer } buf_printf(out, "IV_COMP_STUB=1\n"); buf_printf(out, "IV_COMP_STUBv2=1\n"); - buf_printf(out, "IV_TCPNL=1\n"); } } diff --git a/src/openvpn/ssl.c b/src/openvpn/ssl.c index 7a09272c8..4d107016a 100644 --- a/src/openvpn/ssl.c +++ b/src/openvpn/ssl.c @@ -2184,6 +2184,9 @@ push_peer_info(struct buffer *buf, struct tls_session *session) #elif defined(_WIN32) buf_printf(&out, "IV_PLAT=win\n"); #endif + /* Announce that we do not require strict sequence numbers with + * TCP. (TCP non-linear) */ + buf_printf(&out, "IV_TCPNL=1\n"); } /* These are the IV variable that are sent to peers in p2p mode */