[Openvpn-devel] Include --push-remove in the output of --help.

Message ID 20211117064442.15899-1-gert@greenie.muc.de
State Accepted
Headers show
Series
  • [Openvpn-devel] Include --push-remove in the output of --help.
Related show

Commit Message

Gert Doering Nov. 17, 2021, 6:44 a.m.
"push-remove" has been in OpenVPN since 2.4, but managed to stay hidden
from the "--help" output.  Add.

Reported-by: mike tancsa <mike@sentex.net>

Signed-off-by: Gert Doering <gert@greenie.muc.de>
---
 src/openvpn/options.c | 2 ++
 1 file changed, 2 insertions(+)

Comments

Antonio Quartulli Nov. 17, 2021, 10:18 a.m. | #1
Hi,

On 17/11/2021 07:44, Gert Doering wrote:
> "push-remove" has been in OpenVPN since 2.4, but managed to stay hidden
> from the "--help" output.  Add.
> 
> Reported-by: mike tancsa <mike@sentex.net>
> 
> Signed-off-by: Gert Doering <gert@greenie.muc.de>

Acked-by: Antonio Quartulli <a@unstable.cc>

Let's uncover the easter eggs! (as if we did not have enough options 
already :-P)

Regards,
Gert Doering Nov. 17, 2021, 11:31 a.m. | #2
Patch has been applied to the master and release/2.5 branch.

commit 2a555c3aafcc8cf238a803d25971938ed75b518d (master)
commit 59a8406e0e10716939a587aff3cb9662ce951d47 (release/2.5)
Author: Gert Doering
Date:   Wed Nov 17 07:44:42 2021 +0100

     Include --push-remove in the output of --help.

     Signed-off-by: Gert Doering <gert@greenie.muc.de>
     Acked-by: Antonio Quartulli <antonio@openvpn.net>
     Message-Id: <20211117064442.15899-1-gert@greenie.muc.de>
     URL: https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg23194.html
     Signed-off-by: Gert Doering <gert@greenie.muc.de>


--
kind regards,

Gert Doering

Patch

diff --git a/src/openvpn/options.c b/src/openvpn/options.c
index a167a08a..cc3d9fa0 100644
--- a/src/openvpn/options.c
+++ b/src/openvpn/options.c
@@ -409,6 +409,8 @@  static const char usage_message[] =
     "                  execution.  Peer must specify --pull in its config file.\n"
     "--push-reset    : Don't inherit global push list for specific\n"
     "                  client instance.\n"
+    "--push-remove opt : Remove options matching 'opt' from the push list for\n"
+    "                  a specific client instance.\n"
     "--ifconfig-pool start-IP end-IP [netmask] : Set aside a pool of subnets\n"
     "                  to be dynamically allocated to connecting clients.\n"
     "--ifconfig-pool-persist file [seconds] : Persist/unpersist ifconfig-pool\n"