[Openvpn-devel,master+release/2.5] ssh_openssl.h: remove unused declaration

Message ID 20211201092002.162-1-lstipakov@gmail.com
State Accepted
Headers show
Series
  • [Openvpn-devel,master+release/2.5] ssh_openssl.h: remove unused declaration
Related show

Commit Message

Lev Stipakov Dec. 1, 2021, 9:20 a.m.
From: Lev Stipakov <lev@openvpn.net>

Commit 95993a1df3 ("Refactored SSL initialisation functions")
has declared openssl_set_mydata_index(void) function but
hasn't added definition.

There hasn't been need in this function for 10 years,
so it can be safely removed.

Found by MSVC.

Signed-off-by: Lev Stipakov <lev@openvpn.net>
---
 src/openvpn/ssl_openssl.h | 2 --
 1 file changed, 2 deletions(-)

Comments

Gert Doering Dec. 5, 2021, 12:46 p.m. | #1
Acked-by: Gert Doering <gert@greenie.muc.de>

"easy enough".  "Git grep" confirms.

Your patch has been applied to the master and release/2.5 branch.

commit b939fdcfb669bdd57b33e70fd2a2718fcfa626c9 (master)
commit c237d49ec52241edb6b1a839baae04bdb37f8bd0 (release/2.5)
Author: Lev Stipakov
Date:   Wed Dec 1 11:20:02 2021 +0200

     ssh_openssl.h: remove unused declaration

     Signed-off-by: Lev Stipakov <lev@openvpn.net>
     Acked-by: Gert Doering <gert@greenie.muc.de>
     Message-Id: <20211201092002.162-1-lstipakov@gmail.com>
     URL: https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg23269.html
     Signed-off-by: Gert Doering <gert@greenie.muc.de>


--
kind regards,

Gert Doering

Patch

diff --git a/src/openvpn/ssl_openssl.h b/src/openvpn/ssl_openssl.h
index 2eeb716c..46338c24 100644
--- a/src/openvpn/ssl_openssl.h
+++ b/src/openvpn/ssl_openssl.h
@@ -54,6 +54,4 @@  struct key_state_ssl {
  */
 extern int mydata_index; /* GLOBAL */
 
-void openssl_set_mydata_index(void);
-
 #endif /* SSL_OPENSSL_H_ */