[Openvpn-devel,11/21] Remove pointless do_init_frame_tls function

Message ID 20211207170211.3275837-12-arne@rfc2549.org
State Accepted
Headers show
Series Big buffer/frame refactoring patch set | expand

Commit Message

Arne Schwabe Dec. 7, 2021, 6:02 a.m. UTC
This function is static and just calls another functions.

Signed-off-by: Arne Schwabe <arne@rfc2549.org>
---
 src/openvpn/init.c | 8 +-------
 1 file changed, 1 insertion(+), 7 deletions(-)

Comments

Frank Lichtenheld Dec. 10, 2021, 5:51 a.m. UTC | #1
Acked-By: Frank Lichtenheld <frank@lichtenheld.com>

> Arne Schwabe <arne@rfc2549.org> hat am 07.12.2021 18:02 geschrieben:
> 
>  
> This function is static and just calls another functions.
> 
> Signed-off-by: Arne Schwabe <arne@rfc2549.org>
--
Frank Lichtenheld
Gert Doering Dec. 31, 2021, 12:40 a.m. UTC | #2
Not tested beyond "make check", change is trivial enough.

Your patch has been applied to the master branch.

commit 2b6fcdc0280c9e56c4ce0f348cab7511b809b839
Author: Arne Schwabe
Date:   Tue Dec 7 18:02:01 2021 +0100

     Remove pointless do_init_frame_tls function

     Signed-off-by: Arne Schwabe <arne@rfc2549.org>
     Acked-by: Frank Lichtenheld <frank@lichtenheld.com>
     Message-Id: <20211207170211.3275837-12-arne@rfc2549.org>
     URL: https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg23337.html
     Signed-off-by: Gert Doering <gert@greenie.muc.de>


--
kind regards,

Gert Doering

Patch

diff --git a/src/openvpn/init.c b/src/openvpn/init.c
index 2ce963663..0287dda35 100644
--- a/src/openvpn/init.c
+++ b/src/openvpn/init.c
@@ -3045,7 +3045,7 @@  do_init_crypto_tls(struct context *c, const unsigned int flags)
 }
 
 static void
-do_init_finalize_tls_frame(struct context *c)
+do_init_frame_tls(struct context *c)
 {
     if (c->c2.tls_multi)
     {
@@ -3302,12 +3302,6 @@  do_option_warnings(struct context *c)
     }
 }
 
-static void
-do_init_frame_tls(struct context *c)
-{
-    do_init_finalize_tls_frame(c);
-}
-
 struct context_buffers *
 init_context_buffers(struct frame *frame)
 {