[Openvpn-devel] Add argv_insert_head__empty_argv__head_only to argv tests

Message ID 20211208170614.3404821-1-arne@rfc2549.org
State Accepted
Headers show
Series
  • [Openvpn-devel] Add argv_insert_head__empty_argv__head_only to argv tests
Related show

Commit Message

Arne Schwabe Dec. 8, 2021, 5:06 p.m.
The unit test argv_insert_head__empty_argv__head_only was defined
but never used. Add it to the array of unit tests.

Signed-off-by: Arne Schwabe <arne@rfc2549.org>
---
 tests/unit_tests/openvpn/test_argv.c | 1 +
 1 file changed, 1 insertion(+)

Comments

Gert Doering Dec. 9, 2021, 11:22 a.m. | #1
Acked-by: Gert Doering <gert@greenie.muc.de>

Having unit tests is good.  Actually running them is better :-) - found
at testing the latest MaxF patch on 2.5...

Your patch has been applied to the master and release/2.5 branch.

commit cc39fc7f3bddc6567507406cf8a389418e101bf8 (master)
commit 555a74419478ea24aa353698a8706b4b2ed43916 (release/2.5)
Author: Arne Schwabe
Date:   Wed Dec 8 18:06:14 2021 +0100

     Add argv_insert_head__empty_argv__head_only to argv tests

     Signed-off-by: Arne Schwabe <arne@rfc2549.org>
     Acked-by: Gert Doering <gert@greenie.muc.de>
     Message-Id: <20211208170614.3404821-1-arne@rfc2549.org>
     URL: https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg23359.html
     Signed-off-by: Gert Doering <gert@greenie.muc.de>


--
kind regards,

Gert Doering

Patch

diff --git a/tests/unit_tests/openvpn/test_argv.c b/tests/unit_tests/openvpn/test_argv.c
index e686adcb5..1b18ac0d4 100644
--- a/tests/unit_tests/openvpn/test_argv.c
+++ b/tests/unit_tests/openvpn/test_argv.c
@@ -266,6 +266,7 @@  main(void)
         cmocka_unit_test(argv_str__empty_argv__empty_output),
         cmocka_unit_test(argv_str__multiple_argv__correct_output),
         cmocka_unit_test(argv_insert_head__non_empty_argv__head_added),
+        cmocka_unit_test(argv_insert_head__empty_argv__head_only),
     };
 
     return cmocka_run_group_tests_name("argv", tests, NULL, NULL);