[Openvpn-devel] add test case(s) to notice 'openvpn --show-cipher' crashing

Message ID 20211210165543.77587-1-gert@greenie.muc.de
State Accepted
Headers show
Series
  • [Openvpn-devel] add test case(s) to notice 'openvpn --show-cipher' crashing
Related show

Commit Message

Gert Doering Dec. 10, 2021, 4:55 p.m.
Signed-off-by: Gert Doering <gert@greenie.muc.de>
---
 tests/t_lpback.sh | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)

Comments

Arne Schwabe Dec. 10, 2021, 4:59 p.m. | #1
ACK.

That one bit me. I didn't test those tests manually since I assumed they 
would be caught by make check :(

Acked-By: Arne Schwabe <arne@rfc2549.org>
Gert Doering Dec. 10, 2021, 5:22 p.m. | #2
Your patch has been applied to the master and release/2.5 branch
(enhancing tests is always a good reason!).

commit b08b5f5df96dbe7d854a2fbbeb8a3e104e3158e2 (master)
commit 1a744d1da6667506e6c201751834c768ac8a6e6f (release/2.5)
Author: Gert Doering
Date:   Fri Dec 10 17:55:43 2021 +0100

     add test case(s) to notice 'openvpn --show-cipher' crashing

     Signed-off-by: Gert Doering <gert@greenie.muc.de>
     Acked-by: Arne Schwabe <arne@rfc2549.org>
     Message-Id: <20211210165543.77587-1-gert@greenie.muc.de>
     URL: https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg23381.html
     Signed-off-by: Gert Doering <gert@greenie.muc.de>


--
kind regards,

Gert Doering

Patch

diff --git a/tests/t_lpback.sh b/tests/t_lpback.sh
index 6206899d..67952994 100755
--- a/tests/t_lpback.sh
+++ b/tests/t_lpback.sh
@@ -35,13 +35,18 @@  CIPHERS=$(${top_builddir}/src/openvpn/openvpn --show-ciphers | \
 # GD, 2014-07-06 do not test RC5-* either (fails on NetBSD w/o libcrypto_rc5)
 CIPHERS=$(echo "$CIPHERS" | egrep -v '^(DES-EDE3-CFB1|DES-CFB1|RC5-)' )
 
+e=0
+if [ -z "$CIPHERS" ] ; then
+    echo "'openvpn --show-ciphers' FAILED (empty list)"
+    e=1
+fi
+
 # Also test cipher 'none'
 CIPHERS=${CIPHERS}$(printf "\nnone")
 
 "${top_builddir}/src/openvpn/openvpn" --genkey secret key.$$
 set +e
 
-e=0
 for cipher in ${CIPHERS}
 do
     printf "Testing cipher ${cipher}... "