[Openvpn-devel,master] config-msvc.h: indicate key material export support

Message ID 20211213135253.212-1-lstipakov@gmail.com
State Accepted
Headers show
Series
  • [Openvpn-devel,master] config-msvc.h: indicate key material export support
Related show

Commit Message

Lev Stipakov Dec. 13, 2021, 1:52 p.m.
From: Lev Stipakov <lev@openvpn.net>

MSVC build uses OpenSSL from vcpkg, which at the moment
is 1.1.1l. Key material export was added to 1.1.1, so it is safe
to indicate its support unconditionally.

This enables Windows releases to benefit from tls-ekm
data channel keys derivation.

Signed-off-by: Lev Stipakov <lev@openvpn.net>
---
 config-msvc.h | 1 +
 1 file changed, 1 insertion(+)

Comments

Arne Schwabe Dec. 13, 2021, 2:09 p.m. | #1
Am 13.12.21 um 14:52 schrieb Lev Stipakov:
> From: Lev Stipakov <lev@openvpn.net>
> 
> MSVC build uses OpenSSL from vcpkg, which at the moment
> is 1.1.1l. Key material export was added to 1.1.1, so it is safe
> to indicate its support unconditionally.
> 
> This enables Windows releases to benefit from tls-ekm
> data channel keys derivation.
> 

Acked-By: Arne Schwabe <arne@rfc2549.org>
Gert Doering Dec. 13, 2021, 2:39 p.m. | #2
Have not tested anything, but this seems to make sense.

Your patch has been applied to the master branch.

commit b031495ff9f0281459fb8ca06240b9a32c50c5c9
Author: Lev Stipakov
Date:   Mon Dec 13 15:52:53 2021 +0200

     config-msvc.h: indicate key material export support

     Signed-off-by: Lev Stipakov <lev@openvpn.net>
     Acked-by: Arne Schwabe <arne@rfc2549.org>
     Message-Id: <20211213135253.212-1-lstipakov@gmail.com>
     URL: https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg23394.html
     Signed-off-by: Gert Doering <gert@greenie.muc.de>


--
kind regards,

Gert Doering

Patch

diff --git a/config-msvc.h b/config-msvc.h
index 0ae38482..b08beb52 100644
--- a/config-msvc.h
+++ b/config-msvc.h
@@ -40,6 +40,7 @@ 
 #define HAVE_IN_PKTINFO 1
 
 #define HAVE_OPENSSL_ENGINE 1
+#define HAVE_EXPORT_KEYING_MATERIAL 1
 
 #define HAVE_DIINSTALLDEVICE 1