[Openvpn-devel] Make github actions names nicer, include Ubuntu18+OpenSSL 1.0.2

Message ID 20211215123449.53818-1-arne@rfc2549.org
State Accepted
Headers show
Series
  • [Openvpn-devel] Make github actions names nicer, include Ubuntu18+OpenSSL 1.0.2
Related show

Commit Message

Arne Schwabe Dec. 15, 2021, 12:34 p.m.
Also let other variants finish if one fails (fail-fast: false)

Signed-off-by: Arne Schwabe <arne@rfc2549.org>
---
 .github/workflows/build.yaml | 33 +++++++++++++++++++++++++++++++--
 1 file changed, 31 insertions(+), 2 deletions(-)

Comments

Gert Doering Dec. 29, 2021, 10:39 a.m. | #1
Acked-by: Gert Doering <gert@greenie.muc.de>

Looks reasonable.

(I'm a bit confused that we seem to have lost OpenSSL 3.0 actions - I
dimly remember we had one, or at least a patch for one...)

Your patch has been applied to the master branch.

commit 919d10ad4a51404a41e594c2b8985647ae1d6b3e
Author: Arne Schwabe
Date:   Wed Dec 15 13:34:49 2021 +0100

     Make github actions names nicer, include Ubuntu18+OpenSSL 1.0.2

     Signed-off-by: Arne Schwabe <arne@rfc2549.org>
     Acked-by: Gert Doering <gert@greenie.muc.de>
     Message-Id: <20211215123449.53818-1-arne@rfc2549.org>
     URL: https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg23452.html
     Signed-off-by: Gert Doering <gert@greenie.muc.de>


--
kind regards,

Gert Doering
Arne Schwabe Dec. 29, 2021, 1:17 p.m. | #2
Am 29.12.21 um 11:39 schrieb Gert Doering:
> Acked-by: Gert Doering <gert@greenie.muc.de>
> 
> Looks reasonable.
> 
> (I'm a bit confused that we seem to have lost OpenSSL 3.0 actions - I
> dimly remember we had one, or at least a patch for one...)
> 
> Your patch has been applied to the master branch.
> 

We have OpenSSL 3.0 actions for macos. Maybe that is what you are 
remembering.

Arne

Patch

diff --git a/.github/workflows/build.yaml b/.github/workflows/build.yaml
index e5a4e857b..440ef7273 100644
--- a/.github/workflows/build.yaml
+++ b/.github/workflows/build.yaml
@@ -5,6 +5,7 @@  on: [push, pull_request]
 jobs:
   mingw:
     strategy:
+      fail-fast: false
       matrix:
         include:
           - target: mingw64
@@ -12,6 +13,8 @@  jobs:
           - target: mingw
             chost: i686-w64-mingw32
 
+    name: "gcc-mingw - ${{matrix.target}}"
+    
     runs-on: ubuntu-20.04
     env:
       MAKEFLAGS: -j3
@@ -125,14 +128,35 @@  jobs:
 
   ubuntu:
     strategy:
+      fail-fast: false
       matrix:
         os: [ubuntu-18.04, ubuntu-20.04]
-        ssllib: [mbedtls, openssl]
+        sslpkg: [libssl-dev]
+        ssllib: [mbedtls]
+        libname: [mbed TLS]
+
+        include:
+          - os: ubuntu-18.04
+            sslpkg: "libssl1.0-dev"
+            ssllib: openssl
+            libname: OpenSSL 1.0.2
+          - os: ubuntu-18.04
+            sslpkg: "libssl-dev"
+            libname: OpenSSL 1.1.1
+            ssllib: openssl
+          - os: ubuntu-20.04
+            sslpkg: "libssl-dev"
+            libname: OpenSSL 1.1.1
+            ssllib: openssl
+
+    name: "gcc - ${{matrix.os}} - ${{matrix.libname}}"
+    env:
+      SSLPKG: "${{matrix.sslpkg}}"
 
     runs-on: ${{matrix.os}}
     steps:
       - name: Install dependencies
-        run: sudo apt update && sudo apt install -y liblzo2-dev libpam0g-dev liblz4-dev linux-libc-dev man2html libcmocka-dev python3-docutils libtool automake autoconf libmbedtls-dev
+        run: sudo apt update && sudo apt install -y liblzo2-dev libpam0g-dev liblz4-dev linux-libc-dev man2html libcmocka-dev python3-docutils libtool automake autoconf ${SSLPKG}
       - name: Checkout OpenVPN
         uses: actions/checkout@v2
       - name: autoconf
@@ -146,10 +170,13 @@  jobs:
 
   ubuntu-clang-asan:
     strategy:
+      fail-fast: false
       matrix:
         os: [ubuntu-20.04]
         ssllib: [mbedtls, openssl]
 
+    name: "clang-asan - ${{matrix.os}} - ${{matrix.ssllib}}"
+
     runs-on: ${{matrix.os}}
     steps:
       - name: Install dependencies
@@ -206,6 +233,7 @@  jobs:
 
   msvc:
       strategy:
+        fail-fast: false
         matrix:
           plat: [ARM64, Win32, x64]
           include:
@@ -216,6 +244,7 @@  jobs:
             - plat: x64
               triplet: x64
 
+      name: "msbuild - ${{matrix.triplet}} - openssl"
       env:
         BUILD_CONFIGURATION: Release
         VCPKG_OVERLAY_PORTS: ${{ github.workspace }}/contrib/vcpkg-ports