[Openvpn-devel] GitHub Actions: ensure Ubuntu builds are made with the chosen SSL library

Message ID 20220114111535.19970-1-a@unstable.cc
State Superseded
Headers show
Series
  • [Openvpn-devel] GitHub Actions: ensure Ubuntu builds are made with the chosen SSL library
Related show

Commit Message

Antonio Quartulli Jan. 14, 2022, 11:15 a.m.
The configure parameter was appended to the stage name but not to the
actual command. Fix this.

Signed-off-by: Antonio Quartulli <a@unstable.cc>
---
 .github/workflows/build.yaml | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

Comments

Antonio Quartulli Jan. 14, 2022, 12:12 p.m. | #1
NAK.

This change still lacks installing mbedtls as dependency.

On 14/01/2022 12:15, Antonio Quartulli wrote:
> The configure parameter was appended to the stage name but not to the
> actual command. Fix this.
> 
> Signed-off-by: Antonio Quartulli <a@unstable.cc>
> ---
>   .github/workflows/build.yaml | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/.github/workflows/build.yaml b/.github/workflows/build.yaml
> index ea1233b1..f96515bc 100644
> --- a/.github/workflows/build.yaml
> +++ b/.github/workflows/build.yaml
> @@ -161,8 +161,8 @@ jobs:
>           uses: actions/checkout@v2
>         - name: autoconf
>           run: autoreconf -fvi
> -      - name: configure --with-crypto-library=${{matrix.ssllib}}
> -        run: ./configure
> +      - name: configure
> +        run: ./configure --with-crypto-library=${{matrix.ssllib}}
>         - name: make all
>           run: make -j3
>         - name: make check

Patch

diff --git a/.github/workflows/build.yaml b/.github/workflows/build.yaml
index ea1233b1..f96515bc 100644
--- a/.github/workflows/build.yaml
+++ b/.github/workflows/build.yaml
@@ -161,8 +161,8 @@  jobs:
         uses: actions/checkout@v2
       - name: autoconf
         run: autoreconf -fvi
-      - name: configure --with-crypto-library=${{matrix.ssllib}}
-        run: ./configure
+      - name: configure
+        run: ./configure --with-crypto-library=${{matrix.ssllib}}
       - name: make all
         run: make -j3
       - name: make check