[Openvpn-devel,v2] GitHub Actions: ensure Ubuntu builds are made with the chosen SSL library

Message ID 20220114122538.24662-1-a@unstable.cc
State Accepted
Headers show
Series
  • [Openvpn-devel,v2] GitHub Actions: ensure Ubuntu builds are made with the chosen SSL library
Related show

Commit Message

Antonio Quartulli Jan. 14, 2022, 12:25 p.m.
The configure parameter was appended to the stage name but not to the
actual command. Fix this.

Cc: Arne Schwabe <arne@rfc2549.org>
Signed-off-by: Antonio Quartulli <a@unstable.cc>
---

Changes from v2:
* fix typ0 in sslpkg name for mbedtls

 .github/workflows/build.yaml | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

Comments

Gert Doering Jan. 14, 2022, 1:18 p.m. | #1
Acked-by: Gert Doering <gert@greenie.muc.de>

"D'oh"... no idea who merged that original patch... :-)

Your patch has been applied to the master branch.

commit 6445bf30c12a87c06ee0b24b19293efefc8cad27
Author: Antonio Quartulli
Date:   Fri Jan 14 13:25:38 2022 +0100

     GitHub Actions: ensure Ubuntu builds are made with the chosen SSL library

     Signed-off-by: Antonio Quartulli <a@unstable.cc>
     Acked-by: Gert Doering <gert@greenie.muc.de>
     Message-Id: <20220114122538.24662-1-a@unstable.cc>
     URL: https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg23539.html
     Signed-off-by: Gert Doering <gert@greenie.muc.de>


--
kind regards,

Gert Doering

Patch

diff --git a/.github/workflows/build.yaml b/.github/workflows/build.yaml
index ea1233b1..354a3256 100644
--- a/.github/workflows/build.yaml
+++ b/.github/workflows/build.yaml
@@ -131,7 +131,7 @@  jobs:
       fail-fast: false
       matrix:
         os: [ubuntu-18.04, ubuntu-20.04]
-        sslpkg: [libssl-dev]
+        sslpkg: [libmbedtls-dev]
         ssllib: [mbedtls]
         libname: [mbed TLS]
 
@@ -161,8 +161,8 @@  jobs:
         uses: actions/checkout@v2
       - name: autoconf
         run: autoreconf -fvi
-      - name: configure --with-crypto-library=${{matrix.ssllib}}
-        run: ./configure
+      - name: configure
+        run: ./configure --with-crypto-library=${{matrix.ssllib}}
       - name: make all
         run: make -j3
       - name: make check