[Openvpn-devel] GitHub Actions: add other config flavours

Message ID 20220119232743.16779-1-a@unstable.cc
State Superseded
Headers show
Series
  • [Openvpn-devel] GitHub Actions: add other config flavours
Related show

Commit Message

Antonio Quartulli Jan. 19, 2022, 11:27 p.m.
In the past we had issues with patches accidentally breaking less common
OpenVPN configurations. For this reason it makes sense to some of those
configurations build via CI.

Adding:
* --enable-iproute2
* --enable-async-push
* --disable-management
* --enable-small
* --disable-lzo
* --disable-lz4

These flavours are all built on Ubuntu 20.04 with OpenSSL 1.1.1

Signed-off-by: Antonio Quartulli <a@unstable.cc>
---

The GH Actions run for this patch can be found at:
https://github.com/ordex/openvpn/actions/runs/1719339028



 .github/workflows/build.yaml | 34 ++++++++++++++++++++++++++++++++--
 1 file changed, 32 insertions(+), 2 deletions(-)

Comments

Gert Doering Jan. 20, 2022, 7:45 a.m. | #1
Hi,

On Thu, Jan 20, 2022 at 12:27:43AM +0100, Antonio Quartulli wrote:
> * --disable-lzo
> * --disable-lz4

Not sure having them individually does much good, but we definitely
want a config with "disable all compression" (--disable-lzo --disable-lz4).

This was what we broke last time :-)

(And it might actually still be broken at run time... MaxF?)

gert

Patch

diff --git a/.github/workflows/build.yaml b/.github/workflows/build.yaml
index 354a3256..a47b3481 100644
--- a/.github/workflows/build.yaml
+++ b/.github/workflows/build.yaml
@@ -148,8 +148,38 @@  jobs:
             sslpkg: "libssl-dev"
             libname: OpenSSL 1.1.1
             ssllib: openssl
+          - os: ubuntu-20.04
+            sslpkg: "libssl-dev"
+            libname: OpenSSL 1.1.1
+            ssllib: openssl
+            extraconf: "--enable-iproute2"
+          - os: ubuntu-20.04
+            sslpkg: "libssl-dev"
+            libname: OpenSSL 1.1.1
+            ssllib: openssl
+            extraconf: "--enable-async-push"
+          - os: ubuntu-20.04
+            sslpkg: "libssl-dev"
+            libname: OpenSSL 1.1.1
+            ssllib: openssl
+            extraconf: "--disable-management"
+          - os: ubuntu-20.04
+            sslpkg: "libssl-dev"
+            libname: OpenSSL 1.1.1
+            ssllib: openssl
+            extraconf: "--enable-small"
+          - os: ubuntu-20.04
+            sslpkg: "libssl-dev"
+            libname: OpenSSL 1.1.1
+            ssllib: openssl
+            extraconf: "--disable-lzo"
+          - os: ubuntu-20.04
+            sslpkg: "libssl-dev"
+            libname: OpenSSL 1.1.1
+            ssllib: openssl
+            extraconf: "--disable-lz4"
 
-    name: "gcc - ${{matrix.os}} - ${{matrix.libname}}"
+    name: "gcc - ${{matrix.os}} - ${{matrix.libname}} ${{matrix.extraconf}}"
     env:
       SSLPKG: "${{matrix.sslpkg}}"
 
@@ -162,7 +192,7 @@  jobs:
       - name: autoconf
         run: autoreconf -fvi
       - name: configure
-        run: ./configure --with-crypto-library=${{matrix.ssllib}}
+        run: ./configure --with-crypto-library=${{matrix.ssllib}} ${{matrix.extraconf}}
       - name: make all
         run: make -j3
       - name: make check