[Openvpn-devel,2/2] Add Werror to github action ubuntu build

Message ID 20220214021054.3750071-2-arne@rfc2549.org
State Accepted
Headers show
Series
  • [Openvpn-devel,1/2] Fix 'defined but not used' warnings with enable-small/disable-management
Related show

Commit Message

Arne Schwabe Feb. 14, 2022, 2:10 a.m.
Signed-off-by: Arne Schwabe <arne@rfc2549.org>
---
 .github/workflows/build.yaml | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Gert Doering Feb. 14, 2022, 7:16 a.m. | #1
Acked-by: Gert Doering <gert@greenie.muc.de>

Makes sense.  The code should be warning-free on Linux no, so enforce it.

(I seem to remember we already added this elsewhere for Linux CI builds)

Your patch has been applied to the master branch.

commit afa875bc7036edc78c89f4b2215deb0169807daa
Author: Arne Schwabe
Date:   Mon Feb 14 03:10:54 2022 +0100

     Add Werror to github action ubuntu build

     Signed-off-by: Arne Schwabe <arne@rfc2549.org>
     Acked-by: Gert Doering <gert@greenie.muc.de>
     Message-Id: <20220214021054.3750071-2-arne@rfc2549.org>
     URL: https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg23778.html
     Signed-off-by: Gert Doering <gert@greenie.muc.de>


--
kind regards,

Gert Doering

Patch

diff --git a/.github/workflows/build.yaml b/.github/workflows/build.yaml
index f1a75736..34d1dcce 100644
--- a/.github/workflows/build.yaml
+++ b/.github/workflows/build.yaml
@@ -187,7 +187,7 @@  jobs:
       - name: autoconf
         run: autoreconf -fvi
       - name: configure
-        run: ./configure --with-crypto-library=${{matrix.ssllib}} ${{matrix.extraconf}}
+        run: ./configure --with-crypto-library=${{matrix.ssllib}} ${{matrix.extraconf}} --enable-werror
       - name: make all
         run: make -j3
       - name: make check