From patchwork Tue Feb 22 02:16:56 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Kristof Provost via Openvpn-devel X-Patchwork-Id: 2314 Return-Path: Delivered-To: patchwork@openvpn.net Delivered-To: patchwork@openvpn.net Received: from director11.mail.ord1d.rsapps.net ([172.27.255.55]) by backend41.mail.ord1d.rsapps.net with LMTP id SEtAJ0DpFGJUHQAAqwncew (envelope-from ) for ; Tue, 22 Feb 2022 08:46:40 -0500 Received: from proxy12.mail.iad3a.rsapps.net ([172.27.255.55]) by director11.mail.ord1d.rsapps.net with LMTP id iL0lA0HpFGL5eAAAvGGmqA (envelope-from ) for ; Tue, 22 Feb 2022 08:46:41 -0500 Received: from smtp49.gate.iad3a ([172.27.255.55]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) by proxy12.mail.iad3a.rsapps.net with LMTPS id YDp6NkDpFGKRUAAAh9K5Vw (envelope-from ) for ; Tue, 22 Feb 2022 08:46:40 -0500 X-Spam-Threshold: 95 X-Spam-Score: 0 X-Spam-Flag: NO X-Virus-Scanned: OK X-Orig-To: openvpnslackdevel@openvpn.net X-Originating-Ip: [216.105.38.7] Authentication-Results: smtp49.gate.iad3a.rsapps.net; iprev=pass policy.iprev="216.105.38.7"; spf=pass smtp.mailfrom="openvpn-devel-bounces@lists.sourceforge.net" smtp.helo="lists.sourceforge.net"; dkim=fail (signature verification failed) header.d=sourceforge.net; dkim=fail (signature verification failed) header.d=sf.net; dkim=fail (signature verification failed) header.d=netgate.com; dmarc=pass (p=none; dis=none) header.from=lists.sourceforge.net X-Suspicious-Flag: YES X-Classification-ID: dc95efb8-93e5-11ec-a8a2-525400fffce0-1-1 Received: from [216.105.38.7] ([216.105.38.7:41256] helo=lists.sourceforge.net) by smtp49.gate.iad3a.rsapps.net (envelope-from ) (ecelerity 4.2.38.62370 r(:)) with ESMTPS (cipher=DHE-RSA-AES256-GCM-SHA384) id 2E/AF-11802-049E4126; Tue, 22 Feb 2022 08:46:40 -0500 Received: from [127.0.0.1] (helo=sfs-ml-1.v29.lw.sourceforge.com) by sfs-ml-1.v29.lw.sourceforge.com with esmtp (Exim 4.94.2) (envelope-from ) id 1nMVUI-00059n-S8; Tue, 22 Feb 2022 13:45:53 +0000 Received: from [172.30.20.202] (helo=mx.sourceforge.net) by sfs-ml-1.v29.lw.sourceforge.com with esmtps (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1nMVUI-00059c-39 for openvpn-devel@lists.sourceforge.net; Tue, 22 Feb 2022 13:45:52 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sourceforge.net; s=x; h=Content-Transfer-Encoding:MIME-Version:References: In-Reply-To:Message-Id:Date:Subject:To:From:Sender:Reply-To:Cc:Content-Type: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=pqNJz5tWYlWncGVxv/SAEYDzHKTJuGoGZH8qzJvabzM=; b=WEEfZBeznBLTz3ovJvzRMG5o4W MkgnkGJVQ6g4NEPcYMvNG+N8ZgsiCyhVZfWVh7YWu9gs858DG74Kx3bHOjWNEojyzy/JGls7PIQeM IRgfPYyCa8pallKmKtYlbCBk/8lu32LE31aji4A8zx2vdcgEygjZZVPdFnhZlAtbr8Cs=; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sf.net; s=x ; h=Content-Transfer-Encoding:MIME-Version:References:In-Reply-To:Message-Id: Date:Subject:To:From:Sender:Reply-To:Cc:Content-Type:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=pqNJz5tWYlWncGVxv/SAEYDzHKTJuGoGZH8qzJvabzM=; b=flkHyjKwDZPTa5huMiZSlhplKr ydYne4LZlgtQZo1UonChiI0CsQNcLuEKDe/Coi3MgKMZ2wBFQiU2hWyp4bsF+VwuPp1a2XWdx4yiN udcPoJPOwhbGUUyN44gwMem2wBdw0kCdjnSdD16mv6i4Aj56CNMTsM7vkZaRGj6TFEMU=; Received: from mail-lj1-f180.google.com ([209.85.208.180]) by sfi-mx-2.v28.lw.sourceforge.com with esmtps (TLS1.2:ECDHE-RSA-AES128-GCM-SHA256:128) (Exim 4.94.2) id 1nMVUF-0008M0-ST for openvpn-devel@lists.sourceforge.net; Tue, 22 Feb 2022 13:45:52 +0000 Received: by mail-lj1-f180.google.com with SMTP id p20so11242360ljo.0 for ; Tue, 22 Feb 2022 05:45:51 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=netgate.com; s=google; h=from:to:subject:date:message-id:in-reply-to:references:mime-version :content-transfer-encoding; bh=pqNJz5tWYlWncGVxv/SAEYDzHKTJuGoGZH8qzJvabzM=; b=TWCrNArj6yMj7nWYdLmLS0RRe/ryvZpyYansKhTTzAKy5TLjKpI6kzNMn+P58g8LP3 3l2mIBYm5KjDM4fFE9aMLpv+zAUgH1Fp5vspZs02qKckbcESw3K2TN6vafpsajl2uIsH z9eiko/GsTZuhdRhe8yrEjCC1Qf+J1TJWd2SE= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=pqNJz5tWYlWncGVxv/SAEYDzHKTJuGoGZH8qzJvabzM=; b=jNSA44uRTji3qWW3/O1myRZXZFKjl2/ZAeJoOyXHG2CH9neBNgc9UIgJgJZh83Htcd fWbwVwt1bBtbbkNqQ1SdzIjFrSrQlUdLnjHAQ3Z0xa7rWPXtDJvNUNeASrOhMZzGsdFq yoaB91djyDl4jfHIuFEIfHAJArRBQp8/JwJ5d5oYY3MFj5/htdiqJqT5iVPex+LKLBM8 BxSZNdVIvKKhZjvGOJJnyMDXFrZNqfClYInWdu4RfMOhwdHzkl0xFAwmCC09mXSH40gP +pih4gz0gOqOnTlybRoow/Nvn7OI1p++6c1tQBsMoc+GEqGzXz2uSxJXyVOHH4hJhJ6v xzHQ== X-Gm-Message-State: AOAM531jq93k/hzwgDrnNg50pLFU721V3MNSvtF6B+BUXUNWo/EGfo7e YFPa5/XaeMeA5JTxhG6nSDY1bi8b9dou+u9G X-Google-Smtp-Source: ABdhPJzUHgQmBuk+4f3ahXFzeVDIGAcvYIGFN3J49QNj2MYIFU+eUS6psdSpc/hSo485LSViON1xAQ== X-Received: by 2002:a50:fc09:0:b0:40f:e199:b266 with SMTP id i9-20020a50fc09000000b0040fe199b266mr25826493edr.350.1645535822464; Tue, 22 Feb 2022 05:17:02 -0800 (PST) Received: from nut.jupiter.sigsegv.be (ptr-8rgvk5277arubwggeqg.18120a2.ip6.access.telenet.be. [2a02:1811:240d:2900:f602:70ff:feae:6e98]) by smtp.googlemail.com with ESMTPSA id z6sm6302170ejd.96.2022.02.22.05.17.01 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 22 Feb 2022 05:17:01 -0800 (PST) To: openvpn-devel Date: Tue, 22 Feb 2022 14:16:56 +0100 Message-Id: <20220222131657.6616-3-kprovost@netgate.com> X-Mailer: git-send-email 2.35.1 In-Reply-To: <20220222131657.6616-1-kprovost@netgate.com> References: <20220222131657.6616-1-kprovost@netgate.com> MIME-Version: 1.0 X-Spam-Report: Spam detection software, running on the system "util-spamd-2.v13.lw.sourceforge.com", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: From: Kristof Provost It seems clear that the intent here is to special case the EEXIST error, not the consider anything else (i.e. 0) to also be an error. Signed-off-by: Kristof Provost --- src/openvpn/tun.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) Content analysis details: (-0.2 points, 6.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [209.85.208.180 listed in list.dnswl.org] -0.0 RCVD_IN_MSPIKE_H2 RBL: Average reputation (+2) [209.85.208.180 listed in wl.mailspike.net] 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record -0.0 SPF_PASS SPF: sender matches SPF record -0.1 DKIM_VALID_EF Message has a valid DKIM or DK signature from envelope-from domain -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid -0.0 T_SCC_BODY_TEXT_LINE No description available. X-Headers-End: 1nMVUF-0008M0-ST Subject: [Openvpn-devel] [PATCH 2/3] open_tun_generic(): Do not consider open_tun_dco() returning 0 to be an error X-BeenThere: openvpn-devel@lists.sourceforge.net X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-Patchwork-Original-From: Kristof Provost via Openvpn-devel From: Kristof Provost via Openvpn-devel Reply-To: Kristof Provost Errors-To: openvpn-devel-bounces@lists.sourceforge.net X-getmail-retrieved-from-mailbox: Inbox From: Kristof Provost It seems clear that the intent here is to special case the EEXIST error, not the consider anything else (i.e. 0) to also be an error. Signed-off-by: Kristof Provost --- src/openvpn/tun.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/openvpn/tun.c b/src/openvpn/tun.c index f9ba3858..d8f2dea7 100644 --- a/src/openvpn/tun.c +++ b/src/openvpn/tun.c @@ -1841,7 +1841,7 @@ open_tun_generic(const char *dev, const char *dev_type, const char *dev_node, dynamic_name); tt->persistent_if = true; } - else + else if (ret != 0) { msg(M_ERR, "Cannot open TUN/TAP dev %s: %d", dynamic_name, ret); }